From nobody Mon Feb 9 08:12:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1536685820627594.820704576053; Tue, 11 Sep 2018 10:10:20 -0700 (PDT) Received: from localhost ([::1]:58691 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzmB9-0005xF-BR for importer@patchew.org; Tue, 11 Sep 2018 13:10:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fzm6z-0000E3-HN for qemu-devel@nongnu.org; Tue, 11 Sep 2018 13:06:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fzlre-0002gX-0Q for qemu-devel@nongnu.org; Tue, 11 Sep 2018 12:50:14 -0400 Received: from mail-eopbgr730079.outbound.protection.outlook.com ([40.107.73.79]:55072 helo=NAM05-DM3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fzlrd-0002dH-Q8 for qemu-devel@nongnu.org; Tue, 11 Sep 2018 12:50:09 -0400 Received: from sbrijesh-desktop.amd.com (165.204.77.1) by SN6PR12MB2688.namprd12.prod.outlook.com (2603:10b6:805:6f::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1122.16; Tue, 11 Sep 2018 16:50:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQCMmuqVx3NbpG61XIWlgmEriZfpWbyMpfIlvjvSRMw=; b=3GGdkUIFwkveAXrQYnyL2U4/w6yl9E+Q5pgJe8pKpwRU+C5Xu8WXXIpJljUA1bTrJax9YvNmMAE6krwJedPU5GjiIA5YHOcpwAp/tHG7m4+PJGX1gPg83J25C3O+El9ZtrY/noYQSQBh5Q7pp38n4eutx48zZK6Dvtg4IpVjpe8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; From: Brijesh Singh To: qemu-devel@nongnu.org Date: Tue, 11 Sep 2018 11:49:44 -0500 Message-Id: <1536684589-11718-2-git-send-email-brijesh.singh@amd.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1536684589-11718-1-git-send-email-brijesh.singh@amd.com> References: <1536684589-11718-1-git-send-email-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN1PR12CA0065.namprd12.prod.outlook.com (2603:10b6:802:20::36) To SN6PR12MB2688.namprd12.prod.outlook.com (2603:10b6:805:6f::29) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d67504ff-549c-4632-a5d2-08d61806a05e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:SN6PR12MB2688; X-Microsoft-Exchange-Diagnostics: 1; SN6PR12MB2688; 3:oQgQxx4fOWl6SDH+UrVo2TrNwvymMNTEqCPQyQgl57S2Rw4ZMQniMlDsGlf4fLYk5MTm2ZErVKSZOJBHVHOKiNL0siM79TEXR2SHaCqws6/dIPvS9IRVw4m/SLVlePndKg1/urFO0Q9FWxS9uY9l4Dehz9K4A4Vyc9QyLHkWLygt0YXJTI4iGRr6oxSeuG2M0w/i9tIFDmR629p6Ifa0/GsgaTEOn+ZGUyqf4+qacYvw9ron5vCFSoBHwL7aiSQj; 25:ThadWgbYNMRt0lmqCYywRhHdZxJW27gD//2C7EXjebXzBwvv3UNbsv5B0zCRgSIzgirPPPSYe/MrazSmkh/ypStL5l9Gd7MYnRUpM3evhaEbGyP7SBVuifbJyLDqSdxere00WKE009/7g6irmgAWmyLtZpgDOGJLnSw8A1fMqf9lauqL1vYo1bT9gJfW+wpWLfoFmAKZQwX7SBsPyHrKP5bzTaKOHqoHEKo7FqWgBZfXaenU4TK6r4yuVxCibLv9OH74w/DD+vTWFApyhWBA35RG3SzfQWKOMRMcuO2iwL9jZpTY4XOm8hghuzV9L8jb0gOBTYL/b2DiSZIvGLa6WA==; 31:EApXQ6yGI7KKzZ7PZ1igrujmsTLoj40r3zdthzn2tAIoBS8KJvVSCVdWxhTy6sc+xZbBRfkaks28vMiGp3WI6oW9Mv59yasJdHnvqUr4qKlUQASOn78DzK5tqaBs60e/szOyLrME348iTax2EUDAiHvjeU1O0lt2UYtp2L1qPuIhedIfysojksgfA4wvuQySANwcIXkvsxK+mKm8ayXT7C/jiD35yAQBFHK0NXvD+7Y= X-MS-TrafficTypeDiagnostic: SN6PR12MB2688: X-Microsoft-Exchange-Diagnostics: 1; SN6PR12MB2688; 20:KlU1g63eLI/wD9FhGMnDRfbb/wqAkyhzFvtWMuJ3U/wYQTtI3d8ermmOD9/Euq0jO0itDhHZj996u1bWSapxOzUkCM8hS9Fh16k5j4ko5aJQaqnArgb1YXmMO9EJMlg9QMa/LHL9ItUB4KWaCzCjjqagRL5GUYu4g/Rh5qXirvRhSpMIH5c5wJeVhtix4UjFLX20uckj90kmjCkg9Ydxjcq/UaAW6tubtc1+jk5+l/trwwqsEq123hF0wpLYWygH/+eJeRX+tTmz+PQNyyicr7RDRPYkQDnmK+x2671vuu626JpFKLDhwLON7N0fbZYqZ1JjEh5TOERZC7e/CfOx2fZ2MnE4u7n47LXjyOGl/BKMWslIUW1uAVgX6XL0CrbApmechA/kKqnYuN8Q9Bpvl6a4AN5LtH7Da8MNb320hl76bQIwbSreoZhEPGy/qj1sOGUGojYFmfHfkUtgKTF4q4+yzO9xI4SHhWgdXI4xcJEqHsa+SVpMjG7DBL8Jk4rh; 4:53e4EhUh7uoTHy6vJJfgdWDRYu3znyM3naAkIe4DQ7nDAq6ti52rND33GSjaX8giKJ5ukZS4qgfWv2Kh5aKl2ezR22hNoa+Ag4NVLzRkr4A+NcsWo5Q8YcI/skNyqqJ0lIVXEMJWVUkoqusc99GIj0qMNaGuiOQ89xXq2d9xgP8CPUjNlcocrrtgxL0XIu5aapLeUE36ee14GGVKr/ahCauvQIGat5R/jNqMIbBjrSUkuFMP++YBLuPxNxIzrxdGjYvAPur5GQG+rqZTOvIrEDLEmJeM9NRtnARV7jSbkWPCAegdhfL94OHnbUdDQfmsLPFbBy/TvbLeSzxH8+/hMlY8YuFMAgTDyfUtRhoy990= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(85827821059158)(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(201708071742011)(7699050); SRVR:SN6PR12MB2688; BCL:0; PCL:0; RULEID:; SRVR:SN6PR12MB2688; X-Forefront-PRVS: 0792DBEAD0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(366004)(136003)(376002)(39860400002)(396003)(189003)(199004)(2616005)(386003)(3846002)(97736004)(7736002)(48376002)(11346002)(316002)(305945005)(53416004)(6116002)(50466002)(476003)(2351001)(478600001)(486006)(39060400002)(956004)(7696005)(76176011)(4326008)(51416003)(6666003)(36756003)(6486002)(6916009)(106356001)(8676002)(68736007)(186003)(44832011)(2361001)(105586002)(52116002)(5660300001)(25786009)(81166006)(81156014)(2906002)(446003)(53936002)(47776003)(66066001)(54906003)(26005)(50226002)(8936002)(16586007)(16526019)(86362001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR12MB2688; H:sbrijesh-desktop.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR12MB2688; 23:iQWY15mdkH4p57RoQlVmMvllfX5vElpzl/13JpeSu?= =?us-ascii?Q?GyGqdojnXhWfpCuxA9QWqW+FdonvvYqhX7GU7dnpJhT8t7kTkUVI10exQdrz?= =?us-ascii?Q?7F1GvGL9COGDp6xaOuxxXsliT1AvCJcPoh/NHFVJbkL0gXEtM+umGDQPpmsR?= =?us-ascii?Q?zR3TfgjbDqa0vylkJcbw5O23xTg9oOA0Kxis4kBaEF0228BZ8+Re94/BpOSa?= =?us-ascii?Q?OP/0H9vfpcKpa7eD7AzVLpIMaIR7lDp0h9ExMZkquVmJUHU5S3HWAGUZJa8n?= =?us-ascii?Q?/Ib51md3OhMK9cOghdB2eMxMeV3DxoIGesjD7zWWiWVG9439KVbXve9ZJxu+?= =?us-ascii?Q?2Z+eigXMvYtolcIG1Ejd77KUS7/SrCM0Dvj4RphWIZD11NfI33DgbSnsbFF1?= =?us-ascii?Q?2493LF1IhCca/hJBy+fxS+CUYZ8HaW0zc4mqw5zfrR8HzdX4xZe2nMQomCvo?= =?us-ascii?Q?x70oSVVur39lCpmL6xo2NrmGuOaJnnwdzqhkbyL7U/u5SQXyAvtMm44qxSp+?= =?us-ascii?Q?HXpWgbqp6V/bvq85PBVt8KcJMAn3S/KOQ/HewYotwr41By78oUGG7EMc01Sx?= =?us-ascii?Q?QB1t3V8ysF5+WWHXeZ8VfWEymD1JUT2yIisdduDz7fSpF/GXlZ/zaOdgkKMg?= =?us-ascii?Q?DoOSnoIBOWWqevmx/h83XLM3YBsZWJSJpOgsyG4O5fceUOCF9+niSo3S7g8Z?= =?us-ascii?Q?0v5ax8XD3OhM4r+PhUQigbVJ0aK4sC0TVL4MsOu/Pd7IXK9ygGabNc08BIJM?= =?us-ascii?Q?5AiA75M7FzBOBeMKxn6vJQPj8cy1IoA9y9UAm+C9aKbHhdu3lLIRJq4IeZI2?= =?us-ascii?Q?4hYVwbZg7+J+KgLvSgo+Z/YI2Nni9YcA7S8Tzkzs0LLdM/sbTe9r7BWx2B+4?= =?us-ascii?Q?nZM0Wh5pfJL74LKN8nm5QzxCbbOtZHq+NJMApak8/Oy8RRU2itIw6XVV6u3T?= =?us-ascii?Q?j/tIBRPD9aaJRZh0mbEoiBSpSuuOrYf0z+gjVPWaVpPeUvkrIIkqwYnO96HZ?= =?us-ascii?Q?S2K7EuXS0ecVOt0vM1SH8vBhdQ331ksaHb1JI6uoOQng51F1CDONdBlmbqyf?= =?us-ascii?Q?5FzsfpKmPKqmuWpCNzEUfqUegM4x7Nb2qf6yVdKEzCyN4/o231T9LM141o5m?= =?us-ascii?Q?LMTp8k/kJsLd1lYZAS0IXKtS3ibwhwEXNkp2mf6i22l0mqiG95jySH47Tudt?= =?us-ascii?Q?rNvLCI2smP54SWXdumzDebnE3DjbDfK4gVnTiuYDeGaePsMvxk/GVbMxyxLy?= =?us-ascii?Q?EMM1+XU3LAgM8x+EPj8SUg1LZCnA4rK5zvesb5U?= X-Microsoft-Antispam-Message-Info: xeSzRMCCZXrAZlQ2lhnunPvn/Wfn07KRa4pCYGcwYBlUKD3FSa7oIumI+QiEk8wD4SpWfYdpIpwCakL7/xuNm3IELtaFewXHCn4v+sIjMak06o1ALrknWKuDkmMoBAXNimEJ0aol9tOiGVNlHlyCLXga8Y+8DB2ktBDk+iU+i0ip9G/vt4u1Wupee9sytjbET0xZVkbJSxv6g2hb07sKPUQqnGrS2Qoh8GBDZo41MG7YJRpEBQUnl/BpVt3XFM5P3WGblmqD5p2WqCC/NzNx9y8NnMtliPt37meJQCaWmGQCfs0e+d97vY5UvO4qxEX0dZNJkfDFfkFqxVWE+zeZHJVKDfxmgm+uwB9Lshy3Hmg= X-Microsoft-Exchange-Diagnostics: 1; SN6PR12MB2688; 6:YnrNmJKBQI8cR3cm/Nq7M9VXeWh8qume3N8wGqki5MwDudPkG2+a1c4xA1LrOcuuZNFRWNb5mkTH78ldl7EO5PUiJr0V9pdv0+cUPyq2eGZKUbeooW63TNU8LS+CjtNy4ST8zguXAiB85QVAzarvLWL0x8VGnKnNzIfNz+hlZUWywQbIW7rAkzbVIK7Vvo3c7ZEXodrs2cdb8t1kP+QktU+6pHa3Kc3oEcoNviRIy2QxCvlkLfIRz9/LkuPgU0UsM+Nc+uPh6AoC6PcI3YgGZhOzqfiw4VPdNP2huYIm5babNegtISm/a4A1mE7b+whXThOe92VMXVeiYCQ+9xeB221pI0n5USoA/fbjQnO+dbn+/y2p0IBHHwliqfNZujLJqnfUi+95/5FM7Ayg8PuXY6t7tXrPFFvTxqWMFO/xld806tBy4jz1s/BbAFeHg3hFlDDLDUc5FlZWDS0+vj0reg==; 5:N0O01RpAKWpXuOcvPgt4kgWPcg/bfaLq+3W+AMdUe8LYFBwEjHMJd/btI2dMDXaV71j89xBDhO+f/1NUOoA/eIHvvqitAr0kaaVf6uIlXA9JFvR/p9dI0Tje6vW2o2hMMY42DpeJ1kytZ0vyFc8UYsYUeJ13UtMuNFZQa+8ZO5Q=; 7:JYTqx5ymjmxyEnHwIMKCJDSWziUbznvxdHIn648Cu8EiKP9oM8VFlmUNHBAVI4oLGvzspDVH8tv+LI/3llivfU1NUYnxsdBm8AXXqqyYF+LP2RonGWn6BlRTFKdlqso9Nzq7NuvhHh1/V7PoNlOheBeQy2c3ZHh4SvFkydB5duyGN0fW2TaqsRupXE5NkaB2/zHn/KcZD0uB0Skpl/33oNGSdxC7AOtx9LevzyoqzI1WrxnJbCGvX5RRABYB2tnx SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN6PR12MB2688; 20:remfyrKwmZKiLAcdRjjcqfb0HoyuQo6yfWmvoemKueMX9dH6vFK6DQzmAlAHZZgPQz7zOTu5nhTL4YhEMH4InvTEMeS52dHxv0VG6OTNbj3uzEnHXlU7swY9UCOfxRXhQ9Sj4ufYrj+DtC4EqEoZLhZqb3ThkgCr7OAc+yl5MkEl3P+cEdj6pdFU7UKfBIVAZaDVRXTpCnU0gnlhwr5HyjYhuzqOzJy3itrIi1/PaQ1iN+zFEUG67CikqN64aGEF X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2018 16:50:05.0856 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d67504ff-549c-4632-a5d2-08d61806a05e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2688 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.73.79 Subject: [Qemu-devel] [PATCH 1/6] x86_iommu: move the kernel-irqchip check in common code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Lendacky , Brijesh Singh , Eduardo Habkost , "Michael S. Tsirkin" , Paolo Bonzini , Suravee Suthikulpanit , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Interrupt remapping needs kernel-irqchip=3D{off|split} on both Intel and AMD platforms. Move the check in common place. Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Tom Lendacky Cc: Suravee Suthikulpanit Signed-off-by: Brijesh Singh Reviewed-by: Peter Xu --- hw/i386/intel_iommu.c | 7 ------- hw/i386/x86-iommu.c | 9 +++++++++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 3dfada1..84dbc20 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -3248,13 +3248,6 @@ static bool vtd_decide_config(IntelIOMMUState *s, Er= ror **errp) { X86IOMMUState *x86_iommu =3D X86_IOMMU_DEVICE(s); =20 - /* Currently Intel IOMMU IR only support "kernel-irqchip=3D{off|split}= " */ - if (x86_iommu->intr_supported && kvm_irqchip_in_kernel() && - !kvm_irqchip_is_split()) { - error_setg(errp, "Intel Interrupt Remapping cannot work with " - "kernel-irqchip=3Don, please use 'split|off'."); - return false; - } if (s->intr_eim =3D=3D ON_OFF_AUTO_ON && !x86_iommu->intr_supported) { error_setg(errp, "eim=3Don cannot be selected without intremap=3Do= n"); return false; diff --git a/hw/i386/x86-iommu.c b/hw/i386/x86-iommu.c index 8a01a2d..7440cb8 100644 --- a/hw/i386/x86-iommu.c +++ b/hw/i386/x86-iommu.c @@ -25,6 +25,7 @@ #include "qapi/error.h" #include "qemu/error-report.h" #include "trace.h" +#include "sysemu/kvm.h" =20 void x86_iommu_iec_register_notifier(X86IOMMUState *iommu, iec_notify_fn fn, void *data) @@ -94,6 +95,14 @@ static void x86_iommu_realize(DeviceState *dev, Error **= errp) return; } =20 + /* Both Intel and AMD IOMMU IR only support "kernel-irqchip=3D{off|spl= it}" */ + if (x86_iommu->intr_supported && kvm_irqchip_in_kernel() && + !kvm_irqchip_is_split()) { + error_setg(errp, "Interrupt Remapping cannot work with " + "kernel-irqchip=3Don, please use 'split|off'."); + return; + } + if (x86_class->realize) { x86_class->realize(dev, errp); } --=20 2.7.4