From nobody Wed Nov 5 14:27:34 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534873724570579.3464367996447; Tue, 21 Aug 2018 10:48:44 -0700 (PDT) Received: from localhost ([::1]:55178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsAln-0005Gg-Af for importer@patchew.org; Tue, 21 Aug 2018 13:48:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsA4x-0002SG-Qw for qemu-devel@nongnu.org; Tue, 21 Aug 2018 13:04:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsA4o-0007E1-Tx for qemu-devel@nongnu.org; Tue, 21 Aug 2018 13:04:24 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:38393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fsA4o-0006zU-Em for qemu-devel@nongnu.org; Tue, 21 Aug 2018 13:04:18 -0400 Received: by mail-wr1-x444.google.com with SMTP id w11-v6so13897338wrc.5 for ; Tue, 21 Aug 2018 10:04:08 -0700 (PDT) Received: from 640k.lan (dynamic-adsl-78-12-184-244.clienti.tiscali.it. [78.12.184.244]) by smtp.gmail.com with ESMTPSA id v6-v6sm2608955wmc.43.2018.08.21.10.04.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Aug 2018 10:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=1FRgPzWy4ds2yZ7Kw2gQ3EQJcDK8h2j4CzxfhIZ+GBI=; b=PZN0KTLY5VaxC9XbZwtV3ylNnanA3BzwteiXYWVWfDxHkL57RQBhJ6PcNqlCRNUXN1 yjiUVmX7Cx3aEsZrHLiwvr1xHdyCSONmQiBhdm6zqIW2iqnvIMw605i7ZL7rEuq9KP4C EuR9MPGTt2mU/DNEXUAwNEO1esw20pwb9wQLpfztZgJOevGxnEapgsHJOIJ0bkLQCgau on0/YyeFt4Y4yviDSfH0YI76DuDUhn92M3hu/n4od/HyQG8daXJDjtkL4xvRtyu47g0O 87ti87hjEpS/ZW8RoztlkOpAXy/40mIuR/qK5jxbz6bsVs7+I2c1IrgGcjlzxBso4zaz ZHDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=1FRgPzWy4ds2yZ7Kw2gQ3EQJcDK8h2j4CzxfhIZ+GBI=; b=SGO84vEK5SrzwIBcNXISIwXigon8SSL4GIC4VXInTfNj5ZQ/fAvXfS4AXTnD6rW7US VDuYxGgzR6VY7jTP6RK2855zj7tEoZAE4/sA08NIRCsHTd0zriZ/kHcn+GjsH6crYGzB rQ/L3kDYf1cKszUc768NHaKy2FbVVcrXnIQeYgSk5JdXumwuetpO6jl/KvxVYn46I1y8 u6wewHmO2F9ZC7z4oFknfCMwzDFErYgMpVhWc1jY2Evc2XR67uSrU8lcO/NIzvISbalT SVHYGnCIPYVoey8Bw1xlEezUF0EkBQ5xO9y0R0JQY4i8O7uCRUaUeLDguOFX8qBSqgpS vO7g== X-Gm-Message-State: AOUpUlFGBLgTzKygAVmaWZc9y4aC/CcybR+DXfFp3ir5calLoka/Y0oj dbQjIlrfKbDO6RxeBv1nw+o3bTmn X-Google-Smtp-Source: AA+uWPx+DQkO1KnxADbD+niIUV3/2kXDxOpcRh6fm+vTWjQSyI1BNP/Ez4OPGRqu55bh+hWZW+XC7A== X-Received: by 2002:a5d:6550:: with SMTP id z16-v6mr31400958wrv.194.1534871046971; Tue, 21 Aug 2018 10:04:06 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 21 Aug 2018 19:02:32 +0200 Message-Id: <1534870966-9287-61-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1534870966-9287-1-git-send-email-pbonzini@redhat.com> References: <1534870966-9287-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PULL 60/74] pc: drop memory region alignment check for 0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: David Hildenbrand All applicable memory regions always have an alignment > 0. All memory backends result in file_ram_alloc() or qemu_anon_ram_alloc() getting called, setting the alignment to > 0. So a PCDIMM memory region always has an alignment > 0. NVDIMM copy the alignment of the original memory memory region into the handcrafted memory region that will be used at this place. So the check for 0 can be dropped and we can reduce the special handling. Dropping this check makes factoring out of alignment handling easier as compat handling only has to look at pcmc->enforce_aligned_dimm and not care about the alignment of the memory region. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand Message-Id: <20180801133444.11269-4-david@redhat.com> Signed-off-by: Paolo Bonzini --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 96be77f..b31610c 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1713,7 +1713,7 @@ static void pc_memory_plug(HotplugHandler *hotplug_de= v, uint64_t align =3D TARGET_PAGE_SIZE; bool is_nvdimm =3D object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM); =20 - if (memory_region_get_alignment(mr) && pcmc->enforce_aligned_dimm) { + if (pcmc->enforce_aligned_dimm) { align =3D memory_region_get_alignment(mr); } =20 --=20 1.8.3.1