From nobody Wed Nov 5 14:37:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534872071085319.99592394664444; Tue, 21 Aug 2018 10:21:11 -0700 (PDT) Received: from localhost ([::1]:55029 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsAL1-0002ie-R2 for importer@patchew.org; Tue, 21 Aug 2018 13:21:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fsA4S-0001kk-0Y for qemu-devel@nongnu.org; Tue, 21 Aug 2018 13:03:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fsA4I-0006TX-OI for qemu-devel@nongnu.org; Tue, 21 Aug 2018 13:03:53 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:38389) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fsA49-00068m-4K for qemu-devel@nongnu.org; Tue, 21 Aug 2018 13:03:39 -0400 Received: by mail-wr1-x443.google.com with SMTP id w11-v6so13895971wrc.5 for ; Tue, 21 Aug 2018 10:03:33 -0700 (PDT) Received: from 640k.lan (dynamic-adsl-78-12-184-244.clienti.tiscali.it. [78.12.184.244]) by smtp.gmail.com with ESMTPSA id v6-v6sm2608955wmc.43.2018.08.21.10.03.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Aug 2018 10:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=VFm0OnaoNsKOMdgsTLDJ3UPza1uBfxIubwpfyVLYcCE=; b=VNviuyd0hi9FaT6mPa6eadt9YCNdF45XwArFFcJxbWHZ/yDnNaQ9HzWoAkptMF79DD X5lTXqRaFI51/qYdLk0nloeO8RLpYGTGXC9KJpGcVi5ozO97qVHHYdXgi+wQsP0O80/6 Wva0uZnNPgCqZ4a+ixMSj4QPynQpx40esSp5Xp3EirXlTOMGe1UyU4HwV+O9/h50CStw CqZfps4wSOJa4HzQNZ6V0fr3Zys3e5lQy6OmwGSmHj3NElrtrDc6/JG1DvY8rOEYq/SB T30Sd2Gzw5SjJZlP7MwCfbEXuTGrlEpT9J8rIhXWDLRLqRzk66OfNpMsEW2yRmLi99CK ufjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=VFm0OnaoNsKOMdgsTLDJ3UPza1uBfxIubwpfyVLYcCE=; b=TEfWFtxb0qSPC+uzEVLrLOb2ZX9kL3WnEFjCXGkGnUV1qsCPox6kv6EEwp3bwgqImY fClf8u4PUmfW6HoLuWGIyI4eEeEssTcIiwo8W+aweEVYvNlW0JU183jec/CaV8HWCmVP zE8e3IXWcaRo1w94PHrIWPVJMSNWaPuQxtLkZgCI0VauWQpvdOBRjrE585HikQgWnYoY +MN4Wktmr/uu9Gfi6voSyXXMAmqCBxnTydMf3bj/DEyAreqawThqrfolOixS9IKp/6Uu 7zr7Lww2tM8WUFNMKgFUUq8c/PtTofnrb1MFqfEsuWxWT2hxdIlvTaG7C9KU6LRkyy8m fyEQ== X-Gm-Message-State: APzg51CDaxz5i9pYgG4fT0mKAz9flp6E9KSwUJVoqPAU4prKBierXkwg 6i6CCRV1rLV2Q6ZZ2rs5rLON1H2L X-Google-Smtp-Source: ANB0VdY7WnFlDiGoIg//sKIZUzAPmr9JkSzENEsVPa+vq7pMbu6nQx2TLyupsUw+gIstx9fTBzj+0A== X-Received: by 2002:a5d:488c:: with SMTP id g12-v6mr4752504wrq.0.1534871012141; Tue, 21 Aug 2018 10:03:32 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 21 Aug 2018 19:01:59 +0200 Message-Id: <1534870966-9287-28-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1534870966-9287-1-git-send-email-pbonzini@redhat.com> References: <1534870966-9287-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PULL 27/74] checkpatch: allow space in more places before a bracket X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heinrich Schuchardt , Andrew Morton , Linus Torvalds Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDMRC_1 RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Heinrich Schuchardt Allow a space between a colon and subsequent opening bracket. This sequence may occur in inline assembler statements like asm( "ldr %[out], [%[in]]\n\t" : [out] "=3Dr" (ret) : [in] "r" (addr) ); Allow a space between a comma and subsequent opening bracket. This sequence may occur in designated initializers. To ease backporting the patch, I am also changing the comma-bracket detection (added in QEMU by commit 409db6eb7199af7a2f09f746bd1b793e9daefe5f) to use the same regex as brackets and colons (as done independently by Linux commit daebc534ac15f991961a5bb433e515988220e9bf). Link: http://lkml.kernel.org/r/20180403191655.23700-1-xypron.glpk@gmx.de Signed-off-by: Heinrich Schuchardt Acked-by: Joe Perches Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Reviewed-by: Markus Armbruster Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 0553634..3765b0e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1929,9 +1929,8 @@ sub process { my ($where, $prefix) =3D ($-[1], $1); if ($prefix !~ /$Type\s+$/ && ($where !=3D 0 || $prefix !~ /^.\s+$/) && - $prefix !~ /{\s+$/ && $prefix !~ /\#\s*define[^(]*\([^)]*\)\s+$/ && - $prefix !~ /,\s+$/) { + $prefix !~ /[,{:]\s+$/) { ERROR("space prohibited before open square bracket '['\n" . $herecurr); } } --=20 1.8.3.1