From nobody Wed Nov 5 14:21:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1534797014626900.8154915480317; Mon, 20 Aug 2018 13:30:14 -0700 (PDT) Received: from localhost ([::1]:49147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frqoX-00059c-CV for importer@patchew.org; Mon, 20 Aug 2018 16:30:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frqlC-0002pX-Uk for qemu-devel@nongnu.org; Mon, 20 Aug 2018 16:26:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frql0-0002SA-FW for qemu-devel@nongnu.org; Mon, 20 Aug 2018 16:26:45 -0400 Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]:46700) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frqkw-0002HZ-Ji for qemu-devel@nongnu.org; Mon, 20 Aug 2018 16:26:30 -0400 Received: by mail-oi0-x22f.google.com with SMTP id y207-v6so28125416oie.13 for ; Mon, 20 Aug 2018 13:26:28 -0700 (PDT) Received: from serve.minyard.net ([47.184.170.128]) by smtp.gmail.com with ESMTPSA id s142-v6sm8961497oie.48.2018.08.20.13.26.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Aug 2018 13:26:25 -0700 (PDT) Received: from t430.minyard.net (unknown [IPv6:2001:470:b8f6:1b:7d98:76b7:e7fd:495f]) by serve.minyard.net (Postfix) with ESMTPA id E95DEE1D; Mon, 20 Aug 2018 15:26:23 -0500 (CDT) Received: by t430.minyard.net (Postfix, from userid 1000) id 24A913000F4; Mon, 20 Aug 2018 15:26:20 -0500 (CDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=it1qCBrNdyxUz/mt2nkaTHsGcqJGU1Y02vsMXZeZ/iU=; b=oEQzAVh/xjA4AKNo3Xs6cJeOIdtxdNOieopE3DnG3VN+WgkH0iMTn3cH1tDCbeFJq7 bMqVZ2XyCEk4ha5zTdw46NoCma0/2Xxli9IVzPRoN4ZgkBpROAcqqOEzliwDKWJdwX1p wM6AOgEaLKek5JRsVaTfLCctnhl+Px+fgNmTaawETIdMmPCwo58KNojEcEeDFR1cdkcC Q+iY1kZZzO5Ndb1/oD4L+uT3145z/gkkJ1DQmSWZ6lSGGpR/ttqnNhJWoXRkH1e0z2U3 Hpx0fOBvBOFoQAd7dSac+y26ClV0YvfuViW/P3CRBQpgwoTES0BGBnCH7jEpVG/G3BHQ dPLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=it1qCBrNdyxUz/mt2nkaTHsGcqJGU1Y02vsMXZeZ/iU=; b=VL271HeXWCeg/8Pr8mPzkY+ktvLqzk2xJ0GKltmuyZfV1xXxTBDYZ80PGTtUapI4lB v1TYJqhSy4QRPhvv09+oOcQVmSewhQRVNkGqolIHRs8CI64wJy0CZ4o5cqh7XrfehAmL 7PF8MQaBeCGXgWLAmk6JUkiO8rpWScdp2ikmk62+6kPKW666BhXrKEvBtpdEP0XL37ly ojWoqZR4zzajlGnAl6hEq/Dl36gS9Di5GSAtXMrATUpPYmVilITRZ2kEWBr1WdtNfF0X ydhQWzqPQJOxuRYZxO5CDq87FhYWv4CEVqoEFx+cmvnZ5at5L6SJuSJEpyAbt72B2Veo dJZg== X-Gm-Message-State: AOUpUlG9hlIcDsrcn9V8TNh8O1f2xFawr4swB8qNPw5okHXH/EeOZMj3 lvwix61bB42U/N0ZsBAjxw== X-Google-Smtp-Source: AA+uWPz9nwJzrM8OYUAGWUWWCHcToydZTah2/5ZTjsxelL1t3kATAJuEk3/g7/e/Av72UzC7HuJjQA== X-Received: by 2002:aca:3a57:: with SMTP id h84-v6mr15446977oia.336.1534796788246; Mon, 20 Aug 2018 13:26:28 -0700 (PDT) From: minyard@acm.org To: Paolo Bonzini , qemu-devel@nongnu.org Date: Mon, 20 Aug 2018 15:26:01 -0500 Message-Id: <1534796770-10295-2-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1534796770-10295-1-git-send-email-minyard@acm.org> References: <1534796770-10295-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22f Subject: [Qemu-devel] [PATCH v2 01/10] i2c:pm_smbus: Clean up some style issues X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Corey Minyard Fix some spacing issues, remove extraneous comments, add some defines instead of hard-coding numbers. Signed-off-by: Corey Minyard Cc: Michael S. Tsirkin Cc: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i2c/pm_smbus.c | 58 ++++++++++++++++++++++++++++++++++++---------------= ---- 1 file changed, 38 insertions(+), 20 deletions(-) diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c index 0d26e0f..83c2377 100644 --- a/hw/i2c/pm_smbus.c +++ b/hw/i2c/pm_smbus.c @@ -22,8 +22,6 @@ #include "hw/i2c/pm_smbus.h" #include "hw/i2c/smbus.h" =20 -/* no save/load? */ - #define SMBHSTSTS 0x00 #define SMBHSTCNT 0x02 #define SMBHSTCMD 0x03 @@ -32,19 +30,34 @@ #define SMBHSTDAT1 0x06 #define SMBBLKDAT 0x07 =20 -#define STS_HOST_BUSY (1) -#define STS_INTR (1<<1) -#define STS_DEV_ERR (1<<2) -#define STS_BUS_ERR (1<<3) -#define STS_FAILED (1<<4) -#define STS_SMBALERT (1<<5) -#define STS_INUSE_STS (1<<6) -#define STS_BYTE_DONE (1<<7) +#define STS_HOST_BUSY (1 << 0) +#define STS_INTR (1 << 1) +#define STS_DEV_ERR (1 << 2) +#define STS_BUS_ERR (1 << 3) +#define STS_FAILED (1 << 4) +#define STS_SMBALERT (1 << 5) +#define STS_INUSE_STS (1 << 6) +#define STS_BYTE_DONE (1 << 7) /* Signs of successfully transaction end : * ByteDoneStatus =3D 1 (STS_BYTE_DONE) and INTR =3D 1 (STS_INTR ) */ =20 -//#define DEBUG +#define CTL_INTREN (1 << 0) +#define CTL_KILL (1 << 1) +#define CTL_LAST_BYTE (1 << 5) +#define CTL_START (1 << 6) +#define CTL_PEC_EN (1 << 7) +#define CTL_RETURN_MASK 0x1f + +#define PROT_QUICK 0 +#define PROT_BYTE 1 +#define PROT_BYTE_DATA 2 +#define PROT_WORD_DATA 3 +#define PROT_PROC_CALL 4 +#define PROT_BLOCK_DATA 5 +#define PROT_I2C_BLOCK_DATA 6 + +/*#define DEBUG*/ =20 #ifdef DEBUG # define SMBUS_DPRINTF(format, ...) printf(format, ## __VA_ARGS__) @@ -70,11 +83,12 @@ static void smb_transaction(PMSMBus *s) if ((s->smb_stat & STS_DEV_ERR) !=3D 0) { goto error; } + switch(prot) { - case 0x0: + case PROT_QUICK: ret =3D smbus_quick_command(bus, addr, read); goto done; - case 0x1: + case PROT_BYTE: if (read) { ret =3D smbus_receive_byte(bus, addr); goto data8; @@ -82,7 +96,7 @@ static void smb_transaction(PMSMBus *s) ret =3D smbus_send_byte(bus, addr, cmd); goto done; } - case 0x2: + case PROT_BYTE_DATA: if (read) { ret =3D smbus_read_byte(bus, addr, cmd); goto data8; @@ -91,16 +105,17 @@ static void smb_transaction(PMSMBus *s) goto done; } break; - case 0x3: + case PROT_WORD_DATA: if (read) { ret =3D smbus_read_word(bus, addr, cmd); goto data16; } else { - ret =3D smbus_write_word(bus, addr, cmd, (s->smb_data1 << 8) |= s->smb_data0); + ret =3D smbus_write_word(bus, addr, cmd, + (s->smb_data1 << 8) | s->smb_data0); goto done; } break; - case 0x5: + case PROT_I2C_BLOCK_DATA: if (read) { ret =3D smbus_read_block(bus, addr, cmd, s->smb_data); goto data8; @@ -158,8 +173,9 @@ static void smb_ioport_writeb(void *opaque, hwaddr addr= , uint64_t val, break; case SMBHSTCNT: s->smb_ctl =3D val; - if (val & 0x40) + if (s->smb_ctl & CTL_START) { smb_transaction_start(s); + } break; case SMBHSTCMD: s->smb_cmd =3D val; @@ -198,7 +214,7 @@ static uint64_t smb_ioport_readb(void *opaque, hwaddr a= ddr, unsigned width) break; case SMBHSTCNT: s->smb_index =3D 0; - val =3D s->smb_ctl & 0x1f; + val =3D s->smb_ctl & CTL_RETURN_MASK; break; case SMBHSTCMD: val =3D s->smb_cmd; @@ -221,7 +237,9 @@ static uint64_t smb_ioport_readb(void *opaque, hwaddr a= ddr, unsigned width) val =3D 0; break; } - SMBUS_DPRINTF("SMB readb port=3D0x%04" HWADDR_PRIx " val=3D0x%02x\n", = addr, val); + SMBUS_DPRINTF("SMB readb port=3D0x%04" HWADDR_PRIx " val=3D0x%02x\n", + addr, val); + return val; } =20 --=20 2.7.4