From nobody Tue Nov 4 23:50:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linux.ibm.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1531779291338132.9925560336751; Mon, 16 Jul 2018 15:14:51 -0700 (PDT) Received: from localhost ([::1]:54233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffBlN-0000Ha-43 for importer@patchew.org; Mon, 16 Jul 2018 18:14:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ff8mJ-0002Ln-Eu for qemu-devel@nongnu.org; Mon, 16 Jul 2018 15:03:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ff8mG-0004xb-BU for qemu-devel@nongnu.org; Mon, 16 Jul 2018 15:03:23 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:46356 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ff8mG-0004x0-6J for qemu-devel@nongnu.org; Mon, 16 Jul 2018 15:03:20 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6GIruua017442 for ; Mon, 16 Jul 2018 15:03:18 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0b-001b2d01.pphosted.com with ESMTP id 2k8xemerbm-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 16 Jul 2018 15:03:18 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Jul 2018 15:03:17 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 16 Jul 2018 15:03:13 -0400 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6GJ3CbY10551906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 16 Jul 2018 19:03:13 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 98EA4112064; Mon, 16 Jul 2018 15:03:01 -0400 (EDT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 38D96112063; Mon, 16 Jul 2018 15:03:01 -0400 (EDT) Received: from yasmins-centos-7-ppc64le.aus.stglabs.ibm.com (unknown [9.40.192.146]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 16 Jul 2018 15:03:01 -0400 (EDT) From: Yasmin Beatriz To: qemu-ppc@nongnu.org Date: Mon, 16 Jul 2018 19:03:12 +0000 X-Mailer: git-send-email 1.8.3.1 X-TM-AS-GCONF: 00 x-cbid: 18071619-0040-0000-0000-0000044FA4FA X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009375; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01061749; UDB=6.00545107; IPR=6.00839654; MB=3.00022160; MTD=3.00000008; XFM=3.00000015; UTC=2018-07-16 19:03:15 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18071619-0041-0000-0000-00000855CED3 Message-Id: <1531767792-17705-1-git-send-email-yasmins@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-07-16_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=888 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807160214 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 X-Mailman-Approved-At: Mon, 16 Jul 2018 18:13:27 -0400 Subject: [Qemu-devel] [PATCH] target/ppc: bcdsub fix sign when result is zero X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rth@twiddle.net, qemu-devel@nongnu.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When the result of bcdsub is equal to zero, the result sign may be set to negative in some cases, and this does not follow the Power ISA specifications as to decimal integer arithmetic instructions. Signed-off-by: Yasmin Beatriz --- target/ppc/int_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c index 03d37da..fa18e6e 100644 --- a/target/ppc/int_helper.c +++ b/target/ppc/int_helper.c @@ -2747,6 +2747,9 @@ uint32_t helper_bcdadd(ppc_avr_t *r, ppc_avr_t *a, p= pc_avr_t *b, uint32_t ps) result.u8[BCD_DIG_BYTE(0)] =3D bcd_preferred_sgn(sgna, ps); zero =3D bcd_sub_mag(&result, a, b, &invalid, &overflow); cr =3D (sgna > 0) ? CRF_GT : CRF_LT; + } else if (bcd_cmp_mag(a, b) =3D=3D 0) { + result.u8[BCD_DIG_BYTE(0)] =3D bcd_preferred_sgn(0, ps); + zero =3D bcd_sub_mag(&result, b, a, &invalid, &overflow); } else { result.u8[BCD_DIG_BYTE(0)] =3D bcd_preferred_sgn(sgnb, ps); zero =3D bcd_sub_mag(&result, b, a, &invalid, &overflow); --=20 1.8.3.1