From nobody Tue Nov 4 21:57:32 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530715792657672.6191654606664; Wed, 4 Jul 2018 07:49:52 -0700 (PDT) Received: from localhost ([::1]:47566 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faj6N-0003CW-Vk for importer@patchew.org; Wed, 04 Jul 2018 10:49:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1faj3U-0001UH-4K for qemu-devel@nongnu.org; Wed, 04 Jul 2018 10:46:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1faj3T-0007jl-9m for qemu-devel@nongnu.org; Wed, 04 Jul 2018 10:46:52 -0400 Received: from mx1.mpynet.fi ([82.197.21.84]:61747) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1faj3P-0007gm-GE; Wed, 04 Jul 2018 10:46:47 -0400 From: Ari Sundholm To: Date: Wed, 4 Jul 2018 17:46:35 +0300 Message-ID: <1530715597-30975-2-git-send-email-ari@tuxera.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1530715597-30975-1-git-send-email-ari@tuxera.com> References: <1530715597-30975-1-git-send-email-ari@tuxera.com> MIME-Version: 1.0 X-ClientProxiedBy: tuxera-exch.ad.tuxera.com (10.20.48.11) To tuxera-exch.ad.tuxera.com (10.20.48.11) Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 82.197.21.84 Subject: [Qemu-devel] [PATCH 1/3] block/blklogwrites: Change log_sector_size from int64_t to uint64_t X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "open list:blklogwrites" , Ari Sundholm , Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This was a simple oversight when working on intermediate versions of the original patch which introduced blklogwrites. Signed-off-by: Ari Sundholm --- block/blklogwrites.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/block/blklogwrites.c b/block/blklogwrites.c index 47093fa..272e11a 100644 --- a/block/blklogwrites.c +++ b/block/blklogwrites.c @@ -79,7 +79,7 @@ static int blk_log_writes_open(BlockDriverState *bs, QDic= t *options, int flags, QemuOpts *opts; Error *local_err =3D NULL; int ret; - int64_t log_sector_size; + uint64_t log_sector_size; =20 opts =3D qemu_opts_create(&runtime_opts, NULL, 0, &error_abort); qemu_opts_absorb_qdict(opts, options, &local_err); @@ -101,11 +101,9 @@ static int blk_log_writes_open(BlockDriverState *bs, Q= Dict *options, int flags, log_sector_size =3D qemu_opt_get_size(opts, "log-sector-size", BDRV_SECTOR_SIZE); =20 - if (log_sector_size < 0 || log_sector_size > (1ull << 23) || - !is_power_of_2(log_sector_size)) - { + if (log_sector_size > (1ull << 23) || !is_power_of_2(log_sector_size))= { ret =3D -EINVAL; - error_setg(errp, "Invalid log sector size %"PRId64, log_sector_siz= e); + error_setg(errp, "Invalid log sector size %"PRIu64, log_sector_siz= e); goto fail; } =20 --=20 2.7.4