From nobody Tue Nov 4 15:33:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530569013894818.1834500326452; Mon, 2 Jul 2018 15:03:33 -0700 (PDT) Received: from localhost ([::1]:35688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa6uz-0001Vo-AF for importer@patchew.org; Mon, 02 Jul 2018 18:03:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa6th-0000uP-Lg for qemu-devel@nongnu.org; Mon, 02 Jul 2018 18:02:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa6tc-00062l-SK for qemu-devel@nongnu.org; Mon, 02 Jul 2018 18:02:13 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53099) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fa6tc-00062J-MM; Mon, 02 Jul 2018 18:02:08 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 143A221841; Mon, 2 Jul 2018 18:02:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 02 Jul 2018 18:02:08 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 52FEB10255; Mon, 2 Jul 2018 18:02:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc; s=mesmtp; bh=eOajyeX+MCPevIrI6a7xIM/BSMAFuS61EkjS1V oM9o8=; b=YkI5AArzizyu9VaP5vlj7CYWgOSubpo/Z+lIoalXfNTb4lUddTk0zi jCtapC14gklw+bZ2fidRc9WRsoLyMyKQWdCo1JBP3U7P3lzjQjdLP7znsOLVaFYL BfReurBdkCKFbiX70xASNt1ufrKXXBAtAbTGUMMDByzqMz07jAH8g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=eOajyeX+MCPevIrI6 a7xIM/BSMAFuS61EkjS1VoM9o8=; b=Ctt2sAq9L5goTrAm/2+JdpJpB9XeOf4c0 NcbacPlHTMuil+eg8M5hOcODt2MC3930Ja9ZyOE9XSFkcZ3Zkb35tvdbOO3wBzID yrnvf18eu9h/qpUJ5XSqiq3bZ+Vzc/yvbiuOdEB5XSVndBVvWevnkmk/vD8wv3BM Qa+V9AGwYc8w4Hc9sVSwqtmNWVCcJ8GTihAuT/rtLlTHkHYMCujFucQFNub9Vsp0 jtlFZT+JrOkVaBRXfQ4jlREOOW8NppaDRbnTdVPDxA2azPlkLT+CkQMCpEWWe+AZ kkdtJvJC/W8RLOmsNn/H/HP07V9EeKXc49mADfpSkNPgVzuEUFg1g== X-ME-Proxy: X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Mon, 2 Jul 2018 18:02:07 -0400 Message-Id: <1530568927-4738-1-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 Subject: [Qemu-devel] [PATCH] target/ppc: set is_jmp on ppc_tr_breakpoint_check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-ppc@nongnu.org, Mark Cave-Ayland , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The use of GDB breakpoints was broken by b0c2d52 ("target/ppc: convert to TranslatorOps", 2018-02-16). Fix it by setting is_jmp, so that we break from the translation loop as originally intended. Tested-by: Mark Cave-Ayland Reported-by: Mark Cave-Ayland Signed-off-by: Emilio G. Cota --- (I'll send this to qemu-stable (for 2.12) once it's on master.) --- target/ppc/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 3a215a1..99c2731 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -7314,6 +7314,7 @@ static bool ppc_tr_breakpoint_check(DisasContextBase = *dcbase, CPUState *cs, DisasContext *ctx =3D container_of(dcbase, DisasContext, base); =20 gen_debug_exception(ctx); + dcbase->is_jmp =3D DISAS_NORETURN; /* The address covered by the breakpoint must be included in [tb->pc, tb->pc + tb->size) in order to for it to be properly cleared -- thus we increment the PC here so that --=20 2.7.4