From nobody Tue Nov 4 15:26:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530218224936418.03222667097964; Thu, 28 Jun 2018 13:37:04 -0700 (PDT) Received: from localhost ([::1]:38448 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdf5-0007xn-Ut for importer@patchew.org; Thu, 28 Jun 2018 16:37:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdB7-0007ow-HJ for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdB6-0001Aw-Ei for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:06:05 -0400 Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:37260) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYdB6-00018x-6n for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:06:04 -0400 Received: by mail-wr0-x236.google.com with SMTP id k6-v6so6688692wrp.4 for ; Thu, 28 Jun 2018 13:06:04 -0700 (PDT) Received: from 640k.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 127-v6sm6211110wmd.18.2018.06.28.13.06.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 13:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=HqdkZvuZFptqxiBqqh4bmffOtnL5I5a+6d1WVhwewCU=; b=iJwIR8AZxdYRe9nXCFbabzZYfJc8wIV+S5yVwJ6v85tmWceV5BX2qbhHIk6EbjI7su slKHEryG0Zteb2p0TDEotVyqcSNnP6n1wBVnp7ynQL7WxDT4AsVUjIfgaMd+E83U2G0I pgaaLOro1i44814pL0xAcwVmhG+1on+A7Gp770BDgAuk7ck84x3CMW5dqaOtf0DKzC6i rxxrGN20joOsXIJBmxJUkKq4KHvvVpv98lEyX39TZ943dJHa9SBqZ2F8Hk4qVrQwhpd2 EVOznnk2OJa2K2zeui89Db03ArF2u1PzuiKGc7lo++Jfm1wohWq/DZYNP7P/jv07BnZo khPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=HqdkZvuZFptqxiBqqh4bmffOtnL5I5a+6d1WVhwewCU=; b=As4+R/jLYKoSmYbXNK9z9LiZ0BzuNsFnhhHD+T0hyfRgvboIvArsqgpUX2u024+wu+ z38HzCjen4e/HCxmL9KYsKIyDlJDCj5EIXgbS2beMxQ5ZKtoorcJrtsd9qkVbLpTHsPP jumIlET7R9+GditPYThxBDK6ubxjNcc3rAukdqP4lpbpQtMJZp5+rALnktw6wpELFgpL O/zk91uogbselqnYRKUBObvpFf//YhbkHMiU7If4e5DTSR+2ashaopEkZptq2zD/+ohS axROflmMk2TOXkSvAWeMyJSUQQW9Rw6mU95Okz+PrVAvFdo+8s52/EvZp45AiF6rntij Cgpw== X-Gm-Message-State: APt69E1DvH++WhdHG47Ge5Y88sjj2AfwSc4TmSddNNn+mTRHJkQiv/Vc PWREHkc9lccBOvAXLqjaRKBR+vRh X-Google-Smtp-Source: AAOMgpcX5W7gL/tMY865OSqKvqXmyR78x4QIC2wt++rG7g5G2h2vfyinCm+n9Nmg/+NyfcsxnzUCSA== X-Received: by 2002:adf:c377:: with SMTP id e52-v6mr9514752wrg.257.1530216362944; Thu, 28 Jun 2018 13:06:02 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2018 22:05:00 +0200 Message-Id: <1530216310-52873-51-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> References: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::236 Subject: [Qemu-devel] [PULL 50/60] hmp: obsolete "info ioapic" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Xu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Peter Xu Let's start to use "info pic" just like other platforms. For now we keep the command for a while so that old users can know what is the new command to use. Signed-off-by: Peter Xu Message-Id: <20171229073104.3810-6-peterx@redhat.com> Signed-off-by: Paolo Bonzini --- hw/i386/kvm/ioapic.c | 9 --------- hw/intc/ioapic.c | 11 ----------- include/hw/i386/pc.h | 3 --- target/i386/monitor.c | 8 ++------ 4 files changed, 2 insertions(+), 29 deletions(-) diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c index 5274dc7..5b40d75 100644 --- a/hw/i386/kvm/ioapic.c +++ b/hw/i386/kvm/ioapic.c @@ -112,15 +112,6 @@ static void kvm_ioapic_put(IOAPICCommonState *s) } } =20 -void kvm_ioapic_dump_state(Monitor *mon, const QDict *qdict) -{ - IOAPICCommonState *s =3D IOAPIC_COMMON(object_resolve_path("ioapic", N= ULL)); - - assert(s); - kvm_ioapic_get(s); - ioapic_print_redtbl(mon, s); -} - static void kvm_ioapic_reset(DeviceState *dev) { IOAPICCommonState *s =3D IOAPIC_COMMON(dev); diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c index 222f3f7..b393780 100644 --- a/hw/intc/ioapic.c +++ b/hw/intc/ioapic.c @@ -234,17 +234,6 @@ void ioapic_eoi_broadcast(int vector) } } =20 -void ioapic_dump_state(Monitor *mon, const QDict *qdict) -{ - int i; - - for (i =3D 0; i < MAX_IOAPICS; i++) { - if (ioapics[i] !=3D 0) { - ioapic_print_redtbl(mon, ioapics[i]); - } - } -} - static uint64_t ioapic_mem_read(void *opaque, hwaddr addr, unsigned int size) { diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 316230e..4d99d69 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -154,9 +154,6 @@ int pic_get_output(DeviceState *d); =20 /* ioapic.c */ =20 -void kvm_ioapic_dump_state(Monitor *mon, const QDict *qdict); -void ioapic_dump_state(Monitor *mon, const QDict *qdict); - /* Global System Interrupts */ =20 #define GSI_NUM_PINS IOAPIC_NUM_PINS diff --git a/target/i386/monitor.c b/target/i386/monitor.c index a890b3c..6bbb3a9 100644 --- a/target/i386/monitor.c +++ b/target/i386/monitor.c @@ -658,12 +658,8 @@ void hmp_info_local_apic(Monitor *mon, const QDict *qd= ict) =20 void hmp_info_io_apic(Monitor *mon, const QDict *qdict) { - if (kvm_irqchip_in_kernel() && - !kvm_irqchip_is_split()) { - kvm_ioapic_dump_state(mon, qdict); - } else { - ioapic_dump_state(mon, qdict); - } + monitor_printf(mon, "This command is obsolete and will be " + "removed soon. Please use 'info pic' instead.\n"); } =20 SevInfo *qmp_query_sev(Error **errp) --=20 1.8.3.1