From nobody Tue Nov 4 15:31:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530217861589168.02939494566272; Thu, 28 Jun 2018 13:31:01 -0700 (PDT) Received: from localhost ([::1]:38419 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdZE-0003Dl-PH for importer@patchew.org; Thu, 28 Jun 2018 16:31:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdB2-0007hV-MT for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:06:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdB1-00013W-NT for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:06:00 -0400 Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]:44574) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYdB1-00012l-Gg for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:59 -0400 Received: by mail-wr0-x22d.google.com with SMTP id p12-v6so6676611wrn.11 for ; Thu, 28 Jun 2018 13:05:59 -0700 (PDT) Received: from 640k.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 127-v6sm6211110wmd.18.2018.06.28.13.05.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 13:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=D7j+JrT4aWmCaO9cr3g7WjWrpebQrHPdnGEcwaHk42I=; b=HKdmS/0AWnhjlNN4KLBtzMPFCBVONroot2MDELgvA0ZXFK5PiFyztFB7uXXXPBsnTg wTiWNHRhb5e/mRFxlsHqIo2X0rDkLN7Je1RWx9oe8SE4RUcwRSditCR8jpThfGXKeBp1 dtRUfc+LSVUHBnosfUx6+ri/VzG/CfTLiCJddwG0eCzEcKPA/DIXWjOB/4KZ+THOSOyY G9F83Jpn9+dlnXzy9THsiaedcxVt8kZKnWjplzrKYW4TtJ6IwBWljJLsntO5+9uXBEOX BQkMrmjsgq+/mnyl/gGRcPVODFfT+Mk736baJubGxLVg9Ylii3ljERUgVqFBavgRg18f ciEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=D7j+JrT4aWmCaO9cr3g7WjWrpebQrHPdnGEcwaHk42I=; b=hRl16qJD8yDcoxE4SD/tJdGZW3FpmqcsGPrwLPH/cWvppprVu5ll3RONbS1We8M3Zk wAxgpiQsZ3ZRupRDIBLrr4IAv8CQvXkOXlGMCkXZTaJVqWELkuuzkGdPSCQigjY3+ngh tdizAPtWZAvmSWNc87uKLlY//kpR0iu7b0Bhjy3cFxbwvULradfVjnZTkl/vplddyWf4 Br0OS9lgRbDxSKknoMeGrPpog78WgP+sV8CcxJliA/LPLcP5vtwl8R1Ef3LmYkxnmabL c7kR+CVRJflQYufRNRvhhOEY5lK/HatQ59q35BxyXnRE2KQ/n34/mlR4BZPoxEpA2dAu QDUA== X-Gm-Message-State: APt69E2tIAZZYtOh1MoypYRj8f1M508lBlOeRLGrHTB9bMl/O9YtHXa6 izlAw+FVkjM5qh/97VGNhGxSWfEZ X-Google-Smtp-Source: AAOMgpeHNZvT+6t8gjiDa+h/hnH09RIA30BICBHNNhDSDvwlw/e+LdnPVAS9eYnIZNmbBh/NNnh3hg== X-Received: by 2002:adf:adc9:: with SMTP id w67-v6mr2238682wrc.135.1530216358251; Thu, 28 Jun 2018 13:05:58 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2018 22:04:55 +0200 Message-Id: <1530216310-52873-46-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> References: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22d Subject: [Qemu-devel] [PULL 45/60] target-i386: Mark cpu_vmexit noreturn X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kiszka Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Jan Kiszka It calls cpu_loop_exit in system emulation mode (and should never be called in user emulation mode). Signed-off-by: Jan Kiszka Message-Id: <6f4d44ffde55d074cbceb48309c1678600abad2f.1522769774.git.jan.ki= szka@web.de> Signed-off-by: Paolo Bonzini --- target/i386/cpu.h | 4 ++-- target/i386/svm_helper.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 89c82be..16c59b7 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1840,8 +1840,8 @@ void helper_lock_init(void); /* svm_helper.c */ void cpu_svm_check_intercept_param(CPUX86State *env1, uint32_t type, uint64_t param, uintptr_t retaddr); -void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t exit_info_= 1, - uintptr_t retaddr); +void QEMU_NORETURN cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, + uint64_t exit_info_1, uintptr_t retaddr); void do_vmexit(CPUX86State *env, uint32_t exit_code, uint64_t exit_info_1); =20 /* seg_helper.c */ diff --git a/target/i386/svm_helper.c b/target/i386/svm_helper.c index 3504923..f245aec 100644 --- a/target/i386/svm_helper.c +++ b/target/i386/svm_helper.c @@ -62,6 +62,7 @@ void helper_invlpga(CPUX86State *env, int aflag) void cpu_vmexit(CPUX86State *nenv, uint32_t exit_code, uint64_t exit_info_= 1, uintptr_t retaddr) { + assert(0); } =20 void helper_svm_check_intercept_param(CPUX86State *env, uint32_t type, --=20 1.8.3.1