From nobody Tue Nov 4 15:26:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530218427449919.1508840189633; Thu, 28 Jun 2018 13:40:27 -0700 (PDT) Received: from localhost ([::1]:38464 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdiM-0002Je-J9 for importer@patchew.org; Thu, 28 Jun 2018 16:40:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdAw-0007aL-LE for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdAt-0000sT-GH for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:54 -0400 Received: from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:37463) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYdAt-0000rh-9X for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:51 -0400 Received: by mail-wr0-x243.google.com with SMTP id k6-v6so6688251wrp.4 for ; Thu, 28 Jun 2018 13:05:51 -0700 (PDT) Received: from 640k.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 127-v6sm6211110wmd.18.2018.06.28.13.05.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 13:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=mO0hAaOtHPtWRlC0Qa+Uf+wdjguiZp5fFePRKqCfNrk=; b=pq75xC1wcxZGgGZFNTjFS098xx8LHMhmDK93WSiTngeTjgZ7CVEgrKOnoL50LlniK0 jSDRY6pQpp323nn+b5d0NabidnyuFsOLIShsjzyLSlpNJqadaP8PEK9CL5M34uBTOqS2 8T0uHd2KXXrsmJDEqjPYLY3eTQlQ85yaMl9qJEPDL3djIbQbpYPP52IrkbEDbxXps5v7 CK4F/qpH4B0hX/ri48ZKuCxxAENV/83n88nnLcOZgRsmJU9v8iwpSe7L8BWt78Sez/Xu VvLKeQ6NEWQlCd51eL+pvdub+34ypRWI7Nv39DqQhP1XsacNHYeW3nNOOjgd4t1WZMLd u62g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=mO0hAaOtHPtWRlC0Qa+Uf+wdjguiZp5fFePRKqCfNrk=; b=HPJKk3gx34QWXmSAk+Jj8ojibE5sKU6sjeJ/agiWAzG4VhnBLW8qWjZCbOAiwkG4/h FpPqdP5Ei0x6QOJYGgziGvAPa9Pmhxe614ZpGBLP83ebS1iCcwDCW4fLi8jy5CvBTC6b UskiMh1wf7r5AUqD2ukUY2AVT1/epgDDWkoDTgwM35wDsXQt6bKwosrmmi4jiXfV1zjl pkn3UY+jOM58+f7fhtEaDm6jWhn5X3ahffeL441l5youY6NidzTZo+uUyJRgxy3Lv0Rc C4wKQ8Zno306S3HefKW05y31eI/4Rmz5sgsOOhBjmByduBsTDU5EoCfwh+TUSmghPDDP Z7sg== X-Gm-Message-State: APt69E2rLatYs94a0KAGCfZx9ZZnQUBT76vIH47kcWYlAWG0p0LU4kQm sF4dMZmr4+CdmrFopWNkUngTDZSj X-Google-Smtp-Source: AAOMgpdBBRo8PyAw1Nbl+zHNDSDGJfblV8nFd6E88T8g146vbHg7G6Esq18XGKfxJBdcXwdQn8BtBA== X-Received: by 2002:adf:c301:: with SMTP id n1-v6mr10279403wrf.270.1530216349910; Thu, 28 Jun 2018 13:05:49 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2018 22:04:47 +0200 Message-Id: <1530216310-52873-38-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> References: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::243 Subject: [Qemu-devel] [PULL 37/60] pr-manager-helper: report event on connection/disconnection X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Let management know if there were any problems communicating with qemu-pr-helper. The event is edge-triggered, and is sent every time the connection status of the pr-manager-helper object changes. Signed-off-by: Paolo Bonzini --- qapi/block.json | 24 ++++++++++++++++++++++++ scsi/pr-manager-helper.c | 14 ++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/qapi/block.json b/qapi/block.json index 8765c29..11f01f2 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -359,6 +359,30 @@ 'data': { 'device': 'str', 'id': 'str', 'tray-open': 'bool' } } =20 ## +# @PR_MANAGER_STATUS_CHANGED: +# +# Emitted whenever the connected status of a persistent reservation +# manager changes. +# +# @id: The id of the PR manager object +# +# @connected: true if the PR manager is connected to a backend +# +# Since: 3.0 +# +# Example: +# +# <- { "event": "PR_MANAGER_STATUS_CHANGED", +# "data": { "id": "pr-helper0", +# "connected": true +# }, +# "timestamp": { "seconds": 1519840375, "microseconds": 450486 } } +# +## +{ 'event': 'PR_MANAGER_STATUS_CHANGED', + 'data': { 'id': 'str', 'connected': 'bool' } } + +## # @QuorumOpType: # # An enumeration of the quorum operation types diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c index b11481b..519a296 100644 --- a/scsi/pr-manager-helper.c +++ b/scsi/pr-manager-helper.c @@ -17,6 +17,7 @@ #include "io/channel.h" #include "io/channel-socket.h" #include "pr-helper.h" +#include "qapi/qapi-events-block.h" =20 #include =20 @@ -38,6 +39,16 @@ typedef struct PRManagerHelper { QIOChannel *ioc; } PRManagerHelper; =20 +static void pr_manager_send_status_changed_event(PRManagerHelper *pr_mgr) +{ + char *id =3D object_get_canonical_path_component(OBJECT(pr_mgr)); + + if (id) { + qapi_event_send_pr_manager_status_changed(id, !!pr_mgr->ioc, + &error_abort); + } +} + /* Called with lock held. */ static int pr_manager_helper_read(PRManagerHelper *pr_mgr, void *buf, int sz, Error **errp) @@ -47,6 +58,7 @@ static int pr_manager_helper_read(PRManagerHelper *pr_mgr, if (r < 0) { object_unref(OBJECT(pr_mgr->ioc)); pr_mgr->ioc =3D NULL; + pr_manager_send_status_changed_event(pr_mgr); return -EINVAL; } =20 @@ -72,6 +84,7 @@ static int pr_manager_helper_write(PRManagerHelper *pr_mg= r, assert(n_written !=3D QIO_CHANNEL_ERR_BLOCK); object_unref(OBJECT(pr_mgr->ioc)); pr_mgr->ioc =3D NULL; + pr_manager_send_status_changed_event(pr_mgr); return n_written < 0 ? -EINVAL : 0; } =20 @@ -127,6 +140,7 @@ static int pr_manager_helper_initialize(PRManagerHelper= *pr_mgr, goto out_close; } =20 + pr_manager_send_status_changed_event(pr_mgr); return 0; =20 out_close: --=20 1.8.3.1