From nobody Tue Nov 4 15:28:06 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530218253242241.69818301010764; Thu, 28 Jun 2018 13:37:33 -0700 (PDT) Received: from localhost ([::1]:38451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdfY-0008Iv-Fk for importer@patchew.org; Thu, 28 Jun 2018 16:37:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdAr-0007UD-E6 for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdAq-0000ou-Ed for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:49 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:37435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYdAq-0000oF-7u for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:48 -0400 Received: by mail-wm0-x242.google.com with SMTP id n17-v6so9764067wmh.2 for ; Thu, 28 Jun 2018 13:05:48 -0700 (PDT) Received: from 640k.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 127-v6sm6211110wmd.18.2018.06.28.13.05.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 13:05:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=SJWSu/co/e56+DQruRImg1DYHL9dO8HtFEc5qpwCORQ=; b=JriNtKE8tX6vW2SpTg8MIpqthV94YDCXZOO6m82FzgC5EZFxdHyb/U/iRJBMCaRMTV M1xmeQYbN+uffdZbuQXH5LjLrc8ZwGCh46M2JOd6uboH8ca88TPaXlzXafp1eCaWSuGO 9TYdFNjCdnSc4pWGYPgFIqDnmPyeKnNCTN6INcy0aw+yjuMz8VaUJz4N/aSIgj7j8UKf 1MnFajhlvR43xcY0dNF0LvAZv6FZ0gksM7N19xeaB0RC7+k9rTdH0dGtsJWQyU7j0t2t EhZnKMsXbVzAEbwi8SRThIKs/oV2JF8P/F4uYamFYyhDPw65pPVKe7emC7szS1qq9tOG Nn2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=SJWSu/co/e56+DQruRImg1DYHL9dO8HtFEc5qpwCORQ=; b=Qspk+y1YXO/UXT9fBOtfiA4nZ6ejNqAEmjwXAN4T5jedJqoCDqGP0dCqgSxlsReLRw fZdWS5wdg3kQeWSxIauSPK/eJkCMhE/qvothTeJFdFYM3Hc7xtmLzXyma7BBUeeS6E0/ cUIEvExVxBTxsnjMgKETVmbBjDRod6WrFrjxxWfzQAEroZAhNcSiC/oBZZRfoosdU3hC guW5LMMGP4PaUWHE1/y25stvhZsZhceb3hJ0SohfUMVnxG27QSEMmAfGprHLRGycpO7y n916113x1WRMFvshUy1oCMHWGGPGV+/E5fu/YW1vRrvFWv7SHyxodb8V8pYjtynodPE/ a+qg== X-Gm-Message-State: APt69E15oJ2e4sna9S96MNNSmBn5oOaiuSZTysusso01uDimRWBu/one z1SzoZZZXG1ov4NLh2MhTOV9Cnyc X-Google-Smtp-Source: AAOMgpd6/Tu9bfBkMjvSNy9MmmxgZNWQM5T2VgEmQ8x5VT6/aGlhhXhWjdLszLBIWEaBiurTOouRgg== X-Received: by 2002:a1c:ad50:: with SMTP id w77-v6mr9551213wme.54.1530216346949; Thu, 28 Jun 2018 13:05:46 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2018 22:04:44 +0200 Message-Id: <1530216310-52873-35-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> References: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PULL 34/60] pr-manager-helper: avoid SIGSEGV when writing to the socket fail X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" When writing to the qemu-pr-helper socket failed, the persistent reservation manager was correctly disconnecting the socket, but it did not clear pr_mgr->ioc. So the rest of the code did not know that the socket had been disconnected, accessed pr_mgr->ioc and happily caused a crash. To reproduce, it is enough to stop qemu-pr-helper between QEMU startup and executing e.g. sg_persist -k /dev/sdb. Reviewed-by: Michal Privoznik Signed-off-by: Paolo Bonzini --- scsi/pr-manager-helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c index 82ff6b6..0c0fe38 100644 --- a/scsi/pr-manager-helper.c +++ b/scsi/pr-manager-helper.c @@ -71,6 +71,7 @@ static int pr_manager_helper_write(PRManagerHelper *pr_mg= r, if (n_written <=3D 0) { assert(n_written !=3D QIO_CHANNEL_ERR_BLOCK); object_unref(OBJECT(pr_mgr->ioc)); + pr_mgr->ioc =3D NULL; return n_written < 0 ? -EINVAL : 0; } =20 --=20 1.8.3.1