From nobody Tue Nov 4 15:31:24 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530218085828143.49216748700792; Thu, 28 Jun 2018 13:34:45 -0700 (PDT) Received: from localhost ([::1]:38434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdcq-0005up-UJ for importer@patchew.org; Thu, 28 Jun 2018 16:34:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdAq-0007T4-Gs for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdAp-0000oJ-LU for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:48 -0400 Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:32836) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYdAp-0000nF-DI for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:47 -0400 Received: by mail-wr0-x236.google.com with SMTP id k7-v6so3190053wrq.0 for ; Thu, 28 Jun 2018 13:05:47 -0700 (PDT) Received: from 640k.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 127-v6sm6211110wmd.18.2018.06.28.13.05.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 13:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NNxdw9EfoglPw0eE0yAPZpny98Ei/3+q+kS3oSgkaso=; b=HuUnQOWNAODYzoDtINl70KDtCu4ZNoPKDCAOWVy7HFE7VWf80TRQnatZLx7UVcTKbf 8utkQIW2oBOHjRwSkSvY0+2eaWIJXCkIbSVPFsuOUmGUVgOD6An41ExFxPs1M7y2HuyR UyylS4DJ39P0yUQyFHZZJ6GXXttq94/GCI5+v+NU+2e2LOpzN8I0Eh008Mpy0XJkYkEG iVw9CQRdIHnitzBPihhv9qYdZYdfKZzrCkn1Ta/9Lnv9Ljdk1zIOMf0KHVSDuVRTl3sT Ed/mIzZx5PsO8QzV6mrLCHW62cgUSC2EYmE7J10AHGwBEsTgl4qLX7T4C6h/lNvxOCNI AzVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=NNxdw9EfoglPw0eE0yAPZpny98Ei/3+q+kS3oSgkaso=; b=h6TCDgj7enNnv9jPklnLK+/NeReIc7X620VlZqmnZXvSIRHP8B1cDBz3uXe1u7yA9S 0Gv1KeAxcKiLhNpY0ELCLruXJz78lRXOR/EZ++HabT7X6K9Cg4iz2KVZoGIfwZrn2Haj iHuoQsBNVOoZQpeFctLQKSkRqmpNRpMvmaZEhNurvPDattmg94YjDwz7a5sK9mMVcOpx EQTBOdJiBzmFEYn8iblSN8Is7TDTlL+kx7CC8XXAy1oLYUk7Wg9HVD319ZshXfR17Min ukSRDKTgE2Mkkz1CLVTQlzigjdXwmLwQ+ZTXVSZWNNCm9WglSx1tk/CS0ZMHUbZ0sfng Gbng== X-Gm-Message-State: APt69E38sCofhAndxLPK0Re19GHS88niXs3s5HVsAZhIhfmiZ2Bp14Mu e4rXfn7lUH9zc2cZhJ0J2TgKdHh+ X-Google-Smtp-Source: AAOMgpcKHUEOPuvoLwUezKIb+ftFBPhO39F7C0hXyvTfAJ8EMjBUuFxixFF+wSLX0nIwULQ/NEpEEg== X-Received: by 2002:adf:f98a:: with SMTP id f10-v6mr9803728wrr.105.1530216346069; Thu, 28 Jun 2018 13:05:46 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2018 22:04:43 +0200 Message-Id: <1530216310-52873-34-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> References: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::236 Subject: [Qemu-devel] [PULL 33/60] pr-helper: fix assertion failure on failed multipath PERSISTENT RESERVE IN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 The response size is expected to be zero if the SCSI status is not "GOOD", but nothing was resetting it. This can be reproduced simply by "sg_persist -s /dev/sdb" where /dev/sdb in the guest is a scsi-block device corresponding to a multipath device on the host. Before: PR in (Read full status): Aborted command and on the host: prh_write_response: Assertion `resp->sz =3D=3D 0' failed. After: PR in (Read full status): bad field in cdb or parameter list (perhaps unsupported service action) Reported-by: Jiri Belka Reviewed-by: Michal Privoznik Signed-off-by: Paolo Bonzini Reviewed-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- scsi/qemu-pr-helper.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index 4057cf3..0218d65 100644 --- a/scsi/qemu-pr-helper.c +++ b/scsi/qemu-pr-helper.c @@ -558,7 +558,11 @@ static int do_pr_in(int fd, const uint8_t *cdb, uint8_= t *sense, #ifdef CONFIG_MPATH if (is_mpath(fd)) { /* multipath_pr_in fills the whole input buffer. */ - return multipath_pr_in(fd, cdb, sense, data, *resp_sz); + int r =3D multipath_pr_in(fd, cdb, sense, data, *resp_sz); + if (r !=3D GOOD) { + *resp_sz =3D 0; + } + return r; } #endif =20 --=20 1.8.3.1