From nobody Tue Nov 4 15:26:23 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530217776112286.5214212005793; Thu, 28 Jun 2018 13:29:36 -0700 (PDT) Received: from localhost ([::1]:38403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdXr-00020k-Al for importer@patchew.org; Thu, 28 Jun 2018 16:29:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdAo-0007QL-O0 for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdAn-0000lF-Kr for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:46 -0400 Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]:44573) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYdAn-0000kZ-CZ for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:45 -0400 Received: by mail-wr0-x22d.google.com with SMTP id p12-v6so6676008wrn.11 for ; Thu, 28 Jun 2018 13:05:45 -0700 (PDT) Received: from 640k.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 127-v6sm6211110wmd.18.2018.06.28.13.05.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 13:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=8ZclH3YotouT5S7Xrrk9q5V6JDABlpyhauy18H9S4kc=; b=pFSFUTG1bDxFiC9qQbRDjJbxhXE+AusSsCzPsGCOqINluyjTxac9U3+D+a1i34qmH4 KI1WxO4RPH3x+loNRCQ3ElDwnQuz0Ni2eg1+n+gjE33uumBAS0fgJ0U7wCsoPx61IwME UuZOKZs70EJezVq7KIUtUB+o3mlqg9CvReCd9rvnq7Kwrq0HxAXF2RvlsRwLY9BQYsVf zXCTSZAo8X1DqtCWmXd2OMH2ZO/hj9nB58kYpijs4Zl/Cj76C5J3uiY2DXFq2Cvsgrpe w6sG4EfCCVVFlypr5z6HpAb9+Tyj1I6ETx+VnM1IazzjBm8RCJGJQe5DJ+nRqkeEOEAM w5Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=8ZclH3YotouT5S7Xrrk9q5V6JDABlpyhauy18H9S4kc=; b=beoGQJ2J6UgGnX5R7mDs48KpcZ0Kw5edMu+0V6by3z+uKGvP2h8x74SN3HLd0v9YZL vwLbMDrJD5xRvSiiiuGtGdvyhfBzSSQRFqQabnahCF0IGaeBj7QHPkLqexlNg+VzRF6c ydVsrgv+y64Ib4GbdxLhfed6bS7EZE6kNL1qtSxoQBvj5A1vcn9h23AsQcGgk8RQjoRL zkMv/m7+TUYKG05Mglrf13kTTAJ4N/lepT8i48yE5c3hXWVN20BBB6adEiQEhD8N/Ds3 EcN/6HHa0dTGv1knNrI9MI4jLIgNwvz/OhayPSZXh+Zr2RQUNE7QwcrnH7MgBZbB6w9P cDzg== X-Gm-Message-State: APt69E2xy2/pfCNkJ9zliCJzwRJ13skI4gWpM92vvnZ+f4VRVAlG9YoM f9FkVQP8ik6qvvHKl1KGSwnQDpJF X-Google-Smtp-Source: AAOMgpcqyPMoLCbTB71vRneqOcFy8IyF0zjjHk4guiynni8Xd7UO30L7qDSuCfBOnagU/pmDUymiQw== X-Received: by 2002:adf:fb43:: with SMTP id c3-v6mr10215475wrs.32.1530216344085; Thu, 28 Jun 2018 13:05:44 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2018 22:04:41 +0200 Message-Id: <1530216310-52873-32-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> References: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22d Subject: [Qemu-devel] [PULL 31/60] Deprecate the -enable-hax option X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth We currently have got three ways of turning on the HAX accelerator: "-machine accel=3Dhax", "-accel hax" and "-enable-hax". That's really confusing and overloaded. Since "-accel" is our preferred way to enable an accelerator nowadays, and "-accel hax" is even less to type than "-enable-hax", let's deprecate the "-enable-hax" option now. Note: While "-enable-kvm" is available since a long time and can hardly be removed since it is used in a lot of upper layer tools and scripts, the "-enable-hax" option is still rather new and not very widespread yet, so I think that it should be OK if we remove this in a couple of releases again (we'll see whether someone complains after seeing the deprecation message - then we could still reconsider to keep it if there a well-founded reasons). Signed-off-by: Thomas Huth Message-Id: <1529950933-28347-1-git-send-email-thuth@redhat.com> Signed-off-by: Paolo Bonzini --- qemu-doc.texi | 5 +++++ qemu-options.hx | 2 +- vl.c | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 16fcb47..1cb3ba4 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -2912,6 +2912,11 @@ Option @option{-virtioconsole} has been replaced by The @code{-clock} option is ignored since QEMU version 1.7.0. There is no replacement since it is not needed anymore. =20 +@subsection -enable-hax (since 3.0.0) + +The @option{-enable-hax} option has been replaced by @option{-accel hax}. +Both options have been introduced in QEMU version 2.9.0. + @section QEMU Machine Protocol (QMP) commands =20 @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) diff --git a/qemu-options.hx b/qemu-options.hx index 2707728..3e45483 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3421,7 +3421,7 @@ STEXI Enable HAX (Hardware-based Acceleration eXecution) support. This option is only available if HAX support is enabled when compiling. HAX is only applicable to MAC and Windows platform, and thus does not conflict with -KVM. +KVM. This option is deprecated, use @option{-accel hax} instead. ETEXI =20 DEF("xen-domid", HAS_ARG, QEMU_OPTION_xen_domid, diff --git a/vl.c b/vl.c index d26f19b..7c9f19a 100644 --- a/vl.c +++ b/vl.c @@ -3581,6 +3581,7 @@ int main(int argc, char **argv, char **envp) qemu_opts_parse_noisily(olist, "accel=3Dkvm", false); break; case QEMU_OPTION_enable_hax: + warn_report("Option is deprecated, use '-accel hax' instea= d"); olist =3D qemu_find_opts("machine"); qemu_opts_parse_noisily(olist, "accel=3Dhax", false); break; --=20 1.8.3.1