From nobody Tue Nov 4 15:31:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530217262500499.0923094321953; Thu, 28 Jun 2018 13:21:02 -0700 (PDT) Received: from localhost ([::1]:38358 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdPZ-0003By-Ne for importer@patchew.org; Thu, 28 Jun 2018 16:21:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdAg-0007HF-2k for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdAf-0000Zo-7L for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:38 -0400 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]:37257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYdAf-0000Yd-0R for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:37 -0400 Received: by mail-wr0-x235.google.com with SMTP id k6-v6so6687746wrp.4 for ; Thu, 28 Jun 2018 13:05:36 -0700 (PDT) Received: from 640k.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 127-v6sm6211110wmd.18.2018.06.28.13.05.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 13:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=3vbZZBEoM62MO9oAA1r50TRiZYCl6URbZao2kU5LNFU=; b=VVVHvM2EJWpJoi9Hoo+WbS0jPjs35KcvmA5zZGQ0Ltsgjar4MKV0hE8j9pfsGzfpFT ZIzqK7wxR+edK+CVsVK28dmVeE/8AR5Klm0HEqwsTJnq1DLEK3VQaMeeIVHZlmUsxevZ SSyv1oIeCDWgDQmI+fB5MU7b273LrhZiM1LdKb8+/9ebUZaqebAFSz4UOHUGn8cLxk6e vtqrudlmvQyg5pA80fO451hkyFDINuBidoVBXqoiPz1Q5gN0FiHqgijXHoCY6vH8QUpE LNhiibAU8L2BiMxRJzxYT/t6qpIWci9yU52ngxX3VK+gG3ZnZQWXS5GGVH2B376Pyzul A8hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=3vbZZBEoM62MO9oAA1r50TRiZYCl6URbZao2kU5LNFU=; b=ZXFH9xEUahSKic93CF4qL3zm2i0B5mvHLFM6Lia/igirV8KfSBr7nJEXQ8QJjX01CT GK5nMBMRMUOhHTzAJS402+J2tpypdERywqnfUCdQUPOVuAWZ9ajRRqqGa9LI7+ZGgsLS Z7hAPGAfvjlevxek+5O/ubWQh/7/t/2bLBXKHX6ZFS8jZxNOe5OSSVZniKUv3+Ouo8m2 utMUuyPw0wIRHqsGACPhv0ER4ZxZp9MNKDv6BPja+ap8X3u51Al+xWn4L77IaLwUJ3kA EYxwKOxHYTNrAL4SgvG43W4sHSrHEybzQ1J2AtkpeEiHirb07lXgI/yDS0Epv7Xx9TUz 1m/w== X-Gm-Message-State: APt69E2bGi+wqmDfEsOoupcy501ogaIqehTjKbwiwT0N7+UUh07UTSvp rAhXpVAHrzRYRLoMYgVua0Dcf+rZ X-Google-Smtp-Source: AAOMgpfCni231IY6W3LIouV7YpqZyEw5UxE4vxOmPsH9sryr+FDsBEDJgJpkCklgl8HE6mjwYSGhUg== X-Received: by 2002:adf:aadb:: with SMTP id i27-v6mr2699809wrc.149.1530216335730; Thu, 28 Jun 2018 13:05:35 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2018 22:04:32 +0200 Message-Id: <1530216310-52873-23-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> References: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::235 Subject: [Qemu-devel] [PULL 22/60] nvdimm: no need to overwrite get_vmstate_memory_region() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: David Hildenbrand Our parent class (PC_DIMM) provides exactly the same function. Reviewed-by: David Gibson Reviewed-by: Igor Mammedov Signed-off-by: David Hildenbrand Message-Id: <20180619134141.29478-7-david@redhat.com> Signed-off-by: Paolo Bonzini --- hw/mem/nvdimm.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 4087aca..f974acc 100644 --- a/hw/mem/nvdimm.c +++ b/hw/mem/nvdimm.c @@ -166,11 +166,6 @@ static void nvdimm_write_label_data(NVDIMMDevice *nvdi= mm, const void *buf, memory_region_set_dirty(mr, backend_offset, size); } =20 -static MemoryRegion *nvdimm_get_vmstate_memory_region(PCDIMMDevice *dimm) -{ - return host_memory_backend_get_memory(dimm->hostmem, &error_abort); -} - static void nvdimm_class_init(ObjectClass *oc, void *data) { PCDIMMDeviceClass *ddc =3D PC_DIMM_CLASS(oc); @@ -178,7 +173,6 @@ static void nvdimm_class_init(ObjectClass *oc, void *da= ta) =20 ddc->realize =3D nvdimm_realize; ddc->get_memory_region =3D nvdimm_get_memory_region; - ddc->get_vmstate_memory_region =3D nvdimm_get_vmstate_memory_region; =20 nvc->read_label_data =3D nvdimm_read_label_data; nvc->write_label_data =3D nvdimm_write_label_data; --=20 1.8.3.1