From nobody Tue Nov 4 15:26:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530216717241263.16869630973963; Thu, 28 Jun 2018 13:11:57 -0700 (PDT) Received: from localhost ([::1]:38310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdGj-00042E-6h for importer@patchew.org; Thu, 28 Jun 2018 16:11:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYdAW-00079b-9T for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYdAS-0000ER-R6 for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:27 -0400 Received: from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b]:37246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYdAS-0000Cq-IY for qemu-devel@nongnu.org; Thu, 28 Jun 2018 16:05:24 -0400 Received: by mail-wr0-x22b.google.com with SMTP id k6-v6so6687292wrp.4 for ; Thu, 28 Jun 2018 13:05:24 -0700 (PDT) Received: from 640k.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id 127-v6sm6211110wmd.18.2018.06.28.13.05.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 13:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=20P9TTLf8usIx6WjiRTM94wgZ5jkWGrAQzKQ7FtQM8w=; b=bwGMDQquu/LJE3kOBwpty2PTQJ1aBN0q8fRq/Hg5DR/CcPWNSVsu5U4UmWIUNUe1VK AlqEtRCNi1a/JNjDv+A1R/qqpuXtJbomBJ5eMxaZ7PF0ppx+Zf51ODSu6YuDKpkZqIGY V86m8CjZ4xAkzhu8g2BoEPvLjrn1U1gBU1h1DfNRiz22g8H0vBL2HbC13i1KwZf5jMfs 3mhP6HSYWp66VJqxT8a1BWM8Z6QmIwjimzvWQ6w6RDORPz6PsrzhVIF5DXBh7PiGj5jT 9FNT2cfu/xd2WHipZNxf9T9/HYiAvpdLtGHHy1rnKMG4QaSPaXOm9oz2BDCeECMhcT3s OAxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=20P9TTLf8usIx6WjiRTM94wgZ5jkWGrAQzKQ7FtQM8w=; b=PcoeYH3LwVln4lPqryMYWPI2Je/5cNujO9eQGGdV2in1CK18Yx7P6pRWRPbWk5Qkj2 t3ntJeHvX6MLWeh++BhgoJGTg0pr0yUsdBlhvg4RaE02TPx6CIkcPex5OfByyZZ9lYfN 0U4zCMSvGZBHn5R28ojK0mRMHVbynoVMA0GxXel082RKXnStQq6Z0ADJIQ3bRje5ZyDl BFcCYXcXIdml7XLVRqPyKJ5hjDv737yuHD+DvcvQ1q/C39av1i2c2zrzTF81kxaCdM0w 36Aoonnw0Kb3yVofMd2z7agKQ94wMaLYkNzwCfho1weBe0klQ0PkyUT2K14Kk9fMoMVs fFOg== X-Gm-Message-State: APt69E0tT+szzQQp69IgsKnGRE8KMMxoT4WnugmhWE++NE9Wl4ZMW+o4 39jDISNOV0FuWvuY89LfiOpX5Lys X-Google-Smtp-Source: AAOMgpfCiEP+7Yh3/zyjhl9czdkwbcmG2MZVtBRAuWZglQdJp+eF3rdRgnjSg7vBXwfMFKtsZfXElg== X-Received: by 2002:adf:a9cf:: with SMTP id b73-v6mr9664556wrd.48.1530216323228; Thu, 28 Jun 2018 13:05:23 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2018 22:04:19 +0200 Message-Id: <1530216310-52873-10-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> References: <1530216310-52873-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22b Subject: [Qemu-devel] [PULL 09/60] exec: check that alignment is a power of two X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: David Hildenbrand Right now we can crash QEMU using e.g. qemu-system-x86_64 -m 256M,maxmem=3D20G,slots=3D2 \ -object memory-backend-file,id=3Dmem0,size=3D12288,mem-path=3D/dev/zero,al= ign=3D12288 \ -device pc-dimm,id=3Ddimm1,memdev=3Dmem0 qemu-system-x86_64: util/mmap-alloc.c:115: qemu_ram_mmap: Assertion `is_power_of_2(align)' failed Fix this by adding a proper check. Signed-off-by: David Hildenbrand Message-Id: <20180607154705.6316-3-david@redhat.com> Reviewed-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- exec.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/exec.c b/exec.c index 610d0c0..cdcf769 100644 --- a/exec.c +++ b/exec.c @@ -1841,6 +1841,10 @@ static void *file_ram_alloc(RAMBlock *block, " must be multiples of page size 0x%zx", block->mr->align, block->page_size); return NULL; + } else if (block->mr->align && !is_power_of_2(block->mr->align)) { + error_setg(errp, "alignment 0x%" PRIx64 + " must be a power of two", block->mr->align); + return NULL; } block->mr->align =3D MAX(block->page_size, block->mr->align); #if defined(__s390x__) --=20 1.8.3.1