From nobody Tue Nov 4 15:26:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530216121734830.2594163853935; Thu, 28 Jun 2018 13:02:01 -0700 (PDT) Received: from localhost ([::1]:38268 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYd7B-0005Oh-1s for importer@patchew.org; Thu, 28 Jun 2018 16:02:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYd39-0002EZ-IU for qemu-devel@nongnu.org; Thu, 28 Jun 2018 15:57:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYd38-0000dN-Ac for qemu-devel@nongnu.org; Thu, 28 Jun 2018 15:57:51 -0400 Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:37634) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYd38-0000bS-4T for qemu-devel@nongnu.org; Thu, 28 Jun 2018 15:57:50 -0400 Received: by mail-wm0-x233.google.com with SMTP id n17-v6so9744001wmh.2 for ; Thu, 28 Jun 2018 12:57:49 -0700 (PDT) Received: from 640k.lan ([82.84.124.111]) by smtp.gmail.com with ESMTPSA id d102-v6sm12516646wma.10.2018.06.28.12.57.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Jun 2018 12:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=mO0hAaOtHPtWRlC0Qa+Uf+wdjguiZp5fFePRKqCfNrk=; b=NCdkL15Q+jG9REyN9ZfOOgkAzD/eISuImW0GCkxKK/K6DP9GreCrf51Doe710D5w++ 3I3A4HbPDg3dydTrcCcdKLVm0x5iDEkYD+RkmaY/FEF+KAb1Cf8eotUCR7tp1OtC9Z4W BpxIxY8ja3GeefQnkf94CqUgxXytSshBgdvpv+7NBwVWY3l3+wdbcNvpU9sSgQDfg+uZ PI5q6jQSWrH3UrJK/uRxVOyrjlYwGfxDchO5YOVrg/iw2gnHJY7GLbyBeSsgpZiEDJwc r+6Tkl/Bh/0kXZi6HV7ZOHJ+OAar1EDrnb8pTUT5ZMgyFmdS9y6TIr+xGZ6M/lAVz9cK 3QNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=mO0hAaOtHPtWRlC0Qa+Uf+wdjguiZp5fFePRKqCfNrk=; b=eSLivZBt8k06avA9Pnf8o8rjCic24d8jV35gLl4CMHOhDMwM1pBUAvJBdMaPB5I25b V3u7epxie60jtA28jrb4/jJKkpbukJxurVraqGcBkiDs04V+3HpTEqMjhGOVU/zzha0F sV/C85ujnvK10ecEUUKEErId0bh+iBUa5N/xOiu7u9FDUPucEU5HQVb3wW5tJ2arkzo9 BJ1VJZd9D9QiVffG97choSPloCI5KAb+62DmH2s7sCcge5eTQwTC23WZ1GcX86g/x9eK bHdVcPcfrPiJFk7TLQJLQ9wcy2iWzNIpWiBTRrxM07lBh4L0sRRVqhBjsGreakCDWraw oCqQ== X-Gm-Message-State: APt69E1fkJQVL2aB0EUvuikb5lmIbamiKkSu8RzupzA0RLBQVusU61LT PvDGfDdwss8Gk3XEs/nq1gidJpOM X-Google-Smtp-Source: AAOMgpcjRQhKmPFaBVC3xsaNDKBqphnhlpVQljhg+t8EXoGHAJH+Uyawd1PiCjUTm0vAmws2DkwDXA== X-Received: by 2002:a1c:abc6:: with SMTP id u189-v6mr9046971wme.64.1530215868719; Thu, 28 Jun 2018 12:57:48 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 28 Jun 2018 21:57:38 +0200 Message-Id: <1530215858-1525-7-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1530215858-1525-1-git-send-email-pbonzini@redhat.com> References: <1530215858-1525-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::233 Subject: [Qemu-devel] [PATCH 6/6] pr-manager-helper: report event on connection/disconnection X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Let management know if there were any problems communicating with qemu-pr-helper. The event is edge-triggered, and is sent every time the connection status of the pr-manager-helper object changes. Signed-off-by: Paolo Bonzini --- qapi/block.json | 24 ++++++++++++++++++++++++ scsi/pr-manager-helper.c | 14 ++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/qapi/block.json b/qapi/block.json index 8765c29..11f01f2 100644 --- a/qapi/block.json +++ b/qapi/block.json @@ -359,6 +359,30 @@ 'data': { 'device': 'str', 'id': 'str', 'tray-open': 'bool' } } =20 ## +# @PR_MANAGER_STATUS_CHANGED: +# +# Emitted whenever the connected status of a persistent reservation +# manager changes. +# +# @id: The id of the PR manager object +# +# @connected: true if the PR manager is connected to a backend +# +# Since: 3.0 +# +# Example: +# +# <- { "event": "PR_MANAGER_STATUS_CHANGED", +# "data": { "id": "pr-helper0", +# "connected": true +# }, +# "timestamp": { "seconds": 1519840375, "microseconds": 450486 } } +# +## +{ 'event': 'PR_MANAGER_STATUS_CHANGED', + 'data': { 'id': 'str', 'connected': 'bool' } } + +## # @QuorumOpType: # # An enumeration of the quorum operation types diff --git a/scsi/pr-manager-helper.c b/scsi/pr-manager-helper.c index b11481b..519a296 100644 --- a/scsi/pr-manager-helper.c +++ b/scsi/pr-manager-helper.c @@ -17,6 +17,7 @@ #include "io/channel.h" #include "io/channel-socket.h" #include "pr-helper.h" +#include "qapi/qapi-events-block.h" =20 #include =20 @@ -38,6 +39,16 @@ typedef struct PRManagerHelper { QIOChannel *ioc; } PRManagerHelper; =20 +static void pr_manager_send_status_changed_event(PRManagerHelper *pr_mgr) +{ + char *id =3D object_get_canonical_path_component(OBJECT(pr_mgr)); + + if (id) { + qapi_event_send_pr_manager_status_changed(id, !!pr_mgr->ioc, + &error_abort); + } +} + /* Called with lock held. */ static int pr_manager_helper_read(PRManagerHelper *pr_mgr, void *buf, int sz, Error **errp) @@ -47,6 +58,7 @@ static int pr_manager_helper_read(PRManagerHelper *pr_mgr, if (r < 0) { object_unref(OBJECT(pr_mgr->ioc)); pr_mgr->ioc =3D NULL; + pr_manager_send_status_changed_event(pr_mgr); return -EINVAL; } =20 @@ -72,6 +84,7 @@ static int pr_manager_helper_write(PRManagerHelper *pr_mg= r, assert(n_written !=3D QIO_CHANNEL_ERR_BLOCK); object_unref(OBJECT(pr_mgr->ioc)); pr_mgr->ioc =3D NULL; + pr_manager_send_status_changed_event(pr_mgr); return n_written < 0 ? -EINVAL : 0; } =20 @@ -127,6 +140,7 @@ static int pr_manager_helper_initialize(PRManagerHelper= *pr_mgr, goto out_close; } =20 + pr_manager_send_status_changed_event(pr_mgr); return 0; =20 out_close: --=20 1.8.3.1