From nobody Sun Feb 8 22:47:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1530026606745723.0660672278098; Tue, 26 Jun 2018 08:23:26 -0700 (PDT) Received: from localhost ([::1]:53337 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXpoO-0002K2-Mg for importer@patchew.org; Tue, 26 Jun 2018 11:23:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXooZ-0008AK-CL for qemu-devel@nongnu.org; Tue, 26 Jun 2018 10:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXooW-0006fT-7H for qemu-devel@nongnu.org; Tue, 26 Jun 2018 10:19:27 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:34666) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXooW-0006eB-0m for qemu-devel@nongnu.org; Tue, 26 Jun 2018 10:19:24 -0400 Received: by mail-ed1-x531.google.com with SMTP id q24-v6so1115812edr.1 for ; Tue, 26 Jun 2018 07:19:23 -0700 (PDT) Received: from localhost.localdomain ([194.230.159.211]) by smtp.gmail.com with ESMTPSA id s39-v6sm1572618edd.64.2018.06.26.07.19.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Jun 2018 07:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zVDyZaE4Z06T8Y2geOrOokYaiT8Zwy3t/Iq555elXXo=; b=V2+SYZZr9BdF2b+xzldC2yHpy0TnTk4mkQzdismpQ738XLbITVNUHjMhOzyBHDl0KU mqJEC23SHxCkSkDf/QRN2afz5Q2Im0Sx8fsSt4OkToxhe6tYm9TOiUQU/OG+6Ze3vvWT 8G7PFd1GhgrxD5If7/fmm/2ozxxNB+oL+0b0qwbNHqeDYdLtkIc2Pl6V3ogT0rcMngsT zW3Ud1+hWROVlro2Lih4BvaIZxQDUL/VxGw1ieSgssxVLIqfNEUue1s5xKZK8tZsQmln cE5cmHWQfztKnIZIA6KnhxftkAhDoMeYXLv2Xs9+YWG9ph3K/srY5LPBE113IifHtXC8 JvDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zVDyZaE4Z06T8Y2geOrOokYaiT8Zwy3t/Iq555elXXo=; b=sbtXltoAXE6zycsGosoDLJJveMeXbZ/mR5Loi4yMjGAYiQl9B0gLMcaPW6sIOct6sn HzrHHQNLFXtK9YA1+ren/psfn6KHhdYGUB9eUcu1vLV1670uPkYCNhzI0gyxxDdpT7IZ I/M4YtblkG2gNgHIB1Hy1J0FDjBdb99FQrj3wXX5PZV64D88jYcTxjjyYULih8ORdYvs je3IXzdSAy45d1q/w6GCpj5djuSLDCXMKOgH6VbRu7GfVqA29pqcMq6apl9lHTUufOY2 EjoG2p8fOEK14Z5EaKZpczFpqAitcEnxiQGPM00oIxGtFRc2yc5YVpnffRf4TTcFYvPx 4vWA== X-Gm-Message-State: APt69E3HqF5eXr+amiTPisefPIyH1vBv2PqGn/2oEcfqUTfOITovPnZl 0a1hek0tbnRzyEut1AkeCZ36II0T X-Google-Smtp-Source: AAOMgpf5fbQNHAcYPLw4GRSvpXtmFxOfQNnBdDAdFNP3uHzMazgOEYwiDIYHwoD+MDKSyFQJGyOK4Q== X-Received: by 2002:aa7:c396:: with SMTP id k22-v6mr2055328edq.149.1530022762291; Tue, 26 Jun 2018 07:19:22 -0700 (PDT) From: Emanuele Giuseppe Esposito X-Google-Original-From: Emanuele Giuseppe Esposito To: qemu-devel@nongnu.org Date: Tue, 26 Jun 2018 16:18:53 +0200 Message-Id: <1530022733-29581-1-git-send-email-esposem@usi.ch> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::531 X-Mailman-Approved-At: Tue, 26 Jun 2018 11:21:58 -0400 Subject: [Qemu-devel] [PATCH] vhost-user-test: added proper TestServer *dest initialization in test_migrate() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Emanuele Giuseppe Esposito , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" server->bus in _test_server_free() could be NULL, since TestServer *dest in= test_migrate() was not properly initialized like TestServer *s. Added init_virtio_dev(dest) and uninit_virtio_dev(dest), so the fields are = properly set and when test_server_free(dest); is called, they can be correc= tly freed. The reason for that is init_virtio_dev() calls qpci_init_pc(), that creates= a QPCIBusPC * (returned as QPCIBus *), while test_server_free() calls qpci= _free_pc(), that frees the QPCIBus *. Not calling init_virtio_dev() would leave the QPC= IBus * of TestServer unset. Problem came out once I modified pci-pc.c and pci-pc.h, modifying QPCIBusP= C by adding another field before QPCIBus bus. Re-running the tests showed v= host-user-test failing. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/vhost-user-test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index bbc8091..4d71d5e 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -545,6 +545,7 @@ static gboolean _test_server_free(TestServer *server) g_free(server->mig_path); =20 g_free(server->chr_name); + g_assert(server->bus); qpci_free_pc(server->bus); =20 g_free(server); @@ -706,6 +707,7 @@ static void test_migrate(void) g_free(cmd); =20 init_virtio_dev(s, 1u << VIRTIO_NET_F_MAC); + init_virtio_dev(dest, 1u << VIRTIO_NET_F_MAC); wait_for_fds(s); size =3D get_log_size(s); g_assert_cmpint(size, =3D=3D, (2 * 1024 * 1024) / (VHOST_LOG_PAGE * 8)= ); @@ -761,6 +763,7 @@ static void test_migrate(void) read_guest_mem_server(dest); =20 uninit_virtio_dev(s); + uninit_virtio_dev(dest); =20 g_source_destroy(source); g_source_unref(source); --=20 2.7.4