From nobody Wed Feb 11 02:33:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1528498733050302.17023493742545; Fri, 8 Jun 2018 15:58:53 -0700 (PDT) Received: from localhost ([::1]:38399 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRQLH-0006IA-Hx for importer@patchew.org; Fri, 08 Jun 2018 18:58:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fRQJK-0005B0-Kc for qemu-devel@nongnu.org; Fri, 08 Jun 2018 18:56:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fRQJG-0002pT-HX for qemu-devel@nongnu.org; Fri, 08 Jun 2018 18:56:46 -0400 Received: from mail-bl2nam02on0082.outbound.protection.outlook.com ([104.47.38.82]:53152 helo=NAM02-BL2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fRQJG-0002oc-8v for qemu-devel@nongnu.org; Fri, 08 Jun 2018 18:56:42 -0400 Received: from linux-h3ml.amd.com (165.204.77.1) by MW2PR12MB2473.namprd12.prod.outlook.com (2603:10b6:907:9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.14; Fri, 8 Jun 2018 22:56:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wcq9oU64GJ1wYscscWE7pRVTOBZL9MkP7xFtD3MVJY=; b=ThnLgIrTCNxTgI49lgvzImNshbE1p2881KvWcJqRav7RZgyah341jTC8hPyLkHdQGwdM/+n96fkpS8EvoBiTR4ULi9rGzky62k9nzl4uG2XI+4oa9K5qmDuRFHFad3ExwYKCSX6bEL1qbluNAKX13KZifLHOlkyd5EicqkVZpEo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; From: Babu Moger To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Fri, 8 Jun 2018 18:56:18 -0400 Message-Id: <1528498581-131037-3-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1528498581-131037-1-git-send-email-babu.moger@amd.com> References: <1528498581-131037-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0401CA0034.namprd04.prod.outlook.com (2603:10b6:803:2a::20) To MW2PR12MB2473.namprd12.prod.outlook.com (2603:10b6:907:9::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:MW2PR12MB2473; X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2473; 3:Eo4C9Oub5KFvey0LwjLH8kTx5ZVMv7Dp1PxxgwxWM12quq6Blsf9oq7r3pt7N6xszycfv2X0r7EXgwHdEWPp8o0bsDyXXYZOYNgIpuhcZoklxi0oHofyIpjwgvnrPquO2JCfluh62lrJji/dBuJb/J0a/Dtwai7/Ghc7nJkA0BiLbA3i46QWOnE72tEjaapWhbb0jDInX8NsabhH+45OOcePMmRVR2obn1P+o6CaoL4PzXwge6N4ZD8yL1GzuPlA; 25:pyzmvbBPuPhOcuE9RDRiTP3UKL2F7upb0IvmLo+mFuIKyULWxAUez7HkHTPnGsqHIi7naDugQ4AclJRCgLTHoRjqLbvpznF2Y3ZS/gKqoCS/s0q1MxVuod1SDsh+I6kHyM1aLRXzsHAFYBHYjToQJ5b4VftBeX3AlVqXJL+sY4wSPK2jpVz+0llIpNhPbYeanDx/gPpubiO5VoMQX+TRFGc3TRBqT2LpvsYSqJtA3FRKPq8jvhvFfXEuCxCGMFzTR80FRGjPhJyN0qHbl5ZVVHrYPrEmSfV9FszXquT4S9aI7F3SDRm8QHXyy1/TLsFSJ6fZQxazGWJd5KXd7j96Ag==; 31:HPTK+50W7mO7UAlkKua1OuUcPXBAyyGkULYBiUVIOiQfSWlHISR1imINcEY0Vqp3ucFRDf/jYUzbMcM39s5AJU2wDMVY5B8TlEtnCp4rrYhKau6cUhN4JB+MMKdnTGyTTuTRp+YJMHZVOPcYgZmGrl98uqhvofFR8s5ampPjlXNr250BUAKlD9EnHSWWneCJ/vBsdwQwAEEzUnudooW4lrwpXHtxyu//abUOdxOAFnQ= X-MS-TrafficTypeDiagnostic: MW2PR12MB2473: X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2473; 20:wCt2kuvvgbCvq0RWlsgjc9Bnd+BhrFJ3tj/pvXQ+pMat7sePHKlBdzRmf907OKPvvTkIE6BUzoBWTiPpHcp8dW6Ntw/Fxc7XAmu5w7H5LmIyOZJyPrOEj/1cJYGq5dDKduGiOXPcGHBw8KR9oPHU10gAprVhk85va3t6Poaw9ThxlBheujWZ7Ky4me5DzIyDc6WwaHa/bs3pQPoiA21PBMAdvpkkJvoiCt1RTct4GZHDvPIvCoSC8wkY9wuexL2/WM3vIQtcjwDfjfI0xpyBTr2lBSVAeEce2H06unuQAHOSmn7j78muGL6U6Ps4BbtPBkODXe3HsTD44nuyPbvn5vtKArJTFjFG4cEy9F3ZWjjM0DvTPUOvGkhwAfGNqF08i6viZs57i1gV3p14XjYghhWRteLIuwySpDLObONYdeXOoXSO71WZVlQGoxcWrQDaR22elhZ+LkUFSoTnxdwVoYvADW6ahafoR3z7TKgAMWvQ2baD9TN4CbTpQc02cAvm; 4:hF2+hiCOZnM45k/vKG8JzGxfM4UE7+7EcB4pQSB0tTdVng+INB5Cn2O6UjQKudn0pNkwlpNOMdDY640hswZi3r54ItXlaumwYKoH7Hgs9y0fRMHkcF2x2kphJzojgTnhw10I8y8rhy8cApvjInY4HwknBtgXJeqdBLESPS0Ygd39NRi5EEn9ezJKdB1x5cl7exloh6XD/lZMvP+AQo/7vWtexnzHehLvP1f0T2PyUu/Pe+rDuUV5DxLloqCa59CSv1kFPJ3w+n9+uTM6J3nIG1YNSl5KunFRtQgeNGnjRqZnQ1Ps/pHJVRlApOxg3+3BTTDxIezRD25ieHgNOcsupw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(28532068793085)(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231254)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:MW2PR12MB2473; BCL:0; PCL:0; RULEID:; SRVR:MW2PR12MB2473; X-Forefront-PRVS: 06973FFAD3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39380400002)(396003)(39850400004)(366004)(189003)(199004)(956004)(7416002)(305945005)(6666003)(4720700003)(7736002)(53416004)(53936002)(48376002)(26005)(16526019)(105586002)(16586007)(106356001)(386003)(316002)(186003)(7696005)(52116002)(39060400002)(50226002)(51416003)(66066001)(47776003)(50466002)(59450400001)(6306002)(446003)(8676002)(11346002)(8936002)(81166006)(81156014)(76176011)(4326008)(44832011)(486006)(2616005)(36756003)(476003)(25786009)(5660300001)(97736004)(6486002)(3846002)(6116002)(2906002)(86362001)(966005)(478600001)(45080400002)(68736007)(72206003); DIR:OUT; SFP:1101; SCL:1; SRVR:MW2PR12MB2473; H:linux-h3ml.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MW2PR12MB2473; 23:eosNrgOp8Rc23cUzlMo4jkBdPAhIaE9rWE9oGKU2V?= =?us-ascii?Q?V9bYqewAoZhYLtLUCH7yi9TNJIP4Xu4EgQ3tEvfTY3+3uhPyxmuhnvmDmZG7?= =?us-ascii?Q?XNY2yL4gGqvBFmd+49W4pTsHmkDa+STnTFGyVG0gMmnP5sp94mLpGNIJ/t7Q?= =?us-ascii?Q?QpjiBlBjAJ/3KR3giyE8pK/+32Nd61SLobugCnGnlnnzwKdj3uP0ACnAmb/o?= =?us-ascii?Q?lv7QJWkCo8CxsCPZvJXaxJ0Z1j/1yqivgaewciMnbYLawfqN+ssk+M4rqyIU?= =?us-ascii?Q?YFZWwuGGMAT11LMlqPru+0WhG+9F/IzCf7bYecajCWF01PDMjBRris2iKq/W?= =?us-ascii?Q?bWsUzVa3r+QJwox+3WMy/4ZGFYmJusIVUx9PHip4vsNJATl4pnv+osN4+jXV?= =?us-ascii?Q?Q7x/WxUsmpe7Z0KK7wq5Ch9/fOxc8+MQInsFZmNq/jOp9QFiqoIRJdVUONS9?= =?us-ascii?Q?3KPRJIOhM61Z/4v/FNSm4v2QPmFujNvMElAcKJrbULmaCns2TJZj/WHSh46V?= =?us-ascii?Q?ZvAI1FI3Evmi3RlhVQVjbQAokNGEEPZx+TanifVUUg5PDqFMuLhtdSzuIGCd?= =?us-ascii?Q?ClVyXmSZMy1FGNWdz/9FYMWLt0Vk2eOI+fjMyBfDDevMh4FKqTIzDQE4t7GZ?= =?us-ascii?Q?arLbPFT9m87P2c1tszZyq29tClMWPKOyILvSui7MPPWyk4bC5b5pZ9kI/8MO?= =?us-ascii?Q?NuYE1k44A3LgWb+T/2dmjUh8wGlVPwvDlqKkcbLoGMGi4oA/cuznEhLBO2gY?= =?us-ascii?Q?70mgH9p0D3GD0+qRFOKSQpEugaKZ48DtobZv+4KmjZJwUxagzWr7bOpGY9r8?= =?us-ascii?Q?mB1dgYfp8gjJc8DrwHBGZeYHoH4ZCUCcYnLM+jj8n0GJHwM/rweW1mfKfJ3w?= =?us-ascii?Q?9eJlZuhZW3yzh1GvKsdLrz24RMJzYJefXUYD1kHhjVhvKi2BkeE8b3owRKdS?= =?us-ascii?Q?ITTXk48kDgxUEETGarMxgquaJYfqlBgw4vJ8nJwAGg1dvjvIkv4+i4DP5/ox?= =?us-ascii?Q?p3IAddrkXErqaFFCZ285VOnt8QsR/eT7KG0om5UGHSkFAeuP4hztw6T/e0Eo?= =?us-ascii?Q?oEzqaDuc9MpNNcQV/K1+dEwc6Lblw3wdMzlaBKp4rpV+LfKYp91DOVi8WlaK?= =?us-ascii?Q?/iW3+2EexgV0pmZ2fVLNoeqSnb+KZjxwBDL5VI6FLz0g9sRb1RnJKoZ9sCmt?= =?us-ascii?Q?xhqIb/7XFAkjy5LSRa0athn9TifUSlyOQHLRHothyTFmtsLVX4evFWEt5sSE?= =?us-ascii?Q?pqIWMYIRPgCDIQ29PvXDYVKNOXP3tIgmQ9RONIewLWUu3udlcT5rpm/gcOM/?= =?us-ascii?Q?XlF9TqCdNpfdxfuVRjajfU951X3ItKIqsEUlgSBCEveKpAkBdE3GpJqsVC53?= =?us-ascii?Q?inbIQ=3D=3D?= X-Microsoft-Antispam-Message-Info: Yt7PRjb5z/iEFd3H0wVkwVjbwQsRz7AzRmaM1TwCleAyT6rzGEK3nYizo/Re+lGAm5aMwG4cFh/EessYal8uqa1Y7it4OWR457b4F6cBNu8jyIgU0SlzeCfLxa1r/6qgv1v5sdMHCLNJSMdwh7lx5ZJPicbFUQIBZNhreotzz4H47QsU+47I+yemlWcs17Yv X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2473; 6:0+fiV6nMJGcW1pu51fjxX9ubJx+X1lZkwq7FTHo+/YKj+NPBwD7bSK+CXoKVJKZKayP0Re1dRHi/8YK71hFlhr3KX4YTrh4J2WphyTs48ITOSlXDI4S/DumJ7eHRvAa+hHG2X4KMEiBF39zVGJfQYMaoOTl9cDsfwXTlWt8elG3DAn1MnqwAILJuDnwfZlPukhSCcfmRx40/l02lQezqu1DPwuI/fqUpy14OUDZ8joHoPmbkKv7Xq97UYNTBTLnsExyd2R/+ydFwB5y+Ecf2CTI5wxWVoL2nmsMTlb3/eL2NEN4e94iqHjgzumNnpWG7YEJOX8+XF6GApBDg7F4dI6+I1V3KdyuXucBNaFa1hL9Ymlg7RosyUdcbQ25Z3oZeZt8RgrQ9ydmzhw4u335JDyMWqr5m0o5qSLIpoxCj2lnXRaw446Tafcm8t+xJ4FIorTAn615ai/d/YvykcP94OQ==; 5:0/Mhl421x0oJyuQcLQh/DG71slqBqOogIjoTUbRhoBtGiRZswSR3BJbm5F1UdjmDMXdR0l4lgp3hs6iCXAv//I0Kuz2JK7ojS+/wcDDU3c0iR9DzIs6Erp7QKXVChCs4cOz5UVD/PpefF7N+Y7XAATY6o1E5dKYjctKeQkZMgOw=; 24:1v4bu7lWGBWFtPnz91zSQZQxTgx4COvQBIqTHen4TKJbUczlo2XZ0q3qekziY1fGS+SnysP/Qav3NhcEgEA3xc92Mu6ZZ0xih/rGJu0I11A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2473; 7:mtWQpNibWksMX4xRqaZHJEvpstsD63f8r6WDO7TCISiyOGHMl2cRyvN8N7mI0ARkrs3wjkfrWximzmSXx4sUwc85LUkjG/WPw7kiZrhjUDh+QSQz8utSxU/nGrxSBIIrSpB581qKW53vh+g6Xa2CQj9YbdqpsScmScNhzveKsOOut7oGKyfBdXLbyxgRjb5c5/Uzj5IaVgm44pF/bM3rtaoI7ThvLkj6sIzuRC6+w9kCBdDb+IVQsHyVH1aYqrpX; 20:0OLFDKwvilUH6DpPfKwCZPbmcvUYaaVm+lku2gLd5AlbRxlY9w+H3Q0NSSyAWp0QSPHFbS56I3zwxlU/Ar9jRnWqm9KKOleDLHCmbTqGtw/hEWlpaGQrx8lKNi3jmu0TiLU8PFgQjxTjo6fqTqwauuzN5JBNnr+1NaArFZfv+bJ8XsMACJfLlHAGPusZpBSf+rIltF+MLgTclPrlhWebySlyzseYnI0TKWl3pF8lp2bNtSBBb4GACb/trywMAJTE X-MS-Office365-Filtering-Correlation-Id: e248b887-4e48-467b-90bd-08d5cd9318ac X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2018 22:56:39.1135 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e248b887-4e48-467b-90bd-08d5cd9318ac X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2473 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.38.82 Subject: [Qemu-devel] [PATCH v13 2/5] i386: Introduce auto_topoext bit to manage topoext X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce the auto_topoext bit to to control topoext feature. Also add new field auto_topoext(in X86CPUDefinition). This will be used to enable topoext on newer CPU models where topoext can be supported. Signed-off-by: Babu Moger --- include/hw/i386/pc.h | 4 ++++ target/i386/cpu.c | 12 ++++++++++++ target/i386/cpu.h | 5 +++++ 3 files changed, 21 insertions(+) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 04d1f8c..cc30ec3 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -303,6 +303,10 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_= t *); .driver =3D TYPE_X86_CPU,\ .property =3D "legacy-cache",\ .value =3D "on",\ + },{\ + .driver =3D TYPE_X86_CPU,\ + .property =3D "auto-topoext",\ + .value =3D "off",\ }, =20 #define PC_COMPAT_2_11 \ diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 86fb1a4..d3411ed 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -1283,6 +1283,8 @@ struct X86CPUDefinition { FeatureWordArray features; const char *model_id; CPUCaches *cache_info; + /* Set it if topoext can be enabled in CPU models */ + int auto_topoext; }; =20 static CPUCaches epyc_cache_info =3D { @@ -3517,6 +3519,9 @@ static void x86_cpu_load_def(X86CPU *cpu, X86CPUDefin= ition *def, Error **errp) /* legacy-cache defaults to 'off' if CPU model provides cache info */ cpu->legacy_cache =3D !def->cache_info; =20 + /* Set auto_topoext if both machine property and CPU model supports it= */ + cpu->auto_topoext =3D cpu->auto_topoext & def->auto_topoext; + /* Special cases not set in the X86CPUDefinition structs: */ /* TODO: in-kernel irqchip for hvf */ if (kvm_enabled()) { @@ -5382,6 +5387,13 @@ static Property x86_cpu_properties[] =3D { DEFINE_PROP_BOOL("legacy-cache", X86CPU, legacy_cache, true), =20 /* + * auto-topoext property will be used to enable topoext feature. + * This will be disabled on all the older CPU models. Will be + * enabled on newer CPU modeles which can support topology extention. + */ + DEFINE_PROP_BOOL("auto-topoext", X86CPU, auto_topoext, false), + + /* * From "Requirements for Implementing the Microsoft * Hypervisor Interface": * https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/= reference/tlfs diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 89c82be..8783d36 100644 --- a/target/i386/cpu.h +++ b/target/i386/cpu.h @@ -1409,6 +1409,11 @@ struct X86CPU { */ bool legacy_cache; =20 + /* Compatibility bits to enable topoext feature on all newer machines + * Disabled on older machines. Enabled on newer CPU models + */ + bool auto_topoext; + /* Compatibility bits for old machine types: */ bool enable_cpuid_0xb; =20 --=20 1.8.3.1