From nobody Mon Feb 9 18:44:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1527028369595324.71821562140974; Tue, 22 May 2018 15:32:49 -0700 (PDT) Received: from localhost ([::1]:58231 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLFpi-0007AA-Iy for importer@patchew.org; Tue, 22 May 2018 18:32:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fLFkB-0003In-TU for qemu-devel@nongnu.org; Tue, 22 May 2018 18:27:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fLFk6-00071z-Va for qemu-devel@nongnu.org; Tue, 22 May 2018 18:26:59 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41801) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fLFk6-00071W-Qa for qemu-devel@nongnu.org; Tue, 22 May 2018 18:26:54 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5366221C27; Tue, 22 May 2018 18:26:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 22 May 2018 18:26:54 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 7734A10261; Tue, 22 May 2018 18:26:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=afmrT7iPdkjIOC 7eH4Ou1jJwsSUF+keWsyG6PO+5fxY=; b=B1Qnz+wPk4l/c/HQG7cJ5o23N7EDny LTWEgHouoZVHz/i8n0hvRQPKjUu6hMrCZJ+9IwvDrRKNR61eUAWkIb2e2GZSdbJ+ 2gT9IHO1J9llHJbInRCzfXUpTpuSmQpjIYmEQUjoeEz14H6wSEf6/PBKv7bkP6UG q7w0Kb5oEY7kE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=afmrT7iPdkjIOC7eH4Ou1jJwsSUF+keWsyG6PO+5fxY=; b=OzNYOXsf PuTvs39jkPmBcyS4+5dEa97H+uClfSn4Q/Bu94BRQd50XPWYY4ARpE1vLyq3VVoI FGJ+rtAo/THGaRlI5vnVwaaT/9mciGQ0E9Yq09w0NFtsRIGQkwfAVC3NbyBYlEAg gjjfAFh7JZ9Kng/QXrEihhLc+qziBnAs/nsqnjNXycWizA2+4t9QZFh1ig1980j1 6kD9RwA+owchVpeJAqiibS8FgqPxtXPE0/A28fEgGwH9NuLv7kQV97bh40FQK5aP om6/JT/u9EcFGNOxmSDbCUqTTR227T/+sCkJxQFk0+BlaMINuC6n/2zaHXq3Q7tw O5N5r12kPXmeJw== X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 22 May 2018 18:26:48 -0400 Message-Id: <1527028012-21888-2-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1527028012-21888-1-git-send-email-cota@braap.org> References: <1527028012-21888-1-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.27 Subject: [Qemu-devel] [PATCH 1/5] trace: fix misreporting of TCG access sizes for user-space X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Richard Henderson , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" trace_mem_build_info expects a size_shift for its first argument. Fix it. Signed-off-by: Emilio G. Cota --- include/exec/cpu_ldst_useronly_template.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/include/exec/cpu_ldst_useronly_template.h b/include/exec/cpu_l= dst_useronly_template.h index c168f31..e30e58e 100644 --- a/include/exec/cpu_ldst_useronly_template.h +++ b/include/exec/cpu_ldst_useronly_template.h @@ -33,20 +33,24 @@ #define SUFFIX q #define USUFFIX q #define DATA_TYPE uint64_t +#define SHIFT 3 #elif DATA_SIZE =3D=3D 4 #define SUFFIX l #define USUFFIX l #define DATA_TYPE uint32_t +#define SHIFT 2 #elif DATA_SIZE =3D=3D 2 #define SUFFIX w #define USUFFIX uw #define DATA_TYPE uint16_t #define DATA_STYPE int16_t +#define SHIFT 1 #elif DATA_SIZE =3D=3D 1 #define SUFFIX b #define USUFFIX ub #define DATA_TYPE uint8_t #define DATA_STYPE int8_t +#define SHIFT 0 #else #error unsupported data size #endif @@ -63,7 +67,7 @@ glue(glue(cpu_ld, USUFFIX), MEMSUFFIX)(CPUArchState *env,= target_ulong ptr) #if !defined(CODE_ACCESS) trace_guest_mem_before_exec( ENV_GET_CPU(env), ptr, - trace_mem_build_info(DATA_SIZE, false, MO_TE, false)); + trace_mem_build_info(SHIFT, false, MO_TE, false)); #endif return glue(glue(ld, USUFFIX), _p)(g2h(ptr)); } @@ -87,7 +91,7 @@ glue(glue(cpu_lds, SUFFIX), MEMSUFFIX)(CPUArchState *env,= target_ulong ptr) #if !defined(CODE_ACCESS) trace_guest_mem_before_exec( ENV_GET_CPU(env), ptr, - trace_mem_build_info(DATA_SIZE, true, MO_TE, false)); + trace_mem_build_info(SHIFT, true, MO_TE, false)); #endif return glue(glue(lds, SUFFIX), _p)(g2h(ptr)); } @@ -113,7 +117,7 @@ glue(glue(cpu_st, SUFFIX), MEMSUFFIX)(CPUArchState *env= , target_ulong ptr, #if !defined(CODE_ACCESS) trace_guest_mem_before_exec( ENV_GET_CPU(env), ptr, - trace_mem_build_info(DATA_SIZE, false, MO_TE, true)); + trace_mem_build_info(SHIFT, false, MO_TE, true)); #endif glue(glue(st, SUFFIX), _p)(g2h(ptr), v); } @@ -136,3 +140,4 @@ glue(glue(glue(cpu_st, SUFFIX), MEMSUFFIX), _ra)(CPUArc= hState *env, #undef SUFFIX #undef USUFFIX #undef DATA_SIZE +#undef SHIFT --=20 2.7.4