From nobody Sat Nov 1 07:21:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1526280411931665.1533080128355; Sun, 13 May 2018 23:46:51 -0700 (PDT) Received: from localhost ([::1]:44043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fI7Fy-0001iM-VV for importer@patchew.org; Mon, 14 May 2018 02:46:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47370) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fI6e7-0006dK-9B for qemu-devel@nongnu.org; Mon, 14 May 2018 02:07:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fI46T-00008p-S4 for qemu-devel@nongnu.org; Sun, 13 May 2018 23:24:53 -0400 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]:36132) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fI46T-00007R-MY for qemu-devel@nongnu.org; Sun, 13 May 2018 23:24:49 -0400 Received: by mail-pl0-x243.google.com with SMTP id v24-v6so6521943plo.3 for ; Sun, 13 May 2018 20:24:49 -0700 (PDT) Received: from localhost.localdomain (109.227.199.104.bc.googleusercontent.com. [104.199.227.109]) by smtp.gmail.com with ESMTPSA id p6-v6sm17183532pfg.157.2018.05.13.20.24.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 13 May 2018 20:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IH1bphaxcG2LjizEZBLNyCH28G/Lq2miAkn26IAeS2k=; b=nOu9gd51rRQ1aYwlLGYDUREmL4E/SXvEwtN94yn9wdazJHZNjtaevT6Pe3INaRfTcm PUtumi3cz7VXDYb6IWhywmv8lFJCzhZuYuLZrf6OvnKI9okv/2KzqQLxf0PLlw+Quwoz D55fQKLqhdmpBy8DDAx9oDt1z7M10D/yam4jsBGrgpldtSdNlZJNHrOrq/eC/DCPtiUa zmi1hw0R1/gRHvW3VxAjy1omSno9aaSvlkpSzpcCRiUZXaTVa3dUuaM5uX9MdHja88ii 5m1oUynHhRdGY2ZQwoXcBYcZHaMyDGCk9URA8oc3NORMoiJIYRVZQyWeMhePrWiNE2Cy wN2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IH1bphaxcG2LjizEZBLNyCH28G/Lq2miAkn26IAeS2k=; b=M8x2V0h/DeLPEpw4D1jQ9L1pjsuw9foVKrRy8s1bjrJz83i8X9v/e8DwG3D8Z2TRqy agTb4LO3xNpR/TVfCDB1884Q48umR5lk1gUUh6yqxNwNcdSxap8SCPD4yWFkydWj0LJ2 FdZah3gKvf3LDzH3NwR9oIyeyQuoF8wEPsNRMFhiqhz+cc6QuWBvwsLI+zL9CfJr5p3V S+uT2DBJM5M4rbA4nXYG0OhlAAhgdfsarv2laAw4xO9jIdFJofMZK+KdJc0JkVakAetJ 4JNVfermyNAcucOROOvnYBA6Vg2zTfno20GxWAWTc+fNO2SzsN+vC5uKLYV5HDNMP25B epWQ== X-Gm-Message-State: ALKqPwdyPQi6koVa0e7hqXj5XcLtsFddmu/3R94D6A+/WHOBivfsc+dh izGzRwY6HNmpy7D1gEn5PGaURg== X-Google-Smtp-Source: AB8JxZpFlLf2htTQ6YxGNRtT+PvBalrwu2T5M6KfP0+tNMZHOefr66a3NZjNZZNuV6JLWinOFo5APw== X-Received: by 2002:a17:902:bc49:: with SMTP id t9-v6mr8078951plz.109.1526268288498; Sun, 13 May 2018 20:24:48 -0700 (PDT) From: Zhang Chen To: qemu-devel@nongnu.org Date: Mon, 14 May 2018 11:23:39 +0800 Message-Id: <1526268228-27951-9-git-send-email-zhangckid@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1526268228-27951-1-git-send-email-zhangckid@gmail.com> References: <1526268228-27951-1-git-send-email-zhangckid@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::243 Subject: [Qemu-devel] [PATCH V7 08/17] ram/COLO: Record the dirty pages that SVM received X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhanghailiang , Jason Wang , Markus Armbruster , "Dr . David Alan Gilbert" , Zhang Chen , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We record the address of the dirty pages that received, it will help flushing pages that cached into SVM. Here, it is a trick, we record dirty pages by re-using migration dirty bitmap. In the later patch, we will start the dirty log for SVM, just like migration, in this way, we can record both the dirty pages caused by PVM and SVM, we only flush those dirty pages from RAM cache while do checkpoint. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index 7ca845f..e35dfee 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2531,6 +2531,15 @@ static inline void *colo_cache_from_block_offset(RAM= Block *block, __func__, block->idstr); return NULL; } + + /* + * During colo checkpoint, we need bitmap of these migrated pages. + * It help us to decide which pages in ram cache should be flushed + * into VM's RAM later. + */ + if (!test_and_set_bit(offset >> TARGET_PAGE_BITS, block->bmap)) { + ram_state->migration_dirty_pages++; + } return block->colo_cache + offset; } =20 @@ -2760,6 +2769,24 @@ int colo_init_ram_cache(void) } } rcu_read_unlock(); + /* + * Record the dirty pages that sent by PVM, we use this dirty bitmap to= gether + * with to decide which page in cache should be flushed into SVM's RAM.= Here + * we use the same name 'ram_bitmap' as for migration. + */ + if (ram_bytes_total()) { + RAMBlock *block; + + QLIST_FOREACH_RCU(block, &ram_list.blocks, next) { + unsigned long pages =3D block->max_length >> TARGET_PAGE_BITS; + + block->bmap =3D bitmap_new(pages); + bitmap_set(block->bmap, 0, pages); + } + } + ram_state =3D g_new0(RAMState, 1); + ram_state->migration_dirty_pages =3D 0; + return 0; =20 out_locked: @@ -2779,6 +2806,10 @@ void colo_release_ram_cache(void) { RAMBlock *block; =20 + QLIST_FOREACH_RCU(block, &ram_list.blocks, next) { + g_free(block->bmap); + block->bmap =3D NULL; + } rcu_read_lock(); QLIST_FOREACH_RCU(block, &ram_list.blocks, next) { if (block->colo_cache) { @@ -2787,6 +2818,8 @@ void colo_release_ram_cache(void) } } rcu_read_unlock(); + g_free(ram_state); + ram_state =3D NULL; } =20 /** --=20 2.7.4