From nobody Thu Oct 30 15:21:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1525735125283170.8610091924985; Mon, 7 May 2018 16:18:45 -0700 (PDT) Received: from localhost ([::1]:48504 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFpOy-0000mt-97 for importer@patchew.org; Mon, 07 May 2018 19:18:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFpMz-0008Aa-8M for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFpMy-0006qv-Cs for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:37 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:37500) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFpMy-0006pu-6s for qemu-devel@nongnu.org; Mon, 07 May 2018 19:16:36 -0400 Received: by mail-pg0-x244.google.com with SMTP id a13-v6so20315976pgu.4 for ; Mon, 07 May 2018 16:16:36 -0700 (PDT) Received: from localhost.localdomain (122-58-167-38-fibre.bb.spark.co.nz. [122.58.167.38]) by smtp.gmail.com with ESMTPSA id q64sm42659569pfg.180.2018.05.07.16.16.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 May 2018 16:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+K2jQ3Rp/bNYQPXaJWnWfc1pAr09kFhcGdRAX1d+hcw=; b=VaCE3p9QXHykk8BY6xAHQ5SxRvIaPBkzO9eSUrhyJ2mQXab9DCrGFMyLUBxurtODDz bIYe66PNuDVYGPAz6DfFAoAph/L3FT/TjjKfCuaj4M5tf4p8XWxGMC6E6g3t10/Hgrc3 FoFzGqJBv3orUSR6kEwtHFCWDBTT2ExUU80J4Q4XXC+TbmffNzfqEf/Ur1e+MTpZGK8U RhKGrGzyg2sGvYc6CPZSA8WK75rNKkEPNrY2iDelGNJNqCkIPLGKKvZ+ekWqBl33kqGJ OVvXkglIn+8TVhQa5/2qrvCw0/gCIlT/S/3xLYkDGvsQgisUw6MOVDiHvZlaxKi+0ZmY OJpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+K2jQ3Rp/bNYQPXaJWnWfc1pAr09kFhcGdRAX1d+hcw=; b=jB5cn90bmUY7/bM66VzkuEbi17Rfahvsj2+9Xv263mByJ3etPrMROJzSzAxI7+0JTm NawntFq55Wdi9paHHaFzGYAfX//J4z7mKCUdxcATBKSYzUYxWLLhBfchAABgt+iNuGF+ CRN11sXwLTRq39LwP/01Js5KcMqA4exxGcB2OVMSVrycMx9L9nao7iUbjb6cmg9Km2Lj oBB1PWPcLjxCJmrNbAkVmS5U8vS3JbDH984DOlF5UTPTVECJF47hRFBCRqqAizeAvshh AXsHIovunChitICkKFhXDy71u5G9PEStDFUEPm3hcgORyH2/ZYhndqox4/SUX0FCcrqx yJQQ== X-Gm-Message-State: ALQs6tBl2rnS3b2ZkHrx3Y2taMae/+/OlsYy/NGmXoyiM1/kc/zFXkBo 7y7P+upJ3HG4cz3CFpQ7upGXE4oUGdM= X-Google-Smtp-Source: AB8JxZozzPm0ZUgP5F0NB90WNatu37sb1STRXUyaIjkxK0kIBhGNKLauT8dJeVpI5Kfh329OkHTTwQ== X-Received: by 10.167.134.20 with SMTP id p20mr37810406pfn.159.1525734995267; Mon, 07 May 2018 16:16:35 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Tue, 8 May 2018 11:14:52 +1200 Message-Id: <1525734893-10299-3-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1525734893-10299-1-git-send-email-mjc@sifive.com> References: <1525734893-10299-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PULL 2/3] riscv: htif: increase the priority of the htif subregion X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, KONRAD Frederic Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: KONRAD Frederic The htif device is supposed to be mapped over an other subregion. So increa= se its priority to one to avoid any conflict. Here is the output of info mtree: Before: (qemu) info mtree address-space: memory 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 0, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram address-space: I/O 0000000000000000-000000000000ffff (prio 0, i/o): io address-space: cpu-memory-0 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 0, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram After: (qemu) info mtree address-space: memory 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 1, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram address-space: I/O 0000000000000000-000000000000ffff (prio 0, i/o): io address-space: cpu-memory-0 0000000000000000-ffffffffffffffff (prio 0, i/o): system 0000000000000000-000000000000000f (prio 1, i/o): riscv.htif.uart 0000000000000000-0000000000011fff (prio 0, ram): riscv.spike.bootrom 0000000002000000-000000000200ffff (prio 0, i/o): riscv.sifive.clint 0000000080000000-0000000087ffffff (prio 0, ram): riscv.spike.ram Reviewed-by: Michael Clark Signed-off-by: KONRAD Frederic Message-Id: <1525360636-18229-3-git-send-email-frederic.konrad@adacore.com> --- hw/riscv/riscv_htif.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/riscv_htif.c b/hw/riscv/riscv_htif.c index be252ec8cce9..f73512941fb6 100644 --- a/hw/riscv/riscv_htif.c +++ b/hw/riscv/riscv_htif.c @@ -253,8 +253,9 @@ HTIFState *htif_mm_init(MemoryRegion *address_space, Me= moryRegion *main_mem, htif_be_change, s, NULL, true); if (address_symbol_set =3D=3D 3) { memory_region_init_io(&s->mmio, NULL, &htif_mm_ops, s, - TYPE_HTIF_UART, size); - memory_region_add_subregion(address_space, base, &s->mmio); + TYPE_HTIF_UART, size); + memory_region_add_subregion_overlap(address_space, base, + &s->mmio, 1); } =20 return s; --=20 2.7.0