From nobody Wed Oct 29 17:30:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524667664855606.7842577836855; Wed, 25 Apr 2018 07:47:44 -0700 (PDT) Received: from localhost ([::1]:37385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBLhq-0000rB-09 for importer@patchew.org; Wed, 25 Apr 2018 10:47:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBLXf-0000he-Fz for qemu-devel@nongnu.org; Wed, 25 Apr 2018 10:37:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBLXe-0008BG-Ii for qemu-devel@nongnu.org; Wed, 25 Apr 2018 10:37:07 -0400 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]:43569) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBLXe-0008Al-DT for qemu-devel@nongnu.org; Wed, 25 Apr 2018 10:37:06 -0400 Received: by mail-pf0-x241.google.com with SMTP id j11so15393712pff.10 for ; Wed, 25 Apr 2018 07:37:06 -0700 (PDT) Received: from VM_127_91_centos.localdomain ([119.28.195.137]) by smtp.gmail.com with ESMTPSA id y29sm18244004pff.42.2018.04.25.07.37.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Apr 2018 07:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PwHP1AzcBwZHKc6SCBOYyzB9IuaEtpVaqkyyam+SpBo=; b=cDZKMqRSLVny/MLjXVB3LcI8MwQYrxCeI71w2hzB84zWDK0M/friF0mntMTz/Q1o6b 5fTgVfDsV/oBmSN9noD/jsWvbCBBMQh4vECQNcI4sAZsaQourrKK5kn9D3elPKqjj96d 07jfkPjPTbIcDUgomy2Pjfz2vMTHvo21uw9BmUea/mUIVi23oMr1sq6ASPYSGlX6YSff MPwMZcmt2zb1113DpMRsUjX3SaB294WTX6a/YUwDlYnuucKvCJW1dssOE1mRutyV3FOD U6fYs+V32LTW53rg+vJ90yYSzirU7mB57Osw3na30WzFqhy7vFrvofuXSdAifojfmcWl e4gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PwHP1AzcBwZHKc6SCBOYyzB9IuaEtpVaqkyyam+SpBo=; b=nl/L7hJjuAHyriI53Qodc0cmniLUA6UlpAd1D1b5IR5cxMr/Uke5y9klzW0Ts7jnfo Ocqrs0d0/NNMP/5TOIccpkUQC/4uEze5Qb/6qPvkVLEuxTmtLdDUrlNtU6sArXjHxOgf GptXDZkubg5ganMn3xl/ive3mgtQpfCUKx7SFg4tn6KSf/flaay4pgH8851Rt/euEu2T oZ703iyIt7qcJOQOi3SrEZ5oGG5bQ+cXtgNy7ZVQCOrezigtTVbiXT7ixl87Opyp3nuV d48tEHmy6hqtayDJCkEN40D/R7bTmJF+TF+TGBetdOOzc3L2ZdPf3HeTXYbaUOo1yUVp hhRA== X-Gm-Message-State: ALQs6tCUUlWyTMBFm/7jZX8Xe7r/duS8LWqtyRuVJfKD/OOKaXlI8w7t X1dzYAVsS0fzIrHm2d/lp6Q= X-Google-Smtp-Source: AIpwx48cRsKrUWjKBfXwucIsbO/S7zuVHRUalRhWmKklkpuVNTsObq9QDNelkaAfmkRZsreQXWYG7g== X-Received: by 10.99.163.77 with SMTP id v13mr19614133pgn.224.1524667025564; Wed, 25 Apr 2018 07:37:05 -0700 (PDT) From: Lidong Chen X-Google-Original-From: Lidong Chen To: quintela@redhat.com, dgilbert@redhat.com Date: Wed, 25 Apr 2018 22:35:34 +0800 Message-Id: <1524666934-8064-6-git-send-email-lidongchen@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1524666934-8064-1-git-send-email-lidongchen@tencent.com> References: <1524666934-8064-1-git-send-email-lidongchen@tencent.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::241 Subject: [Qemu-devel] [PATCH v2 5/5] migration: Stop rdma yielding during incoming postcopy X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: galsha@mellanox.com, adido@mellanox.com, aviadye@mellanox.com, qemu-devel@nongnu.org, licq@mellanox.com, Lidong Chen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" During incoming postcopy, the destination qemu will invoke qemu_rdma_wait_comp_channel in a seprate thread. So does not use rdma yield, and poll the completion channel fd instead. Signed-off-by: Lidong Chen Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0652224..4ba9fe2 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -1490,11 +1490,13 @@ static int qemu_rdma_wait_comp_channel(RDMAContext = *rdma) * Coroutine doesn't start until migration_fd_process_incoming() * so don't yield unless we know we're running inside of a coroutine. */ - if (rdma->migration_started_on_destination) { + if (rdma->migration_started_on_destination && + migration_incoming_get_current()->state =3D=3D MIGRATION_STATUS_AC= TIVE) { yield_until_fd_readable(rdma->comp_channel->fd); } else { /* This is the source side, we're in a separate thread * or destination prior to migration_fd_process_incoming() + * after postcopy, the destination also in a seprate thread. * we can't yield; so we have to poll the fd. * But we need to be able to handle 'cancel' or an error * without hanging forever. --=20 1.8.3.1