From nobody Wed Oct 29 06:43:42 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1524648135009283.766978731839; Wed, 25 Apr 2018 02:22:15 -0700 (PDT) Received: from localhost ([::1]:35370 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBGcw-000558-48 for importer@patchew.org; Wed, 25 Apr 2018 05:22:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35223) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBGbg-0004UR-3Y for qemu-devel@nongnu.org; Wed, 25 Apr 2018 05:20:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBGbb-0000HG-P2 for qemu-devel@nongnu.org; Wed, 25 Apr 2018 05:20:56 -0400 Received: from mail-oi0-x242.google.com ([2607:f8b0:4003:c06::242]:42743) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBGbb-0000GH-KD for qemu-devel@nongnu.org; Wed, 25 Apr 2018 05:20:51 -0400 Received: by mail-oi0-x242.google.com with SMTP id t27-v6so20242756oij.9 for ; Wed, 25 Apr 2018 02:20:50 -0700 (PDT) Received: from fma-X550VB.ipads-lab.se.sjtu.edu.cn ([172.111.136.123]) by smtp.gmail.com with ESMTPSA id t123-v6sm9783122oie.41.2018.04.25.02.20.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Apr 2018 02:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=XJGojOXBNtJMsvXiphahzteSD45Ii9b8J7saimITboQ=; b=ThXFONtBdrzRMF8EQv6+yyvrDMUS1yxhHqpmX8In1w4aKAYY7jX7DKAJ0djDW2V9GC 2O1AUPg0+kMf9yhNQ3V336+t5mREcoEzvXlpDPNbKqvg+BhF2SsFS7krYkk2S8m0PNhp O+qrcnjMtzwdsdmU4PCp0TkVOZmdNQNE0fVa51ZEP34z0nfvNg5JsB81wb6UF5zSw7mb shRGsR1n0bzmnBn/eYPtczn8ZRKCddcFFKlDtylrTukMNuWbNHJcOivG8+srOD0UhjMg KHzXDZIqLmvP87VByhtCf0LIac0/wlmtY/FwviHwtYcAXYw33Hc5+nJHklU03Woa3ZaS M84A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XJGojOXBNtJMsvXiphahzteSD45Ii9b8J7saimITboQ=; b=UCBB2srUfScidyIrQsfs1gxLprL3Yte3Gj9yG6ptwsNeNAWRfHUEiM4+uG6zNItRG8 MlS3p3xEytCEgcAbhDB2ZVpMXrzXOFjjpsgOqtiqDSpvhHHBQkUyBMvTdP48gJe2b840 h7dNE5rfFWcC3yLapn5ni7BsEd98ZV8coNN+LjE4a2heG+DBN2yhN4r4+uun947PLYt6 KjiYA4OB68WpTd9k/kcw3tMAABoALgb5Gpp5pH8lqDxsDxON4YHVfBbvUQQuHGe6ac10 PkviWfZa1Tb/ZCOm6vBvA55O5m5zPsMJwF81LlgexP1/RGZCJYs87wS5Odpv3F4KskDK KacQ== X-Gm-Message-State: ALQs6tBZWBCurrrGPVv54o+24o0I66KbH89XhwZJvlEfZpsPz8hCL3L0 hE0sCUKBKSoIUqqY9mFCIloa2Q== X-Google-Smtp-Source: AIpwx4931IndER8RNJYP3THUIrcIv2frzc1rMecsJi1gAsJfHWbe50OlBzx8X51LDamEsiL39Q7IVA== X-Received: by 2002:aca:1c9:: with SMTP id 192-v6mr17663449oib.175.1524648049356; Wed, 25 Apr 2018 02:20:49 -0700 (PDT) From: Zihan Yang To: qemu-devel@nongnu.org Date: Wed, 25 Apr 2018 17:20:37 +0800 Message-Id: <1524648037-5010-1-git-send-email-whois.zihan.yang@gmail.com> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::242 Subject: [Qemu-devel] [PATCH] hw/pci-host/q35: Replace hardcoded value with macro X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zihan Yang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Currently part of mch_realize uses hardcoded value when initializing smram regions. Use macro to be more clear to code readers Signed-off-by: Zihan Yang --- hw/pci-host/q35.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index a36a119..49e4be4 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -535,13 +535,13 @@ static void mch_realize(PCIDevice *d, Error **errp) =20 /* if *disabled* show SMRAM to all CPUs */ memory_region_init_alias(&mch->smram_region, OBJECT(mch), "smram-regio= n", - mch->pci_address_space, 0xa0000, 0x20000); - memory_region_add_subregion_overlap(mch->system_memory, 0xa0000, + mch->pci_address_space, MCH_HOST_BRIDGE_SMRAM= _C_BASE, MCH_HOST_BRIDGE_SMRAM_C_SIZE); + memory_region_add_subregion_overlap(mch->system_memory, MCH_HOST_BRIDG= E_SMRAM_C_BASE, &mch->smram_region, 1); memory_region_set_enabled(&mch->smram_region, true); =20 memory_region_init_alias(&mch->open_high_smram, OBJECT(mch), "smram-op= en-high", - mch->ram_memory, 0xa0000, 0x20000); + mch->ram_memory, MCH_HOST_BRIDGE_SMRAM_C_BASE= , MCH_HOST_BRIDGE_SMRAM_C_SIZE); memory_region_add_subregion_overlap(mch->system_memory, 0xfeda0000, &mch->open_high_smram, 1); memory_region_set_enabled(&mch->open_high_smram, false); @@ -550,11 +550,11 @@ static void mch_realize(PCIDevice *d, Error **errp) memory_region_init(&mch->smram, OBJECT(mch), "smram", 1ull << 32); memory_region_set_enabled(&mch->smram, true); memory_region_init_alias(&mch->low_smram, OBJECT(mch), "smram-low", - mch->ram_memory, 0xa0000, 0x20000); + mch->ram_memory, MCH_HOST_BRIDGE_SMRAM_C_BASE= , 0x20000); memory_region_set_enabled(&mch->low_smram, true); - memory_region_add_subregion(&mch->smram, 0xa0000, &mch->low_smram); + memory_region_add_subregion(&mch->smram, MCH_HOST_BRIDGE_SMRAM_C_BASE,= &mch->low_smram); memory_region_init_alias(&mch->high_smram, OBJECT(mch), "smram-high", - mch->ram_memory, 0xa0000, 0x20000); + mch->ram_memory, MCH_HOST_BRIDGE_SMRAM_C_BASE= , MCH_HOST_BRIDGE_SMRAM_C_SIZE); memory_region_set_enabled(&mch->high_smram, true); memory_region_add_subregion(&mch->smram, 0xfeda0000, &mch->high_smram); =20 --=20 2.7.4