[Qemu-devel] [PATCH v3 0/4] Small fixes for s390x QEMU boot menu

Collin Walling posted 4 patches 23 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1523897770-30155-1-git-send-email-walling@linux.ibm.com
Test checkpatch passed
Test docker-build@min-glib passed
Test docker-mingw@fedora passed
Test s390x passed
hw/s390x/ipl.c              |  4 ++++
pc-bios/s390-ccw/bootmap.c  | 16 +++++++------
pc-bios/s390-ccw/bootmap.h  |  2 --
pc-bios/s390-ccw/main.c     | 14 +++++------
pc-bios/s390-ccw/menu.c     | 58 +++++++++++++++++++++++++++++++--------------
pc-bios/s390-ccw/s390-ccw.h |  4 +++-
6 files changed, 63 insertions(+), 35 deletions(-)

[Qemu-devel] [PATCH v3 0/4] Small fixes for s390x QEMU boot menu

Posted by Collin Walling 23 weeks ago
Change Log:

    v3

        - added r-b's
        - added check around memset

    v2

        - added r-b's
        - s/zipl_println/zipl_print_entry
            - prints entry and returns entry number
        - while loop now handles valid_entries

These patches fix the following:

    - The QEMU zIPL boot menu does not allow accurate selection of
        non-sequential entries.

    - The QEMU zIPL boot menu does not have all the capabilities of the
        real zIPL menu (such as commandline args). We should print a different
        banner to reflect this.

    - The loadparm array in main.c can end up being not null terminated when
        converted to an integer via atoui.

    - A loadparm set to an empty string does not allow a boot menu.

Collin Walling (4):
  pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES
  pc-bios/s390-ccw: fix loadparm initialization and int conversion
  pc-bios/s390-ccw: fix non-sequential boot entries (eckd)
  pc-bios/s390-ccw: fix non-sequential boot entries (enum)

 hw/s390x/ipl.c              |  4 ++++
 pc-bios/s390-ccw/bootmap.c  | 16 +++++++------
 pc-bios/s390-ccw/bootmap.h  |  2 --
 pc-bios/s390-ccw/main.c     | 14 +++++------
 pc-bios/s390-ccw/menu.c     | 58 +++++++++++++++++++++++++++++++--------------
 pc-bios/s390-ccw/s390-ccw.h |  4 +++-
 6 files changed, 63 insertions(+), 35 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PATCH v3 0/4] Small fixes for s390x QEMU boot menu

Posted by Thomas Huth 23 weeks ago
On 16.04.2018 18:56, Collin Walling wrote:
> Change Log:
> 
>     v3
> 
>         - added r-b's
>         - added check around memset
> 
>     v2
> 
>         - added r-b's
>         - s/zipl_println/zipl_print_entry
>             - prints entry and returns entry number
>         - while loop now handles valid_entries
> 
> These patches fix the following:
> 
>     - The QEMU zIPL boot menu does not allow accurate selection of
>         non-sequential entries.
> 
>     - The QEMU zIPL boot menu does not have all the capabilities of the
>         real zIPL menu (such as commandline args). We should print a different
>         banner to reflect this.
> 
>     - The loadparm array in main.c can end up being not null terminated when
>         converted to an integer via atoui.
> 
>     - A loadparm set to an empty string does not allow a boot menu.
> 
> Collin Walling (4):
>   pc-bios/s390-ccw: rename MAX_TABLE_ENTRIES to MAX_BOOT_ENTRIES
>   pc-bios/s390-ccw: fix loadparm initialization and int conversion
>   pc-bios/s390-ccw: fix non-sequential boot entries (eckd)
>   pc-bios/s390-ccw: fix non-sequential boot entries (enum)

Thanks, queued to my s390-ccw-bios branch now.

 Thomas