From nobody Tue Feb 10 12:39:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1523377643325183.61490743636966; Tue, 10 Apr 2018 09:27:23 -0700 (PDT) Received: from localhost ([::1]:55236 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5w74-0004w3-Fz for importer@patchew.org; Tue, 10 Apr 2018 12:27:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5vzs-0007Q1-Tc for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5vzp-0002zZ-PV for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:52 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43043) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f5vzp-0002z5-Lg for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:49 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 24ED420E24; Tue, 10 Apr 2018 12:19:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 10 Apr 2018 12:19:49 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id D4F8FE4394; Tue, 10 Apr 2018 12:19:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=n+5tfJ+4z017gC guogLKIyRIajRDRn1bQR8e+G9GHj4=; b=o+FfnOjftgCdLnTWANj5hpkYiC1NjU TZkJnkTa+7ca3EN1gERJhkiyB8CHuAGatvFhw0P+IzhsEf3jhzTonJ7wyACOgoyj Rb/IPiTORgUkhKJ6kHLWlYpoCQJTir7I2MwceHeqQou+gJdxzaiCoLuxXuNSjtRa UCYqsOqa1nYSw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=n+5tfJ+4z017gCguogLKIyRIajRDRn1bQR8e+G9GHj4=; b=A3bmAxCg gqWC9EEkGFLhaV8PTsxewHumI9bs7Vh/w7ehmiuv+7SgXPNRzDu5AQdIY/nipYnJ d0FnLfAsTqevtd05YsyDOmgpQLN7OA/blzrJLcRLfWjT4LpTrgPwDVInsQcOgCDR Xb8H6JMc4AIZAcZZEkFziiwsPoMWlkr09ADwPdKIN+apM2YBysFU9jOruaIsN4QF q8RhkIhs13KTJjWs/1z33aKocaMCYd8A9EJ1Vu93nn4lvQY+beSB+qfAfasJlHaK CzllsZoVhuFPMVG8w6R3QzFikYVwTeZZhtXvnnrEvkF6MCCj4WYJR0tgNL/e9thV coBg36c++mv/cQ== X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 10 Apr 2018 12:19:43 -0400 Message-Id: <1523377186-32578-8-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523377186-32578-1-git-send-email-cota@braap.org> References: <1523377186-32578-1-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.29 Subject: [Qemu-devel] [PATCH 07/10] target/microblaze: avoid integer overflow in next_page PC check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E. Iglesias" , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: "Edgar E. Iglesias" Signed-off-by: Emilio G. Cota --- target/microblaze/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 7628b0e..401dbe6 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1637,7 +1637,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) uint32_t pc_start; struct DisasContext ctx; struct DisasContext *dc =3D &ctx; - uint32_t next_page_start, org_flags; + uint32_t page_start, org_flags; target_ulong npc; int num_insns; int max_insns; @@ -1663,7 +1663,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) cpu_abort(cs, "Microblaze: unaligned PC=3D%x\n", pc_start); } =20 - next_page_start =3D (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE; + page_start =3D pc_start & TARGET_PAGE_MASK; num_insns =3D 0; max_insns =3D tb_cflags(tb) & CF_COUNT_MASK; if (max_insns =3D=3D 0) { @@ -1749,7 +1749,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) } while (!dc->is_jmp && !dc->cpustate_changed && !tcg_op_buf_full() && !singlestep - && (dc->pc < next_page_start) + && (dc->pc - page_start < TARGET_PAGE_SIZE) && num_insns < max_insns); =20 npc =3D dc->pc; --=20 2.7.4