From nobody Tue Feb 10 12:39:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1523377333418778.3523703131383; Tue, 10 Apr 2018 09:22:13 -0700 (PDT) Received: from localhost ([::1]:55130 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5w20-0000Op-RP for importer@patchew.org; Tue, 10 Apr 2018 12:22:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5vzs-0007Pt-Rz for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5vzp-0002zq-Su for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:52 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:47281) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f5vzp-0002yb-O1 for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:49 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4BA0020E56; Tue, 10 Apr 2018 12:19:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 10 Apr 2018 12:19:48 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 01A99E4833; Tue, 10 Apr 2018 12:19:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=7Ml/vpUtG2nz8Z PAVxezgANt3gacuMH5UfOeQaKYc+o=; b=ukaXWd3aGi3GROCTIhuyL9fdh93kZK 3a4RzHC9aH01GyW6MYjsvdazQJ5rik8lKQNfmmosUl3+vl0EG9DhNMZhdvjTdb6t KDiNBkKHg4GG1YZi4JPyzQBxQGjAkG/BgPyWMBDuyVkbKi7ss+QDHhuExrrUrNH4 IZBx1u+NE3+nI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=7Ml/vpUtG2nz8ZPAVxezgANt3gacuMH5UfOeQaKYc+o=; b=MIo3OBc2 Fp6Zog2e2cWVFni6qXFxx7Xwr6Fon9krPjRplsfnlg7zQuJDPYcOi1C4eKkcNBQB s/IU/g1+/su2ZrgGItFIjgS2MJO+4YoFtqb2Q/XQ7e8QBalYxfN39+vZ8d8E07Cl SR2+ICJySTzKDLmU0jFrQW5KQzhHc95o0cMUQekn/sxcP5/t/02pguF448S5KFO0 awBWw5Vox7BRYhpCgXBurt6boL+Ud5yHPMJsPUZMYD/XSW9gHzFCLROQ6XrXQrhT eOrmUPNvPFoQFNhLuej+K5LEm8/A6MwZyGAL1cqfefeYJYrGSJg7F0shQY934Tfq p7IfkFMjawQreQ== X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 10 Apr 2018 12:19:39 -0400 Message-Id: <1523377186-32578-4-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523377186-32578-1-git-send-email-cota@braap.org> References: <1523377186-32578-1-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.29 Subject: [Qemu-devel] [PATCH 03/10] target/lm32: avoid integer overflow in next_page PC check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Walle , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: Michael Walle Signed-off-by: Emilio G. Cota Acked-by: Michael Walle --- target/lm32/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/lm32/translate.c b/target/lm32/translate.c index 2e1c5e6..fdd206a 100644 --- a/target/lm32/translate.c +++ b/target/lm32/translate.c @@ -1055,7 +1055,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) LM32CPU *cpu =3D lm32_env_get_cpu(env); struct DisasContext ctx, *dc =3D &ctx; uint32_t pc_start; - uint32_t next_page_start; + uint32_t page_start; int num_insns; int max_insns; =20 @@ -1075,7 +1075,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) pc_start &=3D ~3; } =20 - next_page_start =3D (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE; + page_start =3D pc_start & TARGET_PAGE_MASK; num_insns =3D 0; max_insns =3D tb_cflags(tb) & CF_COUNT_MASK; if (max_insns =3D=3D 0) { @@ -1115,7 +1115,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) && !tcg_op_buf_full() && !cs->singlestep_enabled && !singlestep - && (dc->pc < next_page_start) + && (dc->pc - page_start < TARGET_PAGE_SIZE) && num_insns < max_insns); =20 if (tb_cflags(tb) & CF_LAST_IO) { --=20 2.7.4