From nobody Tue Feb 10 12:39:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1523377487017554.0223066655199; Tue, 10 Apr 2018 09:24:47 -0700 (PDT) Received: from localhost ([::1]:55181 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5w4c-0002qV-1f for importer@patchew.org; Tue, 10 Apr 2018 12:24:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5vzs-0007Q2-UB for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5vzp-0002zE-IQ for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:52 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41243) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f5vzp-0002yZ-FE for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:49 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0A60C20DA1; Tue, 10 Apr 2018 12:19:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 10 Apr 2018 12:19:48 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id A03E91025A; Tue, 10 Apr 2018 12:19:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=g7h/LdAy8/Zvpn E2/JDQjRAjW6RnFoW3vT88JPTU5w0=; b=W4T02bE1TVW4ox6Cr2WFLjGvHK9IAQ V+TenaijHae1rXnLdIZmlcpvdDSbxP9MdbBmYMBbx9Sf/+qkc0HsZC7s1jhBhOZz Cju3lbHNMb+USiIwLt4Hc+sDnaHdf/BEwAVPMHjhMBIScYqIKNJBz3L1mo/iBauj uFFQ7cqcy7avg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=g7h/LdAy8/ZvpnE2/JDQjRAjW6RnFoW3vT88JPTU5w0=; b=Rz+Pi/zv CxNWIUs1Gg6j3uQDViyVf5T/NfpyHqLnuC6GICpgrT5Pe7B3arcsZ8kTo1T5k+s8 NZhkyoQhTbRm/ThYxUKXysct0eUuKTaWPSnOqmeVmh8RhFYY8vH9Hn/zsMNZL5Qj rFCzCynm4rvFMWGvwyGvp80rQ1k4w8/Ew69Dr469sNq/KWUIVW2SbN+cRbU0u6/j p9MY0SGjt9HAVCR9FN1WzOnoJMPP9WEMwLqN3bps5B0TN+Ec81FfZIee7h5Mi2Sz Y6IVwAmpMLB34gCZZykWEPjWXSVagf4q0QodmNSHIHqKCAVa8lIx1TIYqPCcpkrz w+kLG8oC2j5hRg== X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 10 Apr 2018 12:19:38 -0400 Message-Id: <1523377186-32578-3-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523377186-32578-1-git-send-email-cota@braap.org> References: <1523377186-32578-1-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.29 Subject: [Qemu-devel] [PATCH 02/10] target/cris: avoid integer overflow in next_page PC check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E. Iglesias" , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Cc: "Edgar E. Iglesias" Signed-off-by: Emilio G. Cota --- target/cris/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/cris/translate.c b/target/cris/translate.c index f51a731..64b9ec6 100644 --- a/target/cris/translate.c +++ b/target/cris/translate.c @@ -3091,7 +3091,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) unsigned int insn_len; struct DisasContext ctx; struct DisasContext *dc =3D &ctx; - uint32_t next_page_start; + uint32_t page_start; target_ulong npc; int num_insns; int max_insns; @@ -3138,7 +3138,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) =20 dc->cpustate_changed =3D 0; =20 - next_page_start =3D (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE; + page_start =3D pc_start & TARGET_PAGE_MASK; num_insns =3D 0; max_insns =3D tb_cflags(tb) & CF_COUNT_MASK; if (max_insns =3D=3D 0) { @@ -3234,7 +3234,7 @@ void gen_intermediate_code(CPUState *cs, struct Trans= lationBlock *tb) } while (!dc->is_jmp && !dc->cpustate_changed && !tcg_op_buf_full() && !singlestep - && (dc->pc < next_page_start) + && (dc->pc - page_start < TARGET_PAGE_SIZE) && num_insns < max_insns); =20 if (dc->clear_locked_irq) { --=20 2.7.4