From nobody Tue Feb 10 12:39:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1523377488235191.4806708807953; Tue, 10 Apr 2018 09:24:48 -0700 (PDT) Received: from localhost ([::1]:55183 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5w4d-0002qa-Eg for importer@patchew.org; Tue, 10 Apr 2018 12:24:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f5vzs-0007Po-RP for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f5vzp-0002z0-Ea for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:52 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:43703) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f5vzp-0002yW-9l for qemu-devel@nongnu.org; Tue, 10 Apr 2018 12:19:49 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B0065208B1; Tue, 10 Apr 2018 12:19:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 10 Apr 2018 12:19:47 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 758AEE4833; Tue, 10 Apr 2018 12:19:47 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=6TVaYVDnaVINIA RVFrFhaaWoM5bA3MmCdyeqM5QlhVw=; b=Ky4Dm6vR+jFEH0X0/lV0NQFQzLyKIl nSZdhrLfjkKigc3busnM8rm6ipZMbu3EKiEQbGg2fSvv4Nz+XP5+C8E6HFcTm9Fd 5+/5GwSYeQv+m+XNn5ssi1QFt2vY2HK9ldD1thBp6+OPZXFVs7dX0jsXMPmI5+T8 vCuUsLORtrTi4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=6TVaYVDnaVINIARVFrFhaaWoM5bA3MmCdyeqM5QlhVw=; b=KEurre/J 0TEZbmEoWZxIkxg4d9NQlP06Dwq3+PLcyh1b/oImPoFwkjtaXNTMda6RJAEXXibw qg1ZXLKcDiZGasUa5FJDOXuFTiGsAiUFCj/Cn9C/MtaNVBvi6xDcv+Uxo6I6urlj s3lgHshHsXXVuFW4ZLh3Lf8ttZVu+w9HNKgxWT6syX9BMfkVxb7UJjBaVFxU57JB iJMk6CHbh/pJr8P4v97aLdoCckFtA3h8pSnGXS+EgU86bJxvCOWJ5ujvp8S63EnA n3Q4uDblY5/LtKOkcJ09NOMAJrFKAF+7L2CsRNdN+1r4L/2ZxmU0p5bhxUfseTqE q3i/qwjGnowF1Q== X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 10 Apr 2018 12:19:37 -0400 Message-Id: <1523377186-32578-2-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1523377186-32578-1-git-send-email-cota@braap.org> References: <1523377186-32578-1-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.29 Subject: [Qemu-devel] [PATCH 01/10] target/riscv: avoid integer overflow in next_page PC check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Michael Clark , Richard Henderson , Sagar Karandikar , Palmer Dabbelt Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" If the PC is in the last page of the address space, next_page_start overflows to 0. Fix it. Reported-by: Richard Henderson Suggested-by: Richard Henderson Cc: Michael Clark Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Signed-off-by: Emilio G. Cota Acked-by: Bastian Koppelmann Reviewed-by: Michael Clark --- target/riscv/translate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 808eab7..d2d2e5e 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -1849,11 +1849,11 @@ void gen_intermediate_code(CPUState *cs, Translatio= nBlock *tb) CPURISCVState *env =3D cs->env_ptr; DisasContext ctx; target_ulong pc_start; - target_ulong next_page_start; + target_ulong page_start; int num_insns; int max_insns; pc_start =3D tb->pc; - next_page_start =3D (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE; + page_start =3D pc_start & TARGET_PAGE_MASK; ctx.pc =3D pc_start; =20 /* once we have GDB, the rest of the translate.c implementation should= be @@ -1903,7 +1903,7 @@ void gen_intermediate_code(CPUState *cs, TranslationB= lock *tb) if (cs->singlestep_enabled) { break; } - if (ctx.pc >=3D next_page_start) { + if (ctx.pc - page_start >=3D TARGET_PAGE_SIZE) { break; } if (tcg_op_buf_full()) { --=20 2.7.4