From nobody Tue Feb 10 05:26:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1523089998560584.3417135507235; Sat, 7 Apr 2018 01:33:18 -0700 (PDT) Received: from localhost ([::1]:41121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4jHh-0001Hc-QV for importer@patchew.org; Sat, 07 Apr 2018 04:33:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4jBd-00051p-KJ for qemu-devel@nongnu.org; Sat, 07 Apr 2018 04:27:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4jBa-00029e-HD for qemu-devel@nongnu.org; Sat, 07 Apr 2018 04:27:01 -0400 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:37125) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4jBa-00029J-CQ for qemu-devel@nongnu.org; Sat, 07 Apr 2018 04:26:58 -0400 Received: by mail-pf0-x242.google.com with SMTP id x16so2379399pfm.4 for ; Sat, 07 Apr 2018 01:26:58 -0700 (PDT) Received: from VM_127_91_centos.localdomain ([119.28.195.137]) by smtp.gmail.com with ESMTPSA id y129sm18478558pgb.64.2018.04.07.01.26.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Apr 2018 01:26:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wZYaZ8b30NFh+3FoBh5WoW8V7qUifH9/scogPqmVxdU=; b=Jo6V1UW4mQLo+VWrk7DBzH15vgSmXw+7POYGekm/pcugiinkeLRpBl/iqUpU9h7zJW k1LvBp+1g7ioPRvJjFDRMh124ZUMV4erSVkuY8LxAJ399Tmao933W7Oolj/FAihiRaDQ wyOne8NEfjSgN6w86lCKmnWgqvnzCruBQ6m11oBRKjuVrz+peNJD1BmWm/LAd9BTB+d/ e4Vk81LdvNYUjo89cYRcZ+2heIiaWyPJAuDzyO/BXoT5Y5bysWtzrSz70wGU7cZjmIrB 2T4VXvFaAQMz27jCsMzlsVJWsWk9GVunwVwY6ayhKHQu2OYq/k+OqCfHoG+/n644vkZM wRmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wZYaZ8b30NFh+3FoBh5WoW8V7qUifH9/scogPqmVxdU=; b=YlChb4mQTrYTEL10FNE7a8IhkVOa8sjNYkWzRDARnUvtcJoRsBHiiu2h4VArOVITt/ i+sX+ag1RhRTQ2wlV6ZVemnVSP0t7jJz1fb2WsoV3J7lHUK0XnhIMTQgUEZ25XKyXDK6 1z/zUHWPuRrIp87yikRKyW2N5vZrrlwBuZYu0jepb6vFzVivaq7ypgRhH6Pz5lSY/mG9 7QQik9NnEiVRuGiQmNt3XLvMgUspZBxS346a70kJAE4lXJ7EMNgXxFAhIM/lelPyejli yE+pPWKDBEm5SLzkl6fEUfENfojBoTv3OthuOx5Kj8cQ8PHpr9bs/sUv7IqixUCGuo5G cuvA== X-Gm-Message-State: AElRT7Gdpjm4SvUcT6wlRhfeJwdpVYGLa4Q0H209bF16VfYl7wMg0aeA KcNDDSPMMC4NXPbNdfmCiZw= X-Google-Smtp-Source: AIpwx4+d0DnkOS7eUx3hMFJHSASMkXuU+k+ngVGJ2/B/u93XDEtY+I98J3n4rAJ6W5wVld6DZucI8w== X-Received: by 10.99.119.74 with SMTP id s71mr19655748pgc.321.1523089617608; Sat, 07 Apr 2018 01:26:57 -0700 (PDT) From: Lidong Chen X-Google-Original-From: Lidong Chen To: quintela@redhat.com, dgilbert@redhat.com Date: Sat, 7 Apr 2018 16:26:34 +0800 Message-Id: <1523089594-1422-6-git-send-email-lidongchen@tencent.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1523089594-1422-1-git-send-email-lidongchen@tencent.com> References: <1523089594-1422-1-git-send-email-lidongchen@tencent.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 Subject: [Qemu-devel] [PATCH 5/5] migration: disable RDMA WRITR after postcopy started. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lidong Chen , adido@mellanox.com, qemu-devel@nongnu.org, licq@mellanox.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" RDMA write operations are performed with no notification to the destination qemu, then the destination qemu can not wakeup. So disable RDMA WRITE after postcopy started. Signed-off-by: Lidong Chen --- migration/qemu-file.c | 3 ++- migration/rdma.c | 12 ++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 8acb574..a64ac3a 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -260,7 +260,8 @@ size_t ram_control_save_page(QEMUFile *f, ram_addr_t bl= ock_offset, int ret =3D f->hooks->save_page(f, f->opaque, block_offset, offset, size, bytes_sent); f->bytes_xfer +=3D size; - if (ret !=3D RAM_SAVE_CONTROL_DELAYED) { + if (ret !=3D RAM_SAVE_CONTROL_DELAYED && + ret !=3D RAM_SAVE_CONTROL_NOT_SUPP) { if (bytes_sent && *bytes_sent > 0) { qemu_update_position(f, *bytes_sent); } else if (ret < 0) { diff --git a/migration/rdma.c b/migration/rdma.c index 81be482..8529ddd 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -2964,6 +2964,10 @@ static size_t qemu_rdma_save_page(QEMUFile *f, void = *opaque, =20 CHECK_ERROR_STATE(); =20 + if (migrate_get_current()->state =3D=3D MIGRATION_STATUS_POSTCOPY_ACTI= VE) { + return RAM_SAVE_CONTROL_NOT_SUPP; + } + qemu_fflush(f); =20 if (size > 0) { @@ -3528,6 +3532,10 @@ static int qemu_rdma_registration_start(QEMUFile *f,= void *opaque, =20 CHECK_ERROR_STATE(); =20 + if (migrate_get_current()->state =3D=3D MIGRATION_STATUS_POSTCOPY_ACTI= VE) { + return 0; + } + trace_qemu_rdma_registration_start(flags); qemu_put_be64(f, RAM_SAVE_FLAG_HOOK); qemu_fflush(f); @@ -3550,6 +3558,10 @@ static int qemu_rdma_registration_stop(QEMUFile *f, = void *opaque, =20 CHECK_ERROR_STATE(); =20 + if (migrate_get_current()->state =3D=3D MIGRATION_STATUS_POSTCOPY_ACTI= VE) { + return 0; + } + qemu_fflush(f); ret =3D qemu_rdma_drain_cq(f, rdma); =20 --=20 1.8.3.1