From nobody Tue Feb 10 07:40:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1523035529308368.65502464702456; Fri, 6 Apr 2018 10:25:29 -0700 (PDT) Received: from localhost ([::1]:40875 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4V70-0003FG-99 for importer@patchew.org; Fri, 06 Apr 2018 13:25:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f4Utv-00083b-Vz for qemu-devel@nongnu.org; Fri, 06 Apr 2018 13:11:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f4Utu-0007uN-Vo for qemu-devel@nongnu.org; Fri, 06 Apr 2018 13:11:47 -0400 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:37794) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f4Utu-0007sh-Or for qemu-devel@nongnu.org; Fri, 06 Apr 2018 13:11:46 -0400 Received: by mail-wr0-x241.google.com with SMTP id l49so2417703wrl.4 for ; Fri, 06 Apr 2018 10:11:46 -0700 (PDT) Received: from 640k.lan (94-36-194-48.adsl-ull.clienti.tiscali.it. [94.36.194.48]) by smtp.gmail.com with ESMTPSA id 24sm16286180wrt.60.2018.04.06.10.11.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Apr 2018 10:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZqBjaGDR4+tChyyyY4iIvEFhTRDIJ8vC+2cORf1wmvg=; b=fCSl3sAKccRsMwtZHX7YmUivpydc6FMUtNsiKnQQtD4MI+uIvBDHd/lFiMbvJTMHmr 2fdcffu9J5Dht5smLnm1hPo+eWKG61L4MlBiC0dPPfbzScUO91pVm/DL7/H3nhaYYtRN mBKZ4AMf6Bbhlq11EGPUFNJVGIXZyBe82u+C1alprMCMgsLg04jcfpZT/350AHUXeA5H QbI5wjKI87chzMEvRNLgqj0sAQ3wXTlrN+SUChDuX+JOQvpYwQKT2XtvQcLSgGtr7BwB NTj20VF5N+duyCNwJ4IhPWami2L2NbuoDoxj5cOFpoV06+0SHbyLWarRt6fCeNVyzMzp YlAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ZqBjaGDR4+tChyyyY4iIvEFhTRDIJ8vC+2cORf1wmvg=; b=GrsaUlc4uy+HF+b0/mn8MTg8vcqxEJBD359y/7OyZCraqKjCClIIM7p2DkNxGUr3uc vmANDd6Xmt4/VDKOicQojykuRMMMZBUTEayL2Kb7nORC0F1wFTro3pc0pLFTEifMdwxE 3xQ+dkzOi58e0uXEqg2MgdFnPJUuLtJtjyBguriESHZV5dpcxmdjmWjlBGFhnkhXvfp6 T1WWitQQBJT84FT8plqnpzyJObWHtQk8l9LyGJuN0HHV+GuyZBGXYvWuA/R84VYnV5wr v/CfUIOinJucJ7JM9SZk+ll4RuURAlGNhLCmBi5CPFO5Ub0FTMmoPBmJTh/l2Xrpmb7+ YzIQ== X-Gm-Message-State: AElRT7FHKdnv5Lxqbt6z/YSwIW9J5BRyZqqQEmrQxTmvgcvo/6hG7G6s Zm+QAt7rCO1rCX61AXjUKM8yVHYC X-Google-Smtp-Source: AIpwx490HSAkkBPbBH6vpSVRdD3v8OOQpiuijTyIt17IIZvxiFoPAnS8JrqYKzx2n2BajY8ZPPeIsg== X-Received: by 10.223.174.214 with SMTP id y80mr19624243wrc.68.1523034705424; Fri, 06 Apr 2018 10:11:45 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 6 Apr 2018 19:11:17 +0200 Message-Id: <1523034681-33787-17-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1523034681-33787-1-git-send-email-pbonzini@redhat.com> References: <1523034681-33787-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL 16/20] qemu-pr-helper: Write pidfile more often X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Privoznik Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Michal Privoznik Let's write pidfile even if user did not request --daemon but they requested just --pidfile. Libvirt will use exactly this. Signed-off-by: Michal Privoznik Signed-off-by: Paolo Bonzini --- scsi/qemu-pr-helper.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scsi/qemu-pr-helper.c b/scsi/qemu-pr-helper.c index eeff80a..d0f8317 100644 --- a/scsi/qemu-pr-helper.c +++ b/scsi/qemu-pr-helper.c @@ -924,6 +924,7 @@ int main(int argc, char **argv) Error *local_err =3D NULL; char *trace_file =3D NULL; bool daemonize =3D false; + bool pidfile_specified =3D false; unsigned socket_activation; =20 struct sigaction sa_sigterm; @@ -954,6 +955,7 @@ int main(int argc, char **argv) case 'f': g_free(pidfile); pidfile =3D g_strdup(optarg); + pidfile_specified =3D true; break; #ifdef CONFIG_LIBCAP case 'u': { @@ -1086,9 +1088,11 @@ int main(int argc, char **argv) error_report("Failed to daemonize: %s", strerror(errno)); exit(EXIT_FAILURE); } - write_pidfile(); } =20 + if (daemonize || pidfile_specified) + write_pidfile(); + #ifdef CONFIG_LIBCAP if (drop_privileges() < 0) { error_report("Failed to drop privileges: %s", strerror(errno)); --=20 1.8.3.1