From nobody Tue Oct 28 02:08:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1522129305250599.3605820417293; Mon, 26 Mar 2018 22:41:45 -0700 (PDT) Received: from localhost ([::1]:60515 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0hMX-0005Gk-Bo for importer@patchew.org; Tue, 27 Mar 2018 01:41:37 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0hFI-0007P4-6W for qemu-devel@nongnu.org; Tue, 27 Mar 2018 01:34:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0hFD-0005MJ-MJ for qemu-devel@nongnu.org; Tue, 27 Mar 2018 01:34:08 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40685) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0hFD-0005LV-HW for qemu-devel@nongnu.org; Tue, 27 Mar 2018 01:34:03 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 37FD221662; Tue, 27 Mar 2018 01:34:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 27 Mar 2018 01:34:03 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id E9B45E43DF; Tue, 27 Mar 2018 01:34:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=/wDaHfLUmYK0mh w1/uCg8nOx9mTQTPfpRhmRUSc3F0E=; b=ZlkIYXIYv4H6EXk6S96zdzildjICeu aCYlH9FDky0O33Knn4iBHxzFhuD2Rsav+tYw3RgEo8wRYT8o0twwM9oWWInUyp2c xX3sXaVxlZjpAH4QXkjtGBzdlZXQnXtKrswW7gG7gOxkVjPDVHUu6Gz6Cz+iuAKq ATIEKFKKYLbOk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=/wDaHfLUmYK0mhw1/uCg8nOx9mTQTPfpRhmRUSc3F0E=; b=Tur5Dyvs QTf5f5jw7z+d7H2DDdn4L0q5I/21CavHc21RwTdtGRm92dPjAIAlSLPcGMJKz12r f+g0h2q0QlcaauWs+4Hl1bXvPWtp3VdQBrx0/Qak95S80/sdvrU83JolJ7s2XLC/ sIoLj+CAkmd9bBbevJCTNOnlKfq2n5AmN4HfBu65kosj8aBHclVCVqeIkZM74lWv MxkVU2iUWhkVCjTHEARvsSMis0ETN8JP0eulyzc4VlWVjshbmO4fEEUKzjrANR3m nQjddpNclAtsFmkoyh5RvBIvZqNnJzwC6x6v4SbBffqhtWrm5/Sl6oV1DpieQvGn 25L5q/fpR2adxQ== X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 27 Mar 2018 01:33:54 -0400 Message-Id: <1522128840-498-9-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522128840-498-1-git-send-email-cota@braap.org> References: <1522128840-498-1-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.29 Subject: [Qemu-devel] [PATCH v2 08/14] hardfloat: support float32/64 addition and subtraction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Mark Cave-Ayland , Richard Henderson , Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Note that for float32 we do most checks on the float32 and not on the native type; for float64 we do the opposite. This is faster than going either way for both, as shown below. I am keeping both macro-based definitions to ease testing of either option. Performance results (single and double precision) for fp-bench run under aarch64-linux-user on an Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz host: - before: add-single: 86.74 MFlops add-double: 86.46 MFlops sub-single: 83.33 MFlops sub-double: 84.57 MFlops - after this commit: add-single: 188.89 MFlops add-double: 172.27 MFlops sub-single: 187.69 MFlops sub-double: 171.89 MFlops - w/ both using float32/64_is_normal etc.: add-single: 187.63 MFlops add-double: 143.51 MFlops sub-single: 187.91 MFlops sub-double: 144.23 MFlops - w/ both using fpclassify etc.: add-single: 166.61 MFlops add-double: 172.32 MFlops sub-single: 169.13 MFlops sub-double: 173.09 MFlops Signed-off-by: Emilio G. Cota Reviewed-by: Alex Benn=C3=A9e --- fpu/softfloat.c | 120 ++++++++++++++++++++++++++++++++++++++++++++++++++++= ---- 1 file changed, 112 insertions(+), 8 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index ffe16b2..e0ab0ca 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -829,8 +829,8 @@ float16 __attribute__((flatten)) float16_add(float16 a= , float16 b, return float16_round_pack_canonical(pr, status); } =20 -float32 __attribute__((flatten)) float32_add(float32 a, float32 b, - float_status *status) +static float32 __attribute__((flatten, noinline)) +soft_float32_add(float32 a, float32 b, float_status *status) { FloatParts pa =3D float32_unpack_canonical(a, status); FloatParts pb =3D float32_unpack_canonical(b, status); @@ -839,8 +839,8 @@ float32 __attribute__((flatten)) float32_add(float32 a,= float32 b, return float32_round_pack_canonical(pr, status); } =20 -float64 __attribute__((flatten)) float64_add(float64 a, float64 b, - float_status *status) +static float64 __attribute__((flatten, noinline)) +soft_float64_add(float64 a, float64 b, float_status *status) { FloatParts pa =3D float64_unpack_canonical(a, status); FloatParts pb =3D float64_unpack_canonical(b, status); @@ -859,8 +859,8 @@ float16 __attribute__((flatten)) float16_sub(float16 a,= float16 b, return float16_round_pack_canonical(pr, status); } =20 -float32 __attribute__((flatten)) float32_sub(float32 a, float32 b, - float_status *status) +static float32 __attribute__((flatten, noinline)) +soft_float32_sub(float32 a, float32 b, float_status *status) { FloatParts pa =3D float32_unpack_canonical(a, status); FloatParts pb =3D float32_unpack_canonical(b, status); @@ -869,8 +869,8 @@ float32 __attribute__((flatten)) float32_sub(float32 a,= float32 b, return float32_round_pack_canonical(pr, status); } =20 -float64 __attribute__((flatten)) float64_sub(float64 a, float64 b, - float_status *status) +static float64 __attribute__((flatten, noinline)) +soft_float64_sub(float64 a, float64 b, float_status *status) { FloatParts pa =3D float64_unpack_canonical(a, status); FloatParts pb =3D float64_unpack_canonical(b, status); @@ -879,6 +879,110 @@ float64 __attribute__((flatten)) float64_sub(float64 = a, float64 b, return float64_round_pack_canonical(pr, status); } =20 +#define GEN_FPU_ADDSUB(add_name, sub_name, soft_t, host_t, \ + host_abs_func, min_normal) \ + static inline __attribute__((always_inline)) soft_t \ + fpu_ ## soft_t ## _addsub(soft_t a, soft_t b, bool subtract, \ + float_status *s) \ + { \ + soft_t ## _input_flush2(&a, &b, s); \ + if (likely((soft_t ## _is_normal(a) || soft_t ## _is_zero(a)) && \ + (soft_t ## _is_normal(b) || soft_t ## _is_zero(b)) && \ + s->float_exception_flags & float_flag_inexact && \ + s->float_rounding_mode =3D=3D float_round_nearest_even)= ) { \ + host_t ha =3D soft_t ## _to_ ## host_t(a); \ + host_t hb =3D soft_t ## _to_ ## host_t(b); \ + host_t hr; \ + soft_t r; \ + \ + if (subtract) { \ + hb =3D -hb; \ + } \ + hr =3D ha + hb; \ + r =3D host_t ## _to_ ## soft_t(hr); \ + if (unlikely(soft_t ## _is_infinity(r))) { \ + s->float_exception_flags |=3D float_flag_overflow; \ + } else if (unlikely(host_abs_func(hr) <=3D min_normal) && \ + !(soft_t ## _is_zero(a) && \ + soft_t ## _is_zero(b))) { \ + goto soft; \ + } \ + return r; \ + } \ + soft: \ + if (subtract) { \ + return soft_ ## soft_t ## _sub(a, b, s); \ + } else { \ + return soft_ ## soft_t ## _add(a, b, s); \ + } \ + } \ + \ + soft_t add_name(soft_t a, soft_t b, float_status *status) \ + { \ + return fpu_ ## soft_t ## _addsub(a, b, false, status); \ + } \ + \ + soft_t sub_name(soft_t a, soft_t b, float_status *status) \ + { \ + return fpu_ ## soft_t ## _addsub(a, b, true, status); \ + } + +GEN_FPU_ADDSUB(float32_add, float32_sub, float32, float, fabsf, FLT_MIN) +#undef GEN_FPU_ADDSUB + +#define GEN_FPU_ADDSUB(add_name, sub_name, soft_t, host_t, \ + host_abs_func, min_normal) \ + static inline __attribute__((always_inline)) soft_t \ + fpu_ ## soft_t ## _addsub(soft_t a, soft_t b, bool subtract, \ + float_status *s) \ + { \ + double ha, hb; \ + \ + soft_t ## _input_flush2(&a, &b, s); \ + ha =3D soft_t ## _to_ ## host_t(a); \ + hb =3D soft_t ## _to_ ## host_t(b); \ + if (likely((fpclassify(ha) =3D=3D FP_NORMAL || = \ + fpclassify(ha) =3D=3D FP_ZERO) && = \ + (fpclassify(hb) =3D=3D FP_NORMAL || = \ + fpclassify(hb) =3D=3D FP_ZERO) && = \ + s->float_exception_flags & float_flag_inexact && \ + s->float_rounding_mode =3D=3D float_round_nearest_even)= ) { \ + host_t hr; \ + \ + if (subtract) { \ + hb =3D -hb; \ + } \ + hr =3D ha + hb; \ + if (unlikely(isinf(hr))) { \ + s->float_exception_flags |=3D float_flag_overflow; \ + } else if (unlikely(host_abs_func(hr) <=3D min_normal) && \ + !(soft_t ## _is_zero(a) && \ + soft_t ## _is_zero(b))) { \ + goto soft; \ + } \ + return host_t ## _to_ ## soft_t(hr); \ + } \ + soft: \ + if (subtract) { \ + return soft_ ## soft_t ## _sub(a, b, s); \ + } else { \ + return soft_ ## soft_t ## _add(a, b, s); \ + } \ + } \ + \ + soft_t add_name(soft_t a, soft_t b, float_status *status) \ + { \ + return fpu_ ## soft_t ## _addsub(a, b, false, status); \ + } \ + \ + soft_t sub_name(soft_t a, soft_t b, float_status *status) \ + { \ + return fpu_ ## soft_t ## _addsub(a, b, true, status); \ + } + +GEN_FPU_ADDSUB(float64_add, float64_sub, float64, double, fabs, DBL_MIN) +#undef GEN_FPU_ADDSUB + /* * Returns the result of multiplying the floating-point values `a' and * `b'. The operation is performed according to the IEC/IEEE Standard --=20 2.7.4