From nobody Tue Oct 28 02:08:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1522129428638898.9528952122673; Mon, 26 Mar 2018 22:43:48 -0700 (PDT) Received: from localhost ([::1]:60531 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0hOd-0007Ae-OF for importer@patchew.org; Tue, 27 Mar 2018 01:43:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0hFI-0007PD-8X for qemu-devel@nongnu.org; Tue, 27 Mar 2018 01:34:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0hFE-0005ON-NA for qemu-devel@nongnu.org; Tue, 27 Mar 2018 01:34:08 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:48435) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f0hFE-0005Nd-J6 for qemu-devel@nongnu.org; Tue, 27 Mar 2018 01:34:04 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3C75121670; Tue, 27 Mar 2018 01:34:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 27 Mar 2018 01:34:04 -0400 Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id E9E041029A; Tue, 27 Mar 2018 01:34:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=mesmtp; bh=d4119hVwnVpI0w 1XxtJisRH7CliykS6y8GqGTIqi2fQ=; b=zUhlJw5DjkSRO+MGnOW7lDExDm2ELP SflAi8BNIYjAofU8jZcTVr0tHzCpVJ8ABHmdPamhsDRQ/I6GA3N6eMATxwUYOulN ilxQa/mUSNQ4Xh5oh/KhFW3/5bw3CznLz7DXxGJX86Y/1h6Xzf+er+r0j1fv4g3s oyHzU/gFLWTxo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=d4119hVwnVpI0w1XxtJisRH7CliykS6y8GqGTIqi2fQ=; b=jj5YnMEM x22q8nI+RyTJv4l3b9rmzmtHCgbh7EJ0BwQloLYWUtJzKxc+iPbsSmNKaoTzQ3YM ZRwEhSEzRflw92YJ7TfzcRRhQ6iy9gAcvVuX4wsv0OQ0FQbs4aUlrWGKZiWRgWaT /xDsLz/mJ8PntXdsiM+VTkNap1az7jxG9PTOw75AZpb36qJzS/jDjFjxIr/L/EeF tRp48tcco6IVkiP9LqFzGXOeDG1lyNEiU5MmytSx9VIAfhgJAT1aaM39uhi+aJs1 kvs52OxJaKUxn2g/AzwQU83tGQLpX7ZTJXoPhjvIQi0tNmN1M6Yec0SIxqib1Wh+ ldDsrtlQIwSaHQ== X-ME-Sender: From: "Emilio G. Cota" To: qemu-devel@nongnu.org Date: Tue, 27 Mar 2018 01:33:59 -0400 Message-Id: <1522128840-498-14-git-send-email-cota@braap.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522128840-498-1-git-send-email-cota@braap.org> References: <1522128840-498-1-git-send-email-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.29 Subject: [Qemu-devel] [PATCH v2 13/14] hardfloat: support float32/64 comparison X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Mark Cave-Ayland , Richard Henderson , Laurent Vivier , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Performance results for fp-bench run under aarch64-linux-user on an Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz host: - before: cmp-single: 34.23 MFlops cmp-double: 32.53 MFlops - after: cmp-single: 43.51 MFlops cmp-double: 41.23 MFlops Using float32/64_is_any_nan vs. isnan yields only up to a 2% perf difference, so I'm keeping for now a single implementation. This low sensitivity is most likely due to the soft-fp int64_to_float32/64 functions -- they take ~50% of execution time. They should be converted to hardfloat once there are test cases in fp-test for them. Signed-off-by: Emilio G. Cota --- fpu/softfloat.c | 69 +++++++++++++++++++++++++++++++++++++++++++++--------= ---- 1 file changed, 55 insertions(+), 14 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index ba7289b..2b86d73 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -2300,28 +2300,69 @@ static int compare_floats(FloatParts a, FloatParts = b, bool is_quiet, } } =20 -#define COMPARE(sz) \ -int float ## sz ## _compare(float ## sz a, float ## sz b, \ - float_status *s) \ -{ \ - FloatParts pa =3D float ## sz ## _unpack_canonical(a, s); \ - FloatParts pb =3D float ## sz ## _unpack_canonical(b, s); \ - return compare_floats(pa, pb, false, s); \ -} \ -int float ## sz ## _compare_quiet(float ## sz a, float ## sz b, \ - float_status *s) \ +#define COMPARE(attr, sz) \ +static int attr \ +soft_float ## sz ## _compare(float ## sz a, float ## sz b, \ + bool is_quiet, float_status *s) \ { \ FloatParts pa =3D float ## sz ## _unpack_canonical(a, s); \ FloatParts pb =3D float ## sz ## _unpack_canonical(b, s); \ - return compare_floats(pa, pb, true, s); \ + return compare_floats(pa, pb, is_quiet, s); \ } =20 -COMPARE(16) -COMPARE(32) -COMPARE(64) +COMPARE(, 16) +COMPARE(__attribute__((noinline)), 32) +COMPARE(__attribute__((noinline)), 64) =20 #undef COMPARE =20 +int __attribute__((flatten)) +float16_compare(float16 a, float16 b, float_status *s) +{ + return soft_float16_compare(a, b, false, s); +} + +int __attribute__((flatten)) +float16_compare_quiet(float16 a, float16 b, float_status *s) +{ + return soft_float16_compare(a, b, true, s); +} + +#define GEN_FPU_COMPARE(name, soft_t, host_t) \ + static inline __attribute__((always_inline)) int \ + fpu_ ## name(soft_t a, soft_t b, bool is_quiet, float_status *s) \ + { \ + host_t ha, hb; \ + \ + soft_t ## _input_flush2(&a, &b, s); \ + ha =3D soft_t ## _to_ ## host_t(a); \ + hb =3D soft_t ## _to_ ## host_t(b); \ + if (unlikely(isnan(ha) || isnan(hb))) { \ + return soft_ ## name(a, b, is_quiet, s); \ + } \ + if (isgreater(ha, hb)) { \ + return float_relation_greater; \ + } \ + if (isless(ha, hb)) { \ + return float_relation_less; \ + } \ + return float_relation_equal; \ + } \ + \ + int name(soft_t a, soft_t b, float_status *s) \ + { \ + return fpu_ ## name(a, b, false, s); \ + } \ + \ + int name ## _quiet(soft_t a, soft_t b, float_status *s) \ + { \ + return fpu_ ## name(a, b, true, s); \ + } + +GEN_FPU_COMPARE(float32_compare, float32, float) +GEN_FPU_COMPARE(float64_compare, float64, double) +#undef GEN_FPU_COMPARE + /* Multiply A by 2 raised to the power N. */ static FloatParts scalbn_decomposed(FloatParts a, int n, float_status *s) { --=20 2.7.4