From nobody Tue Feb 10 00:39:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1522071755983582.0328122019653; Mon, 26 Mar 2018 06:42:35 -0700 (PDT) Received: from localhost ([::1]:56823 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0SOR-0002x4-2o for importer@patchew.org; Mon, 26 Mar 2018 09:42:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0SIx-0006Uv-8N for qemu-devel@nongnu.org; Mon, 26 Mar 2018 09:36:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0SIw-0006vY-3o for qemu-devel@nongnu.org; Mon, 26 Mar 2018 09:36:55 -0400 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:46793) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0SIv-0006v9-Sw for qemu-devel@nongnu.org; Mon, 26 Mar 2018 09:36:54 -0400 Received: by mail-wr0-x244.google.com with SMTP id d1so6939529wrj.13 for ; Mon, 26 Mar 2018 06:36:53 -0700 (PDT) Received: from 640k.lan (94-36-194-48.adsl-ull.clienti.tiscali.it. [94.36.194.48]) by smtp.gmail.com with ESMTPSA id g186sm6710105wmd.41.2018.03.26.06.36.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 06:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=03HdpYWU6TXOnjjraCOYhYdMrrkMP5wuUKnwGJ5TQ/w=; b=KXqdjeF0OiSHp7vfm96KFocM0UaTe76N1cZpugJJ3I8aZrvKxOm3WsKN1UCkYu92Ea a4BZjWvQVgTL3I+QRvng16WXTBO/tczl5lYROxBR6hb/11kkQwzYuHV4nHTpV0dHSyby Ozf1xIKj/o/7GVtsX1L+Ri4P8E60atRPXdyVCNdRZGSiXsYWGrIXhmHaLvPmjpdrZTIK zmMj162sFpduEoGux6+Rufecu+rbjsWgTbaQzi/X+6xZbsdVlJkuctK2mld+/I8SnEOB AhmAwdztZmaN38MqSvol3Awdh8eXXxkbtKQLVMZYKbH0gnPq8Tnc1bWXtoGI7iJZO06T XZUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=03HdpYWU6TXOnjjraCOYhYdMrrkMP5wuUKnwGJ5TQ/w=; b=HyVxhtXVA3RNlX9vsCZpeZJHujOSyHqv6Y3cY+1gP6EPHEDeBNdu8VdtMudF4CcP1k hFs+EeW7IBqyLLkPJM1hDJtH4QNZ8UbtWzbnMxw9QPomeHNSSrV69Q0ismfcjVYLHJ4C ZxmCJN3bGcXsLuvpgFXLr3mQK7uQbrNmH7+OKCTdLMsurk68HMIHOZlVGyN8GmuHDbdP aDukSBWh42MHBux81ZpK6QhpN0k0/Asz0rQIy0qIvIceNbv/yCow0ftsTftYluen6yKw UI3i1b02JG9wR5CEDyWVyMIK38WdWxSeT7MeM68QC59CJIw9Fkqo9DiL6jRYFBfVSEJM Htfg== X-Gm-Message-State: AElRT7GVtK4qUQlHmi3T/xZlr1p1PvPleuXEkJs/YmR+x6r00DF9ZCE0 /+R4QdvajJ9IQSXN7SL8AtiVJoVV X-Google-Smtp-Source: AG47ELsHjt0syH8B51oTaDJ/B15kbf9q9DJ7zMvANtTzBVcH3PCBCaW5WfJ0ZOtwmDTOSAwbtKJjOg== X-Received: by 10.223.157.194 with SMTP id q2mr15833328wre.125.1522071412481; Mon, 26 Mar 2018 06:36:52 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 26 Mar 2018 15:36:32 +0200 Message-Id: <1522071403-52486-6-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1522071403-52486-1-git-send-email-pbonzini@redhat.com> References: <1522071403-52486-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 Subject: [Qemu-devel] [PULL 05/16] hw/net/can: Fix segfaults when using the devices without bus X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The CAN devices can currently be used to crash QEMU, e.g.: $ x86_64-softmmu/qemu-system-x86_64 -device kvaser_pci Segmentation fault (core dumped) So we've got to add a proper check here that the corresponding bus is available. Signed-off-by: Thomas Huth Message-Id: <1521193892-15552-2-git-send-email-thuth@redhat.com> Signed-off-by: Paolo Bonzini --- hw/net/can/can_sja1000.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/net/can/can_sja1000.c b/hw/net/can/can_sja1000.c index 6293233..9a85038 100644 --- a/hw/net/can/can_sja1000.c +++ b/hw/net/can/can_sja1000.c @@ -866,6 +866,10 @@ int can_sja_connect_to_bus(CanSJA1000State *s, CanBusS= tate *bus) { s->bus_client.info =3D &can_sja_bus_client_info; =20 + if (!bus) { + return -EINVAL; + } + if (can_bus_insert_client(bus, &s->bus_client) < 0) { return -1; } --=20 1.8.3.1