From nobody Mon Feb 9 17:06:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1522072284436705.2956718642121; Mon, 26 Mar 2018 06:51:24 -0700 (PDT) Received: from localhost ([::1]:56880 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0SWx-0002mj-JN for importer@patchew.org; Mon, 26 Mar 2018 09:51:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0SJ7-0006g1-Kt for qemu-devel@nongnu.org; Mon, 26 Mar 2018 09:37:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0SJ6-00072T-Lf for qemu-devel@nongnu.org; Mon, 26 Mar 2018 09:37:05 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:54857) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0SJ6-00071s-FU for qemu-devel@nongnu.org; Mon, 26 Mar 2018 09:37:04 -0400 Received: by mail-wm0-x242.google.com with SMTP id h76so15483410wme.4 for ; Mon, 26 Mar 2018 06:37:04 -0700 (PDT) Received: from 640k.lan (94-36-194-48.adsl-ull.clienti.tiscali.it. [94.36.194.48]) by smtp.gmail.com with ESMTPSA id g186sm6710105wmd.41.2018.03.26.06.37.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 06:37:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=KqIuQlrgW+2eeDFrk7JAgxVXL95ZDVypVRSTS7TnwFE=; b=GyuX5VX5lDrrMaTomWmAB5m1TtXoB5nPLhM8iEfFR66VmwpwbgXimxy+ZCQDC+GD2O N4mcB7H6Ca+cnfkAsZApIKlJkFu2KgQ2WTYNz0VIaUs7SN+LE/xmDhXKRhr3yKputF2H fRHZc96hxSAuWl+l5MUxp5ktm4W4ESvcN2tD+OfMWvtY3x9qnENRncfyMrM0Zp0MVJQs RJ1mYaWePelqdVzFCYeidZu7bZwDCFOj1uypdZrdoEiT4i+QYzDniFW8ZjgdvEkqgs4+ OBvu8bOilvA4juqxvDEGL4tUKtPYzO2dDuzAtGtUiu3VJBLK2vs6OkKQpEr40uEzjZDx VrDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=KqIuQlrgW+2eeDFrk7JAgxVXL95ZDVypVRSTS7TnwFE=; b=FIgXRJkmHZWxHu6gv5AYTXv0NKba9l/d3TObi5KBF6N7opJPpLWnq6v6OrEkScizmO hnP+nuOrJ8DmypPF5qS4aBNj47YvtVvGNNROPNN20kmsj1VAZfbVoFZ6B726NbfrBUw3 32m3P/1042aSNYlGMFf49yV7ytb4qQyThr2gB2IEHJ9RlhZMOz9NrE52UJSzfiVLidHC n7+DXFavZbG2gK4sx22K6/M3kgYL/1XStCIXBzvdMMyBXZUQSKpinIgw4BtxJ1tgHCIO yuKNxDvOGswGbT39xUQP/4CXQbkPKZbQulCn9vIMhMxDd2/kLsR7wdegpdg6XsvGNZRa fcpg== X-Gm-Message-State: AElRT7G/mqUx6t4nRJ3xLjZ2N8XVewZILzcmLP74nUxU1B7WBrO7D5Ee kBvtwIAy+wQdYo8v8+L2BsVmaihj X-Google-Smtp-Source: AIpwx4+pyOHubjzqzjSqcS4RZ6IEAihxQCIN3UqZc/QooJPR1JAF9n/nIv3p7Q22aws0jSWPvakCbQ== X-Received: by 10.28.24.17 with SMTP id 17mr3906027wmy.128.1522071423095; Mon, 26 Mar 2018 06:37:03 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 26 Mar 2018 15:36:41 +0200 Message-Id: <1522071403-52486-15-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1522071403-52486-1-git-send-email-pbonzini@redhat.com> References: <1522071403-52486-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PULL 14/16] iothread: fix breakage on windows X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Xu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Peter Xu OOB can enable iothread for parsing even on Windows. We need some tunes to enable that on Windows otherwise it'll break Windows users. This patch fixes the breakage on Windows with qemu-system-ppc.exe. Reported-by: Howard Spoelstra Tested-by: Howard Spoelstra Suggested-by: Paolo Bonzini Signed-off-by: Peter Xu Message-Id: <20180322085630.23654-1-peterx@redhat.com> Signed-off-by: Paolo Bonzini --- iothread.c | 4 ++++ util/aio-win32.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/iothread.c b/iothread.c index 1b3463c..e675c38 100644 --- a/iothread.c +++ b/iothread.c @@ -31,11 +31,15 @@ typedef ObjectClass IOThreadClass; #define IOTHREAD_CLASS(klass) \ OBJECT_CLASS_CHECK(IOThreadClass, klass, TYPE_IOTHREAD) =20 +#ifdef CONFIG_POSIX /* Benchmark results from 2016 on NVMe SSD drives show max polling times a= round * 16-32 microseconds yield IOPS improvements for both iodepth=3D1 and iod= epth=3D32 * workloads. */ #define IOTHREAD_POLL_MAX_NS_DEFAULT 32768ULL +#else +#define IOTHREAD_POLL_MAX_NS_DEFAULT 0ULL +#endif =20 static __thread IOThread *my_iothread; =20 diff --git a/util/aio-win32.c b/util/aio-win32.c index d6d5e02..a67b00c 100644 --- a/util/aio-win32.c +++ b/util/aio-win32.c @@ -410,5 +410,7 @@ void aio_context_setup(AioContext *ctx) void aio_context_set_poll_params(AioContext *ctx, int64_t max_ns, int64_t grow, int64_t shrink, Error **err= p) { - error_setg(errp, "AioContext polling is not implemented on Windows"); + if (max_ns) { + error_setg(errp, "AioContext polling is not implemented on Windows= "); + } } --=20 1.8.3.1