From nobody Tue Feb 10 16:22:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521915726683178.63752618879005; Sat, 24 Mar 2018 11:22:06 -0700 (PDT) Received: from localhost ([::1]:46725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eznnp-0000Ii-Ql for importer@patchew.org; Sat, 24 Mar 2018 14:22:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eznki-0006kW-Gb for qemu-devel@nongnu.org; Sat, 24 Mar 2018 14:20:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ezngU-0003kN-Lx for qemu-devel@nongnu.org; Sat, 24 Mar 2018 14:18:52 -0400 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]:46149) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ezngU-0003kB-Fm for qemu-devel@nongnu.org; Sat, 24 Mar 2018 14:14:30 -0400 Received: by mail-pl0-x243.google.com with SMTP id f5-v6so9367780plj.13 for ; Sat, 24 Mar 2018 11:14:30 -0700 (PDT) Received: from monty.com (h98.112.139.40.ip.windstream.net. [40.139.112.98]) by smtp.gmail.com with ESMTPSA id k24sm22314646pff.77.2018.03.24.11.14.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 24 Mar 2018 11:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cebw67eAM1i+wzY5kkXQm2qFpl+JQdDvtJVG4UB9Wxc=; b=GSZWzhoPJc5XPx47l42y+kBzFyXVNs4Iu+82guyoMy28iBZsZUu8s6LTCxasjsY+DF /hYcOYS9CbquBN8JEJF/9spLvWiKw3dF/J6IUyOrJ2uvBF4G6pwP0IDDGElTiHuWsFqi Cw7afkE+fX0Ng2xP43KTd6DgkaVTJ8u/qLQH4hFSxnjt8JO5TFJycVBmR/Or5Ird8TQE Z47VTXv/5EMNVjHd4SKTJQfkHkuuwIMXx1jzayfuUrfmYEuunFtRtV2+ayieegxwS6xQ pZfeyw2qlUsQy8sTHncFouypTi0SwieSjwVZ81BeSbsOYIfmSsXA1Bf3wqxNqXCSZoNx zWIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cebw67eAM1i+wzY5kkXQm2qFpl+JQdDvtJVG4UB9Wxc=; b=mV0v2vzus3QN1wg7S52BqYpnsvTkfsdBdlOQF9mpDlvQVOs/hwsFp7uR5o5pUA5yXj /fHH4YxY0+batgcR3ieFZB1bclPTyQO9+0G0pb5OLHtUt6ULpk5uzbxnNdhwvulHxMMh XfEsJnQndiOB2TUWfBRQ1GpOdKLNB0qLQ4UNMEZaCd+aym3IhsDiJPO5QZwm07+urlUu PjM1m9v0BXVgjg8GhLdeN07D1nHBXNTtSw1UvHjH78tCOJCLyBZWYkA391aFBUqRrGMj y7Hu8FmNtjY3xP7bzghKw23AdqGFE5xLbq3jnRo3H50NA+/7Zy8CEECTibLBHSyqENbo oANw== X-Gm-Message-State: AElRT7E8aH24rBu5Dcr5xY6kuo8THR4Gf+GzjcExqR/Yg7O8gPvhKgFD RVKYLfa6PtoWtA4RPk9CqiJU6moqSvQ= X-Google-Smtp-Source: AG47ELs7EtfJ29Jva/gVR+NvTrHscvTxtHp/r9XqQKeELSArV/dTa+zdylLqFTon02oX44BwOcF7Qg== X-Received: by 2002:a17:902:b10c:: with SMTP id q12-v6mr34998576plr.197.1521915269489; Sat, 24 Mar 2018 11:14:29 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Sat, 24 Mar 2018 11:13:31 -0700 Message-Id: <1521915220-65389-6-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1521915220-65389-1-git-send-email-mjc@sifive.com> References: <1521915220-65389-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::243 Subject: [Qemu-devel] [PATCH v6 14/26] RISC-V: Use memory_region_is_ram in pte update X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, Michael Clark , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" After reading cpu_physical_memory_write and friends, it seems that memory_region_is_ram is a more appropriate interface, and matches the intent of the code that is calling it. Cc: Sagar Karandikar Cc: Bastian Koppelmann Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- target/riscv/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/helper.c b/target/riscv/helper.c index 9010620..b2e3f45 100644 --- a/target/riscv/helper.c +++ b/target/riscv/helper.c @@ -234,7 +234,7 @@ restart: hwaddr l =3D sizeof(target_ulong), addr1; mr =3D address_space_translate(cs->as, pte_addr, &addr1, &l, false); - if (memory_access_is_direct(mr, true)) { + if (memory_region_is_ram(mr)) { target_ulong *pte_pa =3D qemu_map_ram_ptr(mr->ram_block, addr1); #if TCG_OVERSIZED_GUEST --=20 2.7.0