From nobody Tue Feb 10 16:22:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521915900054633.3351684080352; Sat, 24 Mar 2018 11:25:00 -0700 (PDT) Received: from localhost ([::1]:46754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eznqZ-000309-AY for importer@patchew.org; Sat, 24 Mar 2018 14:24:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40311) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eznku-0006tq-7k for qemu-devel@nongnu.org; Sat, 24 Mar 2018 14:20:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eznga-0003nc-Cs for qemu-devel@nongnu.org; Sat, 24 Mar 2018 14:19:04 -0400 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]:36964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eznga-0003mv-6Q for qemu-devel@nongnu.org; Sat, 24 Mar 2018 14:14:36 -0400 Received: by mail-pl0-x242.google.com with SMTP id w12-v6so9376648plp.4 for ; Sat, 24 Mar 2018 11:14:36 -0700 (PDT) Received: from monty.com (h98.112.139.40.ip.windstream.net. [40.139.112.98]) by smtp.gmail.com with ESMTPSA id k24sm22314646pff.77.2018.03.24.11.14.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 24 Mar 2018 11:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hd/yhk1mRLDT2WAL6LhvHkcI9lNEqFu50q34yfE+BSM=; b=XademxMCGwKgtEn5DpTwSASiu9cRPgZWIExPoQgWSgDTdcgczq3yXgp+zffA1N1ROD GlLlktfVKS74OZfv2KM5oVPG3hdyAJ+3nXGpEn8dZec7fyEuoro6VPkXdwlSZDGlzqiY jbIeC3nWUtVNKlHp02xkystnAZBroCR9M+wrEDpJsddGRMeKumufz9lYWnCl7Ggx3Ce0 h+GbZPTKFb6c8SmDjowskxdU+v5/ByWWpC4tcZ4CMgi3qpw/TisNEm/hF4V4aqRD2T/q dYg3odsIzuRDLbgXySMqYekgeOsTRxl8i/ekg2R5urRzwKZb0rV1Ift8q1RsGJWFPa2o hGbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hd/yhk1mRLDT2WAL6LhvHkcI9lNEqFu50q34yfE+BSM=; b=Bup15ciHaH+L5eov83jqMOCOq+Z8vbf1K/lZDjoPujO3bRxb1P50LuJ4G55U4O8VhT mN2+5Wuo7BPL9ypn3iXO00Sip1SpPORA8tqNdkRIizu+kQOme8slLpZIVj+4s9lAZGFO qgVGUM59PcWiq1hwJc1UHCqqcth/UfIRVx/qJiAK3Smy62EttMuBwfpLVVlYG83GpTz5 pib/oAE61en20t3ahidk2QcJf6JrvUrM54B0MQ+XdK5XlrDBoKJTaYICHql5flMdDeHA jVXPYWeXNKZuhqQu04kWhgrPpxsGha5Dp0u2M7M75yjdmiu8lkzuEgrtOAteLZeeO/4H a5rQ== X-Gm-Message-State: AElRT7F36gnPj30pl00l8Pgdd4K6nfG4aW57rHmeMQHN5gyxyXeL9xq3 ug+G2hBtOL38E0a8ly85/gz9U/Z/uGE= X-Google-Smtp-Source: AG47ELt5GmBJBiej82e96u6XkilNqpxaZJlkzZ+mjqIfMN5s5gmwMaYozosG7fdYTGL/sa1S1/oQeA== X-Received: by 2002:a17:902:887:: with SMTP id 7-v6mr32690854pll.319.1521915275271; Sat, 24 Mar 2018 11:14:35 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Sat, 24 Mar 2018 11:13:37 -0700 Message-Id: <1521915220-65389-12-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1521915220-65389-1-git-send-email-mjc@sifive.com> References: <1521915220-65389-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::242 Subject: [Qemu-devel] [PATCH v6 23/26] RISC-V: Clear mtval/stval on exceptions without info X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, Michael Clark , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" mtval/stval must be set on all exceptions but zero is a legal value if there is no exception specific info. Placing the instruction bytes for illegal instruction exceptions in mtval/stval is an optional feature and is currently not supported by QEMU RISC-V. Cc: Sagar Karandikar Cc: Bastian Koppelmann Signed-off-by: Palmer Dabbelt Signed-off-by: Michael Clark --- target/riscv/helper.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/target/riscv/helper.c b/target/riscv/helper.c index b2e3f45..0d802a8 100644 --- a/target/riscv/helper.c +++ b/target/riscv/helper.c @@ -489,6 +489,10 @@ void riscv_cpu_do_interrupt(CPUState *cs) ": badaddr 0x" TARGET_FMT_lx, env->mhartid, env->badad= dr); } env->sbadaddr =3D env->badaddr; + } else { + /* otherwise we must clear sbadaddr/stval + * todo: support populating stval on illegal instructions */ + env->sbadaddr =3D 0; } =20 target_ulong s =3D env->mstatus; @@ -510,6 +514,10 @@ void riscv_cpu_do_interrupt(CPUState *cs) ": badaddr 0x" TARGET_FMT_lx, env->mhartid, env->badad= dr); } env->mbadaddr =3D env->badaddr; + } else { + /* otherwise we must clear mbadaddr/mtval + * todo: support populating mtval on illegal instructions */ + env->mbadaddr =3D 0; } =20 target_ulong s =3D env->mstatus; --=20 2.7.0