From nobody Sat Oct 25 23:33:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521566391231154.92580861863826; Tue, 20 Mar 2018 10:19:51 -0700 (PDT) Received: from localhost ([::1]:50834 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyKvK-0004Zy-91 for importer@patchew.org; Tue, 20 Mar 2018 13:19:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyKtJ-0003PL-Iq for qemu-devel@nongnu.org; Tue, 20 Mar 2018 13:17:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyKtG-0002RR-EQ for qemu-devel@nongnu.org; Tue, 20 Mar 2018 13:17:41 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36246 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eyKtG-0002Qu-AG for qemu-devel@nongnu.org; Tue, 20 Mar 2018 13:17:38 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 63ED68424C; Tue, 20 Mar 2018 17:17:36 +0000 (UTC) Received: from redhat.com (ovpn-125-54.rdu2.redhat.com [10.10.125.54]) by smtp.corp.redhat.com (Postfix) with SMTP id 269AE10B0F4C; Tue, 20 Mar 2018 17:17:36 +0000 (UTC) Date: Tue, 20 Mar 2018 19:17:35 +0200 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Message-ID: <1521566230-111929-4-git-send-email-mst@redhat.com> References: <1521566230-111929-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1521566230-111929-1-git-send-email-mst@redhat.com> X-Mutt-Fcc: =sent X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 20 Mar 2018 17:17:36 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 20 Mar 2018 17:17:36 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'mst@redhat.com' RCPT:'' X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.187.233.73 Subject: [Qemu-devel] [PATCH v2 3/3] postcopy: drop unnecessary conditions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Dr. David Alan Gilbert" , Juan Quintela Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We have our own copy of unistd so there is no need to check for symbols present there. Signed-off-by: Michael S. Tsirkin --- migration/postcopy-ram.c | 4 +--- tests/migration-test.c | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index efd7793..027c02c 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -86,7 +86,7 @@ int postcopy_notify(enum PostcopyNotifyReason reason, Err= or **errp) #include /* for __u64 */ #endif =20 -#if defined(__linux__) && defined(__NR_userfaultfd) && defined(CONFIG_EVEN= TFD) +#if defined(__linux__) && defined(CONFIG_EVENTFD) #include #include =20 @@ -97,7 +97,6 @@ int postcopy_notify(enum PostcopyNotifyReason reason, Err= or **errp) * * Returns: true on success * - * __NR_userfaultfd - should be checked before * @features: out parameter will contain uffdio_api.features provided by = kernel * in case of success */ @@ -107,7 +106,6 @@ static bool receive_ufd_features(uint64_t *features) int ufd; bool ret =3D true; =20 - /* if we are here __NR_userfaultfd should exists */ ufd =3D syscall(__NR_userfaultfd, O_CLOEXEC); if (ufd =3D=3D -1) { error_report("%s: syscall __NR_userfaultfd failed: %s", __func__, diff --git a/tests/migration-test.c b/tests/migration-test.c index 422bf1a..e5dcedb 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -32,7 +32,7 @@ bool got_stop; #include #endif =20 -#if defined(__linux__) && defined(__NR_userfaultfd) && defined(CONFIG_EVEN= TFD) +#if defined(__linux__) && defined(CONFIG_EVENTFD) #include #include #include --=20 MST