From nobody Sat Oct 25 13:17:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 15212333209001017.5408602926672; Fri, 16 Mar 2018 13:48:40 -0700 (PDT) Received: from localhost ([::1]:59540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewwHD-0002hi-1J for importer@patchew.org; Fri, 16 Mar 2018 16:48:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eww1V-0005wg-AI for qemu-devel@nongnu.org; Fri, 16 Mar 2018 16:32:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eww1R-0003NJ-Jf for qemu-devel@nongnu.org; Fri, 16 Mar 2018 16:32:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56030) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eww1O-0003JS-T5; Fri, 16 Mar 2018 16:32:15 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C7ACA60F5F; Fri, 16 Mar 2018 20:32:10 +0000 (UTC) Received: from mossypile.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: alindsay@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6633C60F8D; Fri, 16 Mar 2018 20:32:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521232334; bh=H4BJ0JtiSDLo4BBdMiQXq3me1X+hprXnYd3d0940vl8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RUbvExjyK8uuIB8VJB+5uTWvoREr1tMr9eR5rGoSxabntj/CCXdn283Iwmio9nUAv 2E6IgZKQFMaCsryWuq/Gg4DSkM+K+dRA6GBvuQsZpcv0ZP6fdnf5T6TyhpI+T09AgK 8s1HisVoNJdOqaB117htuHkswcby18LAM9VlRG1A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521232329; bh=H4BJ0JtiSDLo4BBdMiQXq3me1X+hprXnYd3d0940vl8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gAakCXulPwI5/b16r8iFbYsRkyuhHfyQozbLA4KU/VFdir0RGn9/2CWuZBhRv8P1b vNT8fVIOcS/fcQ+cRHCwZqsWZeHUylUtohUVHrD78vU7cRQYBoI6S4Z95DLci4DDbt t1zhvsw6uvjMkMin12iZU4plMCMvI94GoxLRLUWA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6633C60F8D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=alindsay@codeaurora.org From: Aaron Lindsay To: qemu-arm@nongnu.org, Peter Maydell , Alistair Francis , Wei Huang , Peter Crosthwaite Date: Fri, 16 Mar 2018 16:31:08 -0400 Message-Id: <1521232280-13089-11-git-send-email-alindsay@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1521232280-13089-1-git-send-email-alindsay@codeaurora.org> References: <1521232280-13089-1-git-send-email-alindsay@codeaurora.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 198.145.29.96 Subject: [Qemu-devel] [PATCH v3 10/22] target/arm: Allow EL change hooks to do IO X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Spradling , qemu-devel@nongnu.org, Digant Desai Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" During code generation, surround CPSR writes and exception returns which call the EL change hooks with gen_io_start/end. The immediate need is for the PMU to access the clock and icount during EL change to support mode filtering. Signed-off-by: Aaron Lindsay --- target/arm/translate-a64.c | 2 ++ target/arm/translate.c | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 31ff047..e1ae676 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -1919,7 +1919,9 @@ static void disas_uncond_b_reg(DisasContext *s, uint3= 2_t insn) unallocated_encoding(s); return; } + gen_io_start(); gen_helper_exception_return(cpu_env); + gen_io_end(); /* Must exit loop to check un-masked IRQs */ s->base.is_jmp =3D DISAS_EXIT; return; diff --git a/target/arm/translate.c b/target/arm/translate.c index ba6ab7d..fd5871e 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -4536,7 +4536,9 @@ static void gen_rfe(DisasContext *s, TCGv_i32 pc, TCG= v_i32 cpsr) * appropriately depending on the new Thumb bit, so it must * be called after storing the new PC. */ + gen_io_start(); gen_helper_cpsr_write_eret(cpu_env, cpsr); + gen_io_end(); tcg_temp_free_i32(cpsr); /* Must exit loop to check un-masked IRQs */ s->base.is_jmp =3D DISAS_EXIT; @@ -9828,7 +9830,9 @@ static void disas_arm_insn(DisasContext *s, unsigned = int insn) if (exc_return) { /* Restore CPSR from SPSR. */ tmp =3D load_cpu_field(spsr); + gen_io_start(); gen_helper_cpsr_write_eret(cpu_env, tmp); + gen_io_end(); tcg_temp_free_i32(tmp); /* Must exit loop to check un-masked IRQs */ s->base.is_jmp =3D DISAS_EXIT; --=20 Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, = Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.