From nobody Sat Oct 25 13:17:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521233156250348.33538933905515; Fri, 16 Mar 2018 13:45:56 -0700 (PDT) Received: from localhost ([::1]:59528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewwEd-0000jm-CS for importer@patchew.org; Fri, 16 Mar 2018 16:45:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eww1Q-0005sI-TV for qemu-devel@nongnu.org; Fri, 16 Mar 2018 16:32:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eww1P-0003Kh-Es for qemu-devel@nongnu.org; Fri, 16 Mar 2018 16:32:16 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55930) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eww1M-0003Fs-9W; Fri, 16 Mar 2018 16:32:12 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0D1BC60D81; Fri, 16 Mar 2018 20:32:09 +0000 (UTC) Received: from mossypile.qualcomm.com (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: alindsay@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 25E2660FA8; Fri, 16 Mar 2018 20:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521232331; bh=3l8vY/oVAgpFoTIYeZx9r5HsOKCzalxyT4ouiCTQrDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P5A8F1Ng+psp1ZUQNkkDAGGtgQMDDXvyMB6btZUVEvhfEB+NkhNt/37hGEF2mavfI R5ZmcPIKVloJISsHOfMrk1av+6pU+sUQciUkpMeym4alHtxp2tNsByB9K9EZWLg4q9 QiPVTbCGOOJ3pJsJWXgqsAuxl1TfdanFbueJrwtM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521232328; bh=3l8vY/oVAgpFoTIYeZx9r5HsOKCzalxyT4ouiCTQrDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oonkuxFkGOylWKywpPflIeEk9njcW5WQUc9dXVSAAEBqmqDlkl5Hp9QWl/2Oe4r32 sWNdmwfyn5htQdAcms8gFp0KbRz/mYjafHH42c9nd8Ri0cj/lrsazAi5cmgx0AKhBp 6z8+ifKsXzxUleUErHSdjy6GoKnkr5Tfuum97YqU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 25E2660FA8 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=alindsay@codeaurora.org From: Aaron Lindsay To: qemu-arm@nongnu.org, Peter Maydell , Alistair Francis , Wei Huang , Peter Crosthwaite Date: Fri, 16 Mar 2018 16:31:07 -0400 Message-Id: <1521232280-13089-10-git-send-email-alindsay@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1521232280-13089-1-git-send-email-alindsay@codeaurora.org> References: <1521232280-13089-1-git-send-email-alindsay@codeaurora.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 198.145.29.96 Subject: [Qemu-devel] [PATCH v3 09/22] target/arm: Add pre-EL change hooks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Spradling , qemu-devel@nongnu.org, Digant Desai Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Because the design of the PMU requires that the counter values be converted between their delta and guest-visible forms for mode filtering, an additional hook which occurs before the EL is changed is necessary. Signed-off-by: Aaron Lindsay --- target/arm/cpu.c | 13 +++++++++++++ target/arm/cpu.h | 12 ++++++++---- target/arm/helper.c | 14 ++++++++------ target/arm/internals.h | 7 +++++++ target/arm/op_helper.c | 8 ++++++++ 5 files changed, 44 insertions(+), 10 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 5f782bf..a2cb21e 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -55,6 +55,18 @@ static bool arm_cpu_has_work(CPUState *cs) | CPU_INTERRUPT_EXITTB); } =20 +void arm_register_pre_el_change_hook(ARMCPU *cpu, ARMELChangeHookFn *hook, + void *opaque) +{ + ARMELChangeHook *entry; + entry =3D g_malloc0(sizeof (*entry)); + + entry->hook =3D hook; + entry->opaque =3D opaque; + + QLIST_INSERT_HEAD(&cpu->pre_el_change_hooks, entry, node); +} + void arm_register_el_change_hook(ARMCPU *cpu, ARMELChangeHookFn *hook, void *opaque) { @@ -747,6 +759,7 @@ static void arm_cpu_realizefn(DeviceState *dev, Error *= *errp) return; } =20 + QLIST_INIT(&cpu->pre_el_change_hooks); QLIST_INIT(&cpu->el_change_hooks); =20 /* Some features automatically imply others: */ diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 3b45d3d..b0ef727 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -832,6 +832,7 @@ struct ARMCPU { */ bool cfgend; =20 + QLIST_HEAD(, ARMELChangeHook) pre_el_change_hooks; QLIST_HEAD(, ARMELChangeHook) el_change_hooks; =20 int32_t node_id; /* NUMA node this CPU belongs to */ @@ -2895,12 +2896,15 @@ static inline AddressSpace *arm_addressspace(CPUSta= te *cs, MemTxAttrs attrs) #endif =20 /** + * arm_register_pre_el_change_hook: * arm_register_el_change_hook: - * Register a hook function which will be called back whenever this - * CPU changes exception level or mode. The hook function will be - * passed a pointer to the ARMCPU and the opaque data pointer passed - * to this function when the hook was registered. + * Register a hook function which will be called back before or after this= CPU + * changes exception level or mode. The hook function will be passed a poi= nter + * to the ARMCPU and the opaque data pointer passed to this function when = the + * hook was registered. */ +void arm_register_pre_el_change_hook(ARMCPU *cpu, ARMELChangeHookFn *hook, + void *opaque); void arm_register_el_change_hook(ARMCPU *cpu, ARMELChangeHookFn *hook, void *opaque); =20 diff --git a/target/arm/helper.c b/target/arm/helper.c index 5d5c738..50eaed7 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -8253,6 +8253,14 @@ void arm_cpu_do_interrupt(CPUState *cs) return; } =20 + /* Hooks may change global state so BQL should be held, also the + * BQL needs to be held for any modification of + * cs->interrupt_request. + */ + g_assert(qemu_mutex_iothread_locked()); + + arm_call_pre_el_change_hook(cpu); + assert(!excp_is_internal(cs->exception_index)); if (arm_el_is_aa64(env, new_el)) { arm_cpu_do_interrupt_aarch64(cs); @@ -8260,12 +8268,6 @@ void arm_cpu_do_interrupt(CPUState *cs) arm_cpu_do_interrupt_aarch32(cs); } =20 - /* Hooks may change global state so BQL should be held, also the - * BQL needs to be held for any modification of - * cs->interrupt_request. - */ - g_assert(qemu_mutex_iothread_locked()); - arm_call_el_change_hook(cpu); =20 if (!kvm_enabled()) { diff --git a/target/arm/internals.h b/target/arm/internals.h index 7df3eda..6ea6766 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -728,6 +728,13 @@ void arm_cpu_do_transaction_failed(CPUState *cs, hwadd= r physaddr, MemTxResult response, uintptr_t retaddr= ); =20 /* Call any registered EL change hooks */ +static inline void arm_call_pre_el_change_hook(ARMCPU *cpu) +{ + ARMELChangeHook *hook, *next; + QLIST_FOREACH_SAFE(hook, &cpu->pre_el_change_hooks, node, next) { + hook->hook(cpu, hook->opaque); + } +} static inline void arm_call_el_change_hook(ARMCPU *cpu) { ARMELChangeHook *hook, *next; diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c index 7a88fd2..be417ce 100644 --- a/target/arm/op_helper.c +++ b/target/arm/op_helper.c @@ -496,6 +496,10 @@ void HELPER(cpsr_write)(CPUARMState *env, uint32_t val= , uint32_t mask) /* Write the CPSR for a 32-bit exception return */ void HELPER(cpsr_write_eret)(CPUARMState *env, uint32_t val) { + qemu_mutex_lock_iothread(); + arm_call_pre_el_change_hook(arm_env_get_cpu(env)); + qemu_mutex_unlock_iothread(); + cpsr_write(env, val, CPSR_ERET_MASK, CPSRWriteExceptionReturn); =20 /* Generated code has already stored the new PC value, but @@ -1013,6 +1017,10 @@ void HELPER(exception_return)(CPUARMState *env) goto illegal_return; } =20 + qemu_mutex_lock_iothread(); + arm_call_pre_el_change_hook(arm_env_get_cpu(env)); + qemu_mutex_unlock_iothread(); + if (!return_to_aa64) { env->aarch64 =3D 0; /* We do a raw CPSR write because aarch64_sync_64_to_32() --=20 Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, = Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.