From nobody Sat Oct 25 21:46:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 152122989513932.998665628755134; Fri, 16 Mar 2018 12:51:35 -0700 (PDT) Received: from localhost ([::1]:59240 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewvO1-0006CW-U6 for importer@patchew.org; Fri, 16 Mar 2018 15:51:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewvFH-0007Th-5M for qemu-devel@nongnu.org; Fri, 16 Mar 2018 15:42:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewvFD-0003l5-2Z for qemu-devel@nongnu.org; Fri, 16 Mar 2018 15:42:31 -0400 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:37687) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ewvFC-0003ki-SW for qemu-devel@nongnu.org; Fri, 16 Mar 2018 15:42:26 -0400 Received: by mail-pf0-x242.google.com with SMTP id h11so4548144pfn.4 for ; Fri, 16 Mar 2018 12:42:26 -0700 (PDT) Received: from monty.com ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id k24sm13780469pff.77.2018.03.16.12.42.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Mar 2018 12:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Loi43iu8ZbpA0eJCNpzVAU/Pkr/kAUWZZsWzzFf6NpA=; b=JlYeCZGMlhPrc8j2ouHoG44ui8Ad89HUZ41hk3AR+LKUpzX5lC5eZgEZJDLGgNvDsk +fKLxS6VXwc3o3BOgz+ebR8yYvhX5mFsiWRCsvaGbu5PXfQoZOBH9r2AeMqa+c5P9PSB wtrd67FLBNreAWbZOoSYPAIqAbP6J88eSiSMulGHPgX4JG5kWa+jfGT8wizBttubAzdQ tbaCFuR8vvl9vLvoe7fZRCC6EhMQoZOVE0VuyUvsUgKMEmYbZAGIK00OgtRHCZ3FsqjY y2myt2Q2E+nDe13EuPCqa9Cp5k8GmcfsaeGsnvk/gfP49g7vdf5gH7nf6W82FpeCLUwh /VPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Loi43iu8ZbpA0eJCNpzVAU/Pkr/kAUWZZsWzzFf6NpA=; b=lOmP+P4RyuQJqCyYjDG87DfoOU098cwVv7gyfsptpG2H6HxGxFNhRUFcCGxHGMSP4g WRGGXVzUytfR/D4703t5FGUjxszpVRcn9sSx0AQ5PTY8MVUHUhzPBsu0rIAap0TY/JZh 5xULoI9mhnaxKfBi2qjFpo1faKurS+khlu1xlDamB44Tx41YzZghPpRot3Du/8EfwdbE 0Y/e29fbpsyyM2Kf3AvQk8koWOvZfvCvN5xVQtqZeP6GMSY3Ww+CayBK6GqkhXRY68BG eruADUiM+q3sdSqXxe+mxM4DBze70lGUGqR9WiVYPOfQWCJNqGwqwMjzEw4UZZeO+OW3 gtsQ== X-Gm-Message-State: AElRT7EXsD5vZM0zokIEH7C0d5coludfGKWluofN/LDZBvw7cuvbwBsz MFuTiF0yUEaO388ChijebSyXTFiVljY= X-Google-Smtp-Source: AG47ELuuix078tay+vCQkSZcGHU33jZ2df/biChnu5rOHkn4GsDdl7DLld9fBHRuSqhOSCLAKic/PA== X-Received: by 10.99.42.83 with SMTP id q80mr2415996pgq.115.1521229345824; Fri, 16 Mar 2018 12:42:25 -0700 (PDT) From: Michael Clark To: qemu-devel@nongnu.org Date: Fri, 16 Mar 2018 12:41:07 -0700 Message-Id: <1521229281-73637-11-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1521229281-73637-1-git-send-email-mjc@sifive.com> References: <1521229281-73637-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::242 Subject: [Qemu-devel] [PATCH v3 10/24] RISC-V: Hold rcu_read_lock when accessing memory X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: patches@groups.riscv.org, Michael Clark , Palmer Dabbelt , Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From reading other code that accesses memory regions directly, it appears that the rcu_read_lock needs to be held. Note: the original code for accessing RAM directly was added because there is no other way to use atomic_cmpxchg on guest physical address space. Cc: Sagar Karandikar Cc: Bastian Koppelmann Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- target/riscv/helper.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/target/riscv/helper.c b/target/riscv/helper.c index 02cbcea..e71633a 100644 --- a/target/riscv/helper.c +++ b/target/riscv/helper.c @@ -209,6 +209,9 @@ restart: as the PTE is no longer valid */ MemoryRegion *mr; hwaddr l =3D sizeof(target_ulong), addr1; + enum { success, translate_fail, restart_walk} action =3D s= uccess; + + rcu_read_lock(); mr =3D address_space_translate(cs->as, pte_addr, &addr1, &l, false); if (memory_access_is_direct(mr, true)) { @@ -222,7 +225,7 @@ restart: target_ulong old_pte =3D atomic_cmpxchg(pte_pa, pte, updated_pte); if (old_pte !=3D pte) { - goto restart; + action =3D restart_walk; } else { pte =3D updated_pte; } @@ -230,7 +233,14 @@ restart: } else { /* misconfigured PTE in ROM (AD bits are not preset) or * PTE is in IO space and can't be updated atomically = */ - return TRANSLATE_FAIL; + action =3D translate_fail; + } + rcu_read_unlock(); + + switch (action) { + case success: break; + case translate_fail: return TRANSLATE_FAIL; + case restart_walk: goto restart; } } =20 --=20 2.7.0