From nobody Sat Oct 25 11:05:07 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1521144504338273.8028626427563; Thu, 15 Mar 2018 13:08:24 -0700 (PDT) Received: from localhost ([::1]:53185 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewZAb-0005X5-UO for importer@patchew.org; Thu, 15 Mar 2018 16:08:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ewZ9j-0005EM-22 for qemu-devel@nongnu.org; Thu, 15 Mar 2018 16:07:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ewZ9f-0000C8-QE for qemu-devel@nongnu.org; Thu, 15 Mar 2018 16:07:18 -0400 Received: from smtp52.i.mail.ru ([94.100.177.112]:39354) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ewZ9f-0000An-Er for qemu-devel@nongnu.org; Thu, 15 Mar 2018 16:07:15 -0400 Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1ewZ9b-00086t-NP; Thu, 15 Mar 2018 23:07:12 +0300 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mail.ru; s=mail2; h=Message-Id:Date:Subject:Cc:To:From; bh=lU/j2WyY+P4dXQZ07S2axMzh102PZl3fZPC4OLZ/wEU=; b=KQhUylr5EPIPpP9i/3xve6M//ARrMJck0E4CwNncn8DtQ63PezsCipCY20uqQ5KOIi8WGEFQXxUhXPmH+N1HunD9NYg3nu4/Hjb1vm6xMsPnv0gz6R4p3jVfibH0zu8HxyoLXRJAoM8RWHTDSBMxFDZ/hJZOMjKCcryF8DsYE3Q=; To: Jason Wang Date: Thu, 15 Mar 2018 23:06:32 +0300 Message-Id: <1521144392-26203-1-git-send-email-jusual@mail.ru> X-Mailer: git-send-email 2.1.4 Authentication-Results: smtp52.i.mail.ru; auth=pass smtp.auth=jusual@mail.ru smtp.mailfrom=jusual@mail.ru X-7FA49CB5: 0D63561A33F958A58D36DAB6E8A6D906A0599462F7EEE9411A43441FEBAC7E74725E5C173C3A84C3BBEB9517EB7DA65B0FCB30FBB960938BCC4B623DB76FBBCBC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0FF045C6A0F83C8214574AF45C6390F7469DAA53EE0834AAEE X-Mailru-Sender: E03EFFB74E926B2DFC3B87178F5C03BE758088A96B56B2F7F0D1DED40481EC886F956CAC0F52A8E57C4160E8B47E48163DDE9B364B0DF2898CB68AF7A628805D594FB4C9F0DBF412AE208404248635DF X-Mras: OK X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 94.100.177.112 Subject: [Qemu-devel] [PATCH] net/vde: print error on vde_open() failure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Julia Suvorova via Qemu-devel Reply-To: Julia Suvorova Cc: Jim Mussared , Stefan Hajnoczi , qemu-devel@nongnu.org, Markus Armbruster , Joel Stanley , Julia Suvorova Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Despite the fact that now when the initialization of vde fails, qemu does not end silently, no informative error is printed. The patch generates an error and pushes it through the calling function. Related bug: https://bugs.launchpad.net/qemu/+bug/676029 Signed-off-by: Julia Suvorova Reviewed-by: Stefan Hajnoczi --- net/vde.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/vde.c b/net/vde.c index e50e5d6..99189cc 100644 --- a/net/vde.c +++ b/net/vde.c @@ -30,6 +30,7 @@ #include "qemu-common.h" #include "qemu/option.h" #include "qemu/main-loop.h" +#include "qapi/error.h" =20 typedef struct VDEState { NetClientState nc; @@ -76,7 +77,7 @@ static NetClientInfo net_vde_info =3D { =20 static int net_vde_init(NetClientState *peer, const char *model, const char *name, const char *sock, - int port, const char *group, int mode) + int port, const char *group, int mode, Error **err= p) { NetClientState *nc; VDEState *s; @@ -92,6 +93,7 @@ static int net_vde_init(NetClientState *peer, const char = *model, =20 vde =3D vde_open(init_sock, (char *)"QEMU", &args); if (!vde){ + error_setg_errno(errp, errno, "Could not open vde"); return -1; } =20 @@ -112,7 +114,6 @@ static int net_vde_init(NetClientState *peer, const cha= r *model, int net_init_vde(const Netdev *netdev, const char *name, NetClientState *peer, Error **errp) { - /* FIXME error_setg(errp, ...) on failure */ const NetdevVdeOptions *vde; =20 assert(netdev->type =3D=3D NET_CLIENT_DRIVER_VDE); @@ -120,7 +121,7 @@ int net_init_vde(const Netdev *netdev, const char *name, =20 /* missing optional values have been initialized to "all bits zero" */ if (net_vde_init(peer, "vde", name, vde->sock, vde->port, vde->group, - vde->has_mode ? vde->mode : 0700) =3D=3D -1) { + vde->has_mode ? vde->mode : 0700, errp) =3D=3D -1) { return -1; } =20 --=20 2.1.4