From nobody Tue Feb 10 00:58:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=hotmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520990719525647.2007072355287; Tue, 13 Mar 2018 18:25:19 -0700 (PDT) Received: from localhost ([::1]:43914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evvAM-0003yt-LJ for importer@patchew.org; Tue, 13 Mar 2018 21:25:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evv5i-0000M2-65 for qemu-devel@nongnu.org; Tue, 13 Mar 2018 21:20:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evv5g-0006NR-PQ for qemu-devel@nongnu.org; Tue, 13 Mar 2018 21:20:30 -0400 Received: from mga18.intel.com ([134.134.136.126]:28906) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1evv5g-0006Hx-F6 for qemu-devel@nongnu.org; Tue, 13 Mar 2018 21:20:28 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 18:20:28 -0700 Received: from natrouter.sh.intel.com (HELO robinhe-hp.domain) ([10.239.13.3]) by orsmga001.jf.intel.com with ESMTP; 13 Mar 2018 18:20:26 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,466,1515484800"; d="scan'208";a="38632822" From: junyan.he@hotmail.com To: qemu-devel@nongnu.org Date: Wed, 14 Mar 2018 09:20:11 +0800 Message-Id: <1520990418-28258-4-git-send-email-junyan.he@hotmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1520990418-28258-1-git-send-email-junyan.he@hotmail.com> References: <1520990418-28258-1-git-send-email-junyan.he@hotmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.126 Subject: [Qemu-devel] [PATCH 03/10] RFC: Implement save and support snapshot dependency in block driver layer. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, famz@redhat.com, crosthwaite.peter@gmail.com, quintela@redhat.com, dgilbert@redhat.com, mreitz@redhat.com, Junyan He , pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Junyan He Signed-off-by: Junyan He --- block/snapshot.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ include/block/snapshot.h | 7 +++++++ 2 files changed, 52 insertions(+) diff --git a/block/snapshot.c b/block/snapshot.c index eacc1f1..8cc40ac 100644 --- a/block/snapshot.c +++ b/block/snapshot.c @@ -401,6 +401,51 @@ int bdrv_snapshot_load_tmp_by_id_or_name(BlockDriverSt= ate *bs, return ret; } =20 +int bdrv_snapshot_save_dependency(BlockDriverState *bs, + const char *depend_snapshot_id, + int64_t depend_offset, + int64_t depend_size, + int64_t offset, + Error **errp) +{ + BlockDriver *drv =3D bs->drv; + + if (!drv) { + return -ENOMEDIUM; + } + + if (drv->bdrv_snapshot_save_dependency) { + return drv->bdrv_snapshot_save_dependency(bs, depend_snapshot_id, + depend_offset, depend_si= ze, + offset, errp); + } + + if (bs->file) { + return bdrv_snapshot_save_dependency(bs->file->bs, depend_snapshot= _id, + depend_offset, depend_size, + offset, errp); + } + + return -ENOTSUP; +} + +int bdrv_snapshot_support_dependency(BlockDriverState *bs, int32_t *alignm= ent) +{ + BlockDriver *drv =3D bs->drv; + if (!drv || !bdrv_is_inserted(bs) || bdrv_is_read_only(bs)) { + return 0; + } + + if (drv->bdrv_snapshot_support_dependency) { + return drv->bdrv_snapshot_support_dependency(bs, alignment); + } + + if (bs->file !=3D NULL) { + return bdrv_snapshot_support_dependency(bs->file->bs, alignment); + } + + return -ENOTSUP; +} =20 /* Group operations. All block drivers are involved. * These functions will properly handle dataplane (take aio_context_acquire diff --git a/include/block/snapshot.h b/include/block/snapshot.h index f73d109..e5bf06f 100644 --- a/include/block/snapshot.h +++ b/include/block/snapshot.h @@ -73,6 +73,13 @@ int bdrv_snapshot_load_tmp(BlockDriverState *bs, int bdrv_snapshot_load_tmp_by_id_or_name(BlockDriverState *bs, const char *id_or_name, Error **errp); +int bdrv_snapshot_save_dependency(BlockDriverState *bs, + const char *depend_snapshot_id, + int64_t depend_offset, + int64_t depend_size, + int64_t offset, + Error **errp); +int bdrv_snapshot_support_dependency(BlockDriverState *bs, int32_t *alignm= ent); =20 =20 /* Group operations. All block drivers are involved. --=20 2.7.4