From nobody Sat Oct 25 08:57:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520370744547136.47651611239405; Tue, 6 Mar 2018 13:12:24 -0800 (PST) Received: from localhost ([::1]:58224 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etJsg-0003yd-OK for importer@patchew.org; Tue, 06 Mar 2018 16:12:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etJTc-0006p7-Vr for qemu-devel@nongnu.org; Tue, 06 Mar 2018 15:46:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etJTY-0003fh-3A for qemu-devel@nongnu.org; Tue, 06 Mar 2018 15:46:25 -0500 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]:40907) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etJTX-0003fY-Sl for qemu-devel@nongnu.org; Tue, 06 Mar 2018 15:46:20 -0500 Received: by mail-pl0-x244.google.com with SMTP id i6-v6so12546199plt.7 for ; Tue, 06 Mar 2018 12:46:19 -0800 (PST) Received: from localhost.localdomain (125-237-39-90-fibre.bb.spark.co.nz. [125.237.39.90]) by smtp.gmail.com with ESMTPSA id y6sm39123791pfg.71.2018.03.06.12.46.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Mar 2018 12:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=aVqcjcvGEE61QAr4OyJl5k4f5hpxX7mhbAJQEdBFT3c=; b=Aoh8WrppJfoNUNhoVwlV0lrMfaOJk1Hkg/oQcUAUh3bRbcxswwIakBO5tY4CrKCX6R qSbjSt+Rp7ouGzNxlzK6t93+3i9ucCK47BBAeeB5nlr5L6+tYs86//vscxTOxYMnCEje e8XYEoiTWT0ICiehBYFDQKKxAYG4f8Ooo5jb4R2lFxHBTe9qif68HJ/iBuztaUNBeKNI nT7FRhj6jehmpBWNsxBmuXMo+QDpwSsIdheCr+B2oVgUKfY67Yqv4ns51NtXs929c/TS n3VlWa+Wl1qAS9mwmcADjVEZxmBky+coy0+MB2Sk9mOK89yMcpMYZX7SyNOiY7MhMK0T 4iTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aVqcjcvGEE61QAr4OyJl5k4f5hpxX7mhbAJQEdBFT3c=; b=cR/K7FSSp+vyMKn7Ci/EJRODmm2VnpnNGAvvZMWNnzfFj7kyVWWUgOyYhJh8dTUXO0 ImskSps86sOxXF1AZ5nsH/sLFzmppuA/H1mgug1S9cNU0iE/4BNRLb87kIVchIFZt534 hdMkCcxREe5YBff3bnPb0B9nMiMDhPBr8PEBqy1HlX/I6WuLNlEMg3xuIFCEavoQb5Fr GhVZSoW7brViuPVR47k9NkzwlIi7qx1oX+UDe3LSzzmxK0vwzz4KRNiXjp2ILgdAz0fH wIgvXkSp4MEOOENCynlCSTy/68eIYRPRAF4HTmEWE+RZoh6ZlFn/bMUfeQCAbwPVyG2V MxhQ== X-Gm-Message-State: AElRT7H8p6AiTRunddDKdRu6guDg62K/gC3jNzdxuuvBliADM1VY+qvB tDPNZ6GpUwnNxY1cgcWju+p0CwRiTM4= X-Google-Smtp-Source: AG47ELtUo9E8eFmAFRkeokwpxULjx366KGk6X2Js+TuzvjLYsiJ+EyI4lG7cyZiJaufmH9Q8E8mNmA== X-Received: by 2002:a17:902:6c47:: with SMTP id h7-v6mr8182521pln.445.1520369178885; Tue, 06 Mar 2018 12:46:18 -0800 (PST) From: Michael Clark To: qemu-devel@nongnu.org Date: Wed, 7 Mar 2018 09:43:55 +1300 Message-Id: <1520369037-37977-21-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1520369037-37977-1-git-send-email-mjc@sifive.com> References: <1520369037-37977-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::244 Subject: [Qemu-devel] [PATCH v1 20/22] RISC-V: vectored traps are optional X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Michael Clark , Palmer Dabbelt , Sagar Karandikar , RISC-V Patches Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Vectored traps for asynchrounous interrupts are optional. The mtvec/stvec mode field is WARL and hence does not trap if an illegal value is written. Illegal values are ignored. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- target/riscv/op_helper.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c index f79716a..aa101cc 100644 --- a/target/riscv/op_helper.c +++ b/target/riscv/op_helper.c @@ -262,11 +262,10 @@ void csr_write_helper(CPURISCVState *env, target_ulon= g val_to_write, env->sepc =3D val_to_write; break; case CSR_STVEC: - if (val_to_write & 1) { - qemu_log_mask(LOG_UNIMP, "CSR_STVEC: vectored traps not suppor= ted"); - goto do_illegal; + /* we do not support vectored traps for asynchrounous interrupts *= /=20 + if ((val_to_write & 3) =3D=3D 0) { + env->stvec =3D val_to_write >> 2 << 2; } - env->stvec =3D val_to_write >> 2 << 2; break; case CSR_SCOUNTEREN: env->scounteren =3D val_to_write; @@ -284,11 +283,10 @@ void csr_write_helper(CPURISCVState *env, target_ulon= g val_to_write, env->mepc =3D val_to_write; break; case CSR_MTVEC: - if (val_to_write & 1) { - qemu_log_mask(LOG_UNIMP, "CSR_MTVEC: vectored traps not suppor= ted"); - goto do_illegal; + /* we do not support vectored traps for asynchrounous interrupts *= /=20 + if ((val_to_write & 3) =3D=3D 0) { + env->mtvec =3D val_to_write >> 2 << 2; } - env->mtvec =3D val_to_write >> 2 << 2; break; case CSR_MCOUNTEREN: env->mcounteren =3D val_to_write; --=20 2.7.0