From nobody Sat Oct 25 08:57:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520370086121412.2885131406217; Tue, 6 Mar 2018 13:01:26 -0800 (PST) Received: from localhost ([::1]:58157 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etJi9-0002vX-8w for importer@patchew.org; Tue, 06 Mar 2018 16:01:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etJTI-0006Zs-1J for qemu-devel@nongnu.org; Tue, 06 Mar 2018 15:46:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etJTH-0003af-7k for qemu-devel@nongnu.org; Tue, 06 Mar 2018 15:46:04 -0500 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]:40904) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etJTH-0003aT-24 for qemu-devel@nongnu.org; Tue, 06 Mar 2018 15:46:03 -0500 Received: by mail-pl0-x242.google.com with SMTP id i6-v6so12545788plt.7 for ; Tue, 06 Mar 2018 12:46:02 -0800 (PST) Received: from localhost.localdomain (125-237-39-90-fibre.bb.spark.co.nz. [125.237.39.90]) by smtp.gmail.com with ESMTPSA id y6sm39123791pfg.71.2018.03.06.12.45.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 06 Mar 2018 12:46:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z+L42yDG8RKhwSmiSbpuiCsehanEf+avlrfl/8UVfAM=; b=Y+r/ofgfX8Gz2Rht+0kcAglY4xy8xiTPOzfrnXBM0xLifaZREqyl0Q4pcI+uMF9D/s QVVRXRTSeIDEf8rwhq0kuBTG+nLW/qi5QTpuDRev2jCh78wGRJHJCHySK4rIACHDEIZD JOyw6ACsnOWlrP1CMaBuVV4/wshvLgtnlSuohPJNcijt/CpLUCBc4BPdpwka6/l5KAf8 VuGZpUOy1gqJoWUjnZdRajg/sGw+ceTrswd6S6lm/m0P6fYDmMFRAS2ybMFeNfooHqD3 0YOqoonF2X8w3s25iGZqE/LkucVEnC0L8ScA72QKEu88MFuj7Tmjp5cwC9xbnDqnimqU DfSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z+L42yDG8RKhwSmiSbpuiCsehanEf+avlrfl/8UVfAM=; b=ARgfxrkTc778LuoOQDe+uT47zxaKygWs73EB2UuPv9hIto57dyJHZrBj87ikofxJqk KzmhS+5RWHAILaQ8+tujszvzBAKD+UdBsf7gaJvPZ2zwED188Itl4ELnjQkmx8auAfUy EXnPHZLBlGDGVJpRXe6cXKSIGihZirA1oQIFHRU3w+yXV1kllMyRAlnj0PZGYD7ez5pk um19QfXGoShUYwbwWCYEuxz7q+chbMGyVO8G+oDAADKv20Vri3iPMAEL19FByamCTejQ mWDMl9DQjOsMXI1I2LRobtxCQ0j+G9KI5ZjMDTTmykzx3tAQcNFDmpKpdQympsonnihE NdCg== X-Gm-Message-State: AElRT7H63HnC7IDGkpyNbl6CJ+NfP05qMX5FcCiow46dr0MbirJaLJbV 2z45TY/6nW3ZhqHg7kQZ6adN9mJcCUI= X-Google-Smtp-Source: AG47ELuhZ3vDjnVRJvpP3l2545zi5slB3WDLI2XaOycEgnyYLXYsZT0FedXT1u3UCeN/BcoSFZiEQQ== X-Received: by 2002:a17:902:8a92:: with SMTP id p18-v6mr11106152plo.286.1520369162084; Tue, 06 Mar 2018 12:46:02 -0800 (PST) From: Michael Clark To: qemu-devel@nongnu.org Date: Wed, 7 Mar 2018 09:43:50 +1300 Message-Id: <1520369037-37977-16-git-send-email-mjc@sifive.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1520369037-37977-1-git-send-email-mjc@sifive.com> References: <1520369037-37977-1-git-send-email-mjc@sifive.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::242 Subject: [Qemu-devel] [PATCH v1 15/22] RISC-V: Use memory_region_is_ram in atomic pte X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Michael Clark , Palmer Dabbelt , Sagar Karandikar , RISC-V Patches update Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" After reading cpu_physical_memory_write and friends, it seems that memory_region_is_ram is a more appropriate interface, and matches the intent of the code that is calling it. Signed-off-by: Michael Clark Signed-off-by: Palmer Dabbelt --- target/riscv/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/helper.c b/target/riscv/helper.c index 2165ecb..88551be 100644 --- a/target/riscv/helper.c +++ b/target/riscv/helper.c @@ -235,7 +235,7 @@ restart: rcu_read_lock(); mr =3D address_space_translate(cs->as, pte_addr, &addr1, &l, false); - if (memory_access_is_direct(mr, true)) { + if (memory_region_is_ram(mr)) { target_ulong *pte_pa =3D qemu_map_ram_ptr(mr->ram_block, addr1); #if TCG_OVERSIZED_GUEST --=20 2.7.0