From nobody Sat Oct 25 09:04:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520343656654545.4557219029729; Tue, 6 Mar 2018 05:40:56 -0800 (PST) Received: from localhost ([::1]:55816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCpr-0007wW-OV for importer@patchew.org; Tue, 06 Mar 2018 08:40:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCVl-0005Sj-Sk for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCVj-0006Z3-FX for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:09 -0500 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:39659) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etCVj-0006YA-8H for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:07 -0500 Received: by mail-wr0-x241.google.com with SMTP id w77so20920791wrc.6 for ; Tue, 06 Mar 2018 05:20:07 -0800 (PST) Received: from 640k.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id l38sm25652538wrc.96.2018.03.06.05.20.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 05:20:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=yJhV4FjpGyvDqAF3K5RhnlIZ2zXZ4jJ4bQpOd7SyU3M=; b=cDAliY3nXBkXR+fgKHiXHMojkaLNiHFndnTiI8VVp4mlaaB5beNrZGzlqGY0wCyRgm T9JCYwvemH2BYp2/8wXVkmn1levBmWgrNFCaQDCwCrfWvgRLoRzsAQ5N7Bn9yjdpSytO hSQGZrm6STgizVpgsyuRwE1uUcQtAbMApbrlcGSScg2CapUp1gn5buUtKAsqIltFh9MI h+ezoHGQc53gfEx+mGpnPSwJvgHi53iCzVuMyC8tG4iMw/khZ0CRQAlgxC/Ga4gtARsB +WMbRPAj+/PR+L0OsV8/npFcqlH0zLBYTTiVvJmrCld2apPahAjqXGbYozIn+xGNoCjg o5iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=yJhV4FjpGyvDqAF3K5RhnlIZ2zXZ4jJ4bQpOd7SyU3M=; b=r6aeouVyNwIoezrRCXwdKkiksuhKTeFAnjbrgv013v2HE3BnpbDWZ/1CSqTCTBA5Yn 7msobTYYfEQbyJsTOzInYHmfG7UDx+bwbhjhBWfjfl/IZREnf0FTXAF+nzTXj2GcXYT/ jqQw3te6Aly64r3ohlvBiA7Gu4iDaNpwT14cLTfdXHPbnysBvq7i/od1CPMI60AMumaA VP4scQGDoC6Cc5t25XbDGHI2pLepagCwRPWLaA3VyrgDc3k7Ioe+vmqdB9w3XeapksLS F8iBuUf0YJn/d9ptaVv56P9qoX2/cG+vAd3IRXNetW+LVb8YI4B308QLk2ntZmqncBqj TBaQ== X-Gm-Message-State: APf1xPCcFzgkD2M+pN3S49oJt5Rmqr0JdvbUze5WJDP9X8ZksEVRxqoa gPa2hqWrAlcnnYRGxAcVoKtuFbk4 X-Google-Smtp-Source: AG47ELvTVRIDRRWFeiJULde7WB/HCqWYUlgATeoHPvotKAsFXPJk+GeALhqDtYuVY2RXwOTm/QhI/Q== X-Received: by 10.223.179.82 with SMTP id k18mr16085852wrd.173.1520342405998; Tue, 06 Mar 2018 05:20:05 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Mar 2018 14:19:23 +0100 Message-Id: <1520342370-123606-28-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> References: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL 27/34] Remove unnecessary WHPX __debugbreak(); X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Justin Terry \(VM\)" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Justin Terry (VM) via Qemu-devel" Minor code cleanup. The calls to __debugbreak() are not required and should no longer be used to prevent unnecessary breaks. Signed-off-by: Justin Terry (VM) Message-Id: <1519665216-1078-4-git-send-email-juterry@microsoft.com> Signed-off-by: Paolo Bonzini Signed-off-by: Justin Terry (VM) via Qemu-devel --- target/i386/whpx-all.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c index 969c2f5..14ea732 100644 --- a/target/i386/whpx-all.c +++ b/target/i386/whpx-all.c @@ -364,7 +364,6 @@ static void whpx_set_registers(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to set virtual processor context, hr=3D= %08lx", hr); - __debugbreak(); } =20 return; @@ -391,7 +390,6 @@ static void whpx_get_registers(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to get virtual processor context, hr=3D= %08lx", hr); - __debugbreak(); } =20 /* Indexes for first 16 registers match between HV and QEMU definition= s */ @@ -554,7 +552,6 @@ static HRESULT CALLBACK whpx_emu_getreg_callback( if (FAILED(hr)) { error_report("WHPX: Failed to get virtual processor registers," " hr=3D%08lx", hr); - __debugbreak(); } =20 return hr; @@ -576,7 +573,6 @@ static HRESULT CALLBACK whpx_emu_setreg_callback( if (FAILED(hr)) { error_report("WHPX: Failed to set virtual processor registers," " hr=3D%08lx", hr); - __debugbreak(); } =20 /* @@ -604,7 +600,6 @@ static HRESULT CALLBACK whpx_emu_translate_callback( Gva, TranslateFlags, &res, Gpa); if (FAILED(hr)) { error_report("WHPX: Failed to translate GVA, hr=3D%08lx", hr); - __debugbreak(); } else { *TranslationResult =3D res.ResultCode; } @@ -631,13 +626,11 @@ static int whpx_handle_mmio(CPUState *cpu, WHV_MEMORY= _ACCESS_CONTEXT *ctx) &vcpu->exit_ctx.VpContext, ctx, &emu_status); if (FAILED(hr)) { - __debugbreak(); error_report("WHPX: Failed to parse MMIO access, hr=3D%08lx", hr); return -1; } =20 if (!emu_status.EmulationSuccessful) { - __debugbreak(); error_report("WHPX: Failed to emulate MMIO access"); return -1; } @@ -656,13 +649,11 @@ static int whpx_handle_portio(CPUState *cpu, &vcpu->exit_ctx.VpContext, ctx, &emu_status); if (FAILED(hr)) { - __debugbreak(); error_report("WHPX: Failed to parse PortIO access, hr=3D%08lx", hr= ); return -1; } =20 if (!emu_status.EmulationSuccessful) { - __debugbreak(); error_report("WHPX: Failed to emulate PortMMIO access"); return -1; } @@ -716,7 +707,6 @@ static void whpx_vcpu_pre_run(CPUState *cpu) if (cpu->interrupt_request & CPU_INTERRUPT_SMI) { qemu_mutex_lock_iothread(); cpu->interrupt_request &=3D ~CPU_INTERRUPT_SMI; - __debugbreak(); qemu_mutex_unlock_iothread(); } } @@ -785,7 +775,6 @@ static void whpx_vcpu_pre_run(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to set interrupt state registers," " hr=3D%08lx", hr); - __debugbreak(); } } =20 @@ -812,7 +801,6 @@ static void whpx_vcpu_post_run(CPUState *cpu) if (FAILED(hr)) { error_report("WHPX: Failed to get interrupt state regusters," " hr=3D%08lx", hr); - __debugbreak(); vcpu->interruptable =3D false; return; } --=20 1.8.3.1