From nobody Sat Oct 25 09:04:21 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520343505609758.6871659777636; Tue, 6 Mar 2018 05:38:25 -0800 (PST) Received: from localhost ([::1]:55800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCnQ-0005hr-QS for importer@patchew.org; Tue, 06 Mar 2018 08:38:24 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48264) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCVh-0005Lr-4Q for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCVf-0006W4-UQ for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:05 -0500 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:46334) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etCVf-0006Vd-Nv for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:03 -0500 Received: by mail-wr0-x242.google.com with SMTP id m12so20875546wrm.13 for ; Tue, 06 Mar 2018 05:20:03 -0800 (PST) Received: from 640k.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id l38sm25652538wrc.96.2018.03.06.05.20.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 05:20:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=VpFvYwsFfgx9RfeAoKX1IXH69fx4gFu64k/QPe4d7U0=; b=qyrxP8ONNdffAjXHRZ0JQBhA/ozXwX2U37mU4ADf5J+NxqTeb+aUnzmUXw0ctLPQVA mRHe8TRBh+zi5coR0GLCvRgSol6NOCIHafum+sDNCt09YCwki95cueni3H/gDl/9T/QO eWW1R65kbmJgteYLSfEBmQgg+/gHklKpRcwUxJAj/e+OXZPJIGG3dqtTT4Nrzq5w5ZTd i5lU7kS33l6VSReBhd6OjfTkbJDm0x/hDlmpNRwyVc3DjSrYLzyanAz2dlvswR/7fZeO 4D8y9HxRNd34jLP/z7LHAV7PmVP7tDdHIpNuGwV2rtFObXwgY4oiK20ON0uCoVWDp3na i8qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=VpFvYwsFfgx9RfeAoKX1IXH69fx4gFu64k/QPe4d7U0=; b=tYxAHZTwsvd+UBi51nB1xsAC4Ttn16wL6WitF0KJjM/8dtBG6yG/wBvln2QIx+TtPN ONOlYpNO+ak7v+F9rpWpH3ynsRebNTvqhM+xiKm3IuCVck3MeIixcXSBP2w2NWwei0j4 0y3gu7+cLi+O80hoKrvvXQU7LK/p/cnK3cWIUSYViNLQMZu/RWy1+lV3tD1dbnUeYlzz TjTRM0FMZRNGno/SK0cmyZEHbkhkZuhcIVw35haGZxjPkkjeXJB9a9g/n6b65oQ4W74y K9QxXU7uqj2eAgEZW+VHqs5HVcBHwOfSjRCyY+kSf9LWnBhl0TyWig4e4MIAJ3SuyvSW yPTQ== X-Gm-Message-State: APf1xPAmReobhX/sZmpLkc3fFOOMzXaD4Nryfvvvp22NcjTtwdvpM/5R Y4BIMSqdA8o509zKyoMy3boLEW6x X-Google-Smtp-Source: AG47ELvvXep7vSGQTxlePsdx3z1fmfVZHthbO42hCC+x8pYwDIgbP/7SZeaW1+vmOcjkY8DUyWdPNQ== X-Received: by 10.223.190.134 with SMTP id i6mr15987496wrh.157.1520342402303; Tue, 06 Mar 2018 05:20:02 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Mar 2018 14:19:20 +0100 Message-Id: <1520342370-123606-25-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> References: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PULL 24/34] Revert "build-sys: compile with -Og or -O1 when --enable-debug" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" This reverts commit 906548689e37ab6cca1e93b3f8d9327a4e17e8af. Even with -Og, the debug experience is noticeably worse because gdb shows a lot more "" variables and function arguments. Signed-off-by: Paolo Bonzini --- configure | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/configure b/configure index 7ff00f8..ebbda23 100755 --- a/configure +++ b/configure @@ -5368,19 +5368,8 @@ if test "$gcov" =3D "yes" ; then LDFLAGS=3D"-fprofile-arcs -ftest-coverage $LDFLAGS" elif test "$fortify_source" =3D "yes" ; then CFLAGS=3D"-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3D2 $CFLAGS" -elif test "$debug" =3D "yes"; then - if compile_prog "-Og" ""; then - CFLAGS=3D"-Og $CFLAGS" - elif compile_prog "-O1" ""; then - CFLAGS=3D"-O1 $CFLAGS" - fi - # Workaround GCC false-positive Wuninitialized bugs with Og or O1: - # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D24639 - if cc_has_warning_flag "-Wno-maybe-uninitialized"; then - CFLAGS=3D"-Wno-maybe-uninitialized $CFLAGS" - fi -else - CFLAGS=3D"-O2 $CFLAGS" +elif test "$debug" =3D "no"; then + CFLAGS=3D"-O2 $CFLAGS" fi =20 if test "$have_asan" =3D "yes"; then --=20 1.8.3.1