From nobody Sat Oct 25 09:08:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520343372372812.5292297081655; Tue, 6 Mar 2018 05:36:12 -0800 (PST) Received: from localhost ([::1]:55787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etClH-0003t5-JA for importer@patchew.org; Tue, 06 Mar 2018 08:36:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCVe-0005IY-2X for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCVd-0006Tx-6U for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:02 -0500 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:34506) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etCVd-0006TH-0B for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:01 -0500 Received: by mail-wm0-x244.google.com with SMTP id a20so17994662wmd.1 for ; Tue, 06 Mar 2018 05:20:00 -0800 (PST) Received: from 640k.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id l38sm25652538wrc.96.2018.03.06.05.19.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 05:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=ti1KBCOXk8Zbl/PHNQj4ViY72BfU4+ewc/IR29wGV2g=; b=UU/QUOkSikqx2J+dOal1xoIipIUaMCcKEMdGb5fw2Xdd6o0PL15o2FbVo9TsRvD9ef FSBlPm4XnivK5o5DpE4nsmdYKnvAi3xfH/a1PKxhsL9XjYcusJt90dUX8QrDyGQsVhW2 Aa63EZmvS6h726Xm9mxB/a8ALyso9Qb3Ad8/um4olGB+Wsj+0aK/JZ3Tz6HY+sOi2OGT K4aaTNuAvdI9LFSp6NIf0DpEVg4rdrAtxwYeC2XptuL1eQFnFgWmAO48BXN1nNvH3GlM AQNJ0e/l7tM8u4raypJFotgdm5wEwbv8I1AYghJbULfMzG0gBo5bmhBP53g2pHmDv7UN JYzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=ti1KBCOXk8Zbl/PHNQj4ViY72BfU4+ewc/IR29wGV2g=; b=fO7RJ+n28mn/MhRiQviE9nyAdI0Q24ltgqBuwRuvRJjsqdkNlr5L5499tCSlkBPLur 4ReL+X2rolmY48XDwVHQnk2KhUB+XXTVBM/WTG5QJkQEdG8za199R42VqqgenEkVmQmT AD1Ee088A1WZ+FaPEIDWcicDvOvCmVYCzdXLVNWCY2RYzD7ei44E1BwyGP7kFlwmFgni hqnpy8UopDvFol575QLx08JIZvxEdEwteojc+MzYFXMKUiMOBL9r4TjK5d4Euwr9pvG9 byoxLPQBFIHgExDIRsvtuovpplX5vJp/6125hnNs58XH5XwaETmNMsC81f98N3d+Yd1b +qMg== X-Gm-Message-State: AElRT7GLi+fAy3LF/TRYUNAgsoDhA3xTfzABYRZpfzJ82WdYnzy8USxS O3Mws1YJyUgTl8zd6Hl9r6q4UdeI X-Google-Smtp-Source: AG47ELslbsSTBKXM+4LeteL5FO2KxVFPosyeO7f/ldunMgxgCjbrPVmKynLea4OktVMaHj495zCkqA== X-Received: by 10.28.18.2 with SMTP id 2mr10649566wms.108.1520342399683; Tue, 06 Mar 2018 05:19:59 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Mar 2018 14:19:18 +0100 Message-Id: <1520342370-123606-23-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> References: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::244 Subject: [Qemu-devel] [PULL 22/34] checkpatch: add a warning for basename/dirname X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Julia Suvorova Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Julia Suvorova g_path_get_* do the same as g_strdup(basename/dirname(...)) but without modifying the argument. Signed-off-by: Julia Suvorova Message-Id: <1519987399-19160-1-git-send-email-jusual@mail.ru> Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 1b4b812..a88af61 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2584,6 +2584,11 @@ sub process { ERROR("__func__ should be used instead of gcc specific __FUNCTION__\n" = . $herecurr); } =20 +# recommend g_path_get_* over g_strdup(basename/dirname(...)) + if ($line =3D~ /\bg_strdup\s*\(\s*(basename|dirname)\s*\(/) { + WARN("consider using g_path_get_$1() in preference to g_strdup($1())\n"= . $herecurr); + } + # recommend qemu_strto* over strto* for numeric conversions if ($line =3D~ /\b(strto[^kd].*?)\s*\(/) { ERROR("consider using qemu_$1 in preference to $1\n" . $herecurr); --=20 1.8.3.1