From nobody Sat Oct 25 09:08:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520343039439124.8094345339407; Tue, 6 Mar 2018 05:30:39 -0800 (PST) Received: from localhost ([::1]:55750 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCfu-0007eD-LH for importer@patchew.org; Tue, 06 Mar 2018 08:30:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCVd-0005Hc-4t for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCVb-0006Sy-Vu for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:01 -0500 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:35846) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etCVb-0006Ry-OC for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:59 -0500 Received: by mail-wm0-x242.google.com with SMTP id 188so22105574wme.1 for ; Tue, 06 Mar 2018 05:19:59 -0800 (PST) Received: from 640k.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id l38sm25652538wrc.96.2018.03.06.05.19.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 05:19:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=VXantA8UjXNTtilrbmOx9OPb5EbYCqUZhoTFibKxx44=; b=SxDUfO79FFtwczRpjaRQ/EjMA0Px6z6yJ+2UYdhmDrfYOCdjoxx1D4FKIWaqj5W2bc secRMyx36esnfSmVs7mfiaftXLkLWSPtsMIBnd4Q45/wUMScHqzH+dpNKSJqO4XLEWSU 3qwwbr/5iAZmcQnP2kUT/KMcGSdeqbeCBbqagUxMRAG5urEx1vioRf+YWz7FzZuxNyvU URtBzN7x7aj+K2vA/kLRr9iKzQeyjwxYjPMwWUL+yWWZcuZG2zgJ8wTPvV5nFELcconA BCxKj9AACuVw+gPDxX11jxrDMtu5fWwtd6GEkk6UduYthinwUyFmAguZG2LUAFRxoeCH ADKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=VXantA8UjXNTtilrbmOx9OPb5EbYCqUZhoTFibKxx44=; b=Z+6PWtih6SZiagJf+4UAWeM7DKlIQaIRYC4Qh1lu318sVfjElYei9W4qGTEK09cIwu iLMsV1g2oBL/NLWU93EioL6AvLU50pGd90EldtXjM/tkm/tYyBOpsdH/J2lbFeoTtRX7 w8Ooqd1nTPsRfcbI4/hnXckauYgiXLwi9unFpGRpswKEl7UFjmBuf4UT0U4yrTLfMOvu RRRVDmZ0dd4+jb9v1MDAX0T/yUTybb8dvLLIT9QIS+EL0xWy3cQyTj4Qs4BHywvwxOBc DdXfE3k+JCt5MErqpmq06IylxaJmtS4rBBzN67rjCzdWSC3NeTFwK6jXFcWnwrbLODwC E12Q== X-Gm-Message-State: AElRT7HNGUtoKcQbsOVOcVyOlbgHpfqz27T1nBARiqs5tT9NavlV2gOU 9/Ae9tIsQmL4cTNunfI3rQUBN2X3 X-Google-Smtp-Source: AG47ELtKekoMR1mpStKVRRuDyelgwrK1P28XkxjQDqMrje09bhBbz2pJGqTw/HSQc2JuHUbDQQoMwg== X-Received: by 10.28.34.3 with SMTP id i3mr10540553wmi.121.1520342398472; Tue, 06 Mar 2018 05:19:58 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Mar 2018 14:19:17 +0100 Message-Id: <1520342370-123606-22-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> References: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PULL 21/34] address_space_rw: address_space_to_flatview needs RCU lock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" address_space_rw is calling address_space_to_flatview but it can be called outside the RCU lock. To fix it, transform flatview_rw into address_space_rw, since flatview_rw is otherwise unused. Reviewed-by: Alexey Kardashevskiy Signed-off-by: Paolo Bonzini --- exec.c | 28 ++++++++++------------------ 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/exec.c b/exec.c index bffb959..604f03c 100644 --- a/exec.c +++ b/exec.c @@ -3181,24 +3181,6 @@ static MemTxResult flatview_read(FlatView *fv, hwadd= r addr, addr1, l, mr); } =20 -static MemTxResult flatview_rw(FlatView *fv, hwaddr addr, MemTxAttrs attrs, - uint8_t *buf, int len, bool is_write) -{ - if (is_write) { - return flatview_write(fv, addr, attrs, (uint8_t *)buf, len); - } else { - return flatview_read(fv, addr, attrs, (uint8_t *)buf, len); - } -} - -MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, - MemTxAttrs attrs, uint8_t *buf, - int len, bool is_write) -{ - return flatview_rw(address_space_to_flatview(as), - addr, attrs, buf, len, is_write); -} - MemTxResult address_space_read_full(AddressSpace *as, hwaddr addr, MemTxAttrs attrs, uint8_t *buf, int le= n) { @@ -3232,6 +3214,16 @@ MemTxResult address_space_write(AddressSpace *as, hw= addr addr, return result; } =20 +MemTxResult address_space_rw(AddressSpace *as, hwaddr addr, MemTxAttrs att= rs, + uint8_t *buf, int len, bool is_write) +{ + if (is_write) { + return address_space_write(as, addr, attrs, buf, len); + } else { + return address_space_read_full(as, addr, attrs, buf, len); + } +} + void cpu_physical_memory_rw(hwaddr addr, uint8_t *buf, int len, int is_write) { --=20 1.8.3.1