From nobody Sat Oct 25 09:08:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520342982412451.85189205767153; Tue, 6 Mar 2018 05:29:42 -0800 (PST) Received: from localhost ([::1]:55747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCez-0006mr-Go for importer@patchew.org; Tue, 06 Mar 2018 08:29:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCVe-0005JC-Oc for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCVa-0006RX-RM for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:02 -0500 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:36360) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etCVa-0006Q7-Kw for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:58 -0500 Received: by mail-wr0-x241.google.com with SMTP id v111so20894746wrb.3 for ; Tue, 06 Mar 2018 05:19:58 -0800 (PST) Received: from 640k.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id l38sm25652538wrc.96.2018.03.06.05.19.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 05:19:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=GG8FyGaJIJGAdKnTkr7DQxGIWuvcWVtONCmF/qWLibs=; b=VwmJGslYiAi3J8a9nuaBPQj4V3JdP2YpWjlm4XYIMfA0bAxDlWJ3tUhTUt3U9E+pGm n7I8Eop4RrdP+29HEl/R2VF+4rnybTfLAVRTpdgWJCv/XlQPYokhnpl0BzLEt6s5wok3 K662+gzsuaqC4XTbvYycm879JSi4F3ncALuj1mhpNOjXZByQmD35sKesU6MZjIK5okCd cZP6chbg2PDqNe4DfF3K31CmhLT4DWs1Ii3lrWl6BHfrsRAZ9WEloNEx/4BNsh7BY/1A ywRCtg0rTpBgk01ywuuINTpA7oaSX/klP6D+Lab7NZaSBO68xI8oSfgFUK3lkLIaI4NG qtUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=GG8FyGaJIJGAdKnTkr7DQxGIWuvcWVtONCmF/qWLibs=; b=lC/DPkuZJUmuShiGbmtHhe4SHJ/Co9CQiE8CWfrI3wXUWOzM+GFW4bN/XnDt/PrLFU uRD2olFSFF99PGIF/6NbaRy0+pauAMpDiXpVmUMWZKyoyBr/UcZKCUwuAo1Xo+jhzS4Z pJaGSFGS1CRMchWC+eUW31/yO0Ve58z3sq4j1eJygVwON2idoATWUREEpk/ylX6LEKjJ YX4OxYi0EQAezamB6h3qn428pNHbLfm9Muay34ZgMHa91BoDFDQYkrKstbh3pPKnHWxG TUrn8QTNRhNl1Se8lnWk6sfoJ1Ahvj6hrqOlnnWp2Y2glZ3B/TGIWGe/0wSHFHzJEF/W d+mQ== X-Gm-Message-State: APf1xPBR3MG3cwuLVhtKnaxgnzk/wgqh74ScmU9hR2N+rw0tDS1JHxTW qzdJTV8ImqPUr8bGbWuLyawRwUvT X-Google-Smtp-Source: AG47ELvgFRviNjatBaZnea2h0asVZa05qvsqEJt9b/THBceIGxenz4E5ZwDbTI215CyK/gbpQec5GA== X-Received: by 10.223.152.83 with SMTP id v77mr15366464wrb.70.1520342397217; Tue, 06 Mar 2018 05:19:57 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Mar 2018 14:19:16 +0100 Message-Id: <1520342370-123606-21-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> References: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL 20/34] address_space_map: address_space_to_flatview needs RCU lock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" address_space_map is calling address_space_to_flatview but it can be called outside the RCU lock. The function itself is calling rcu_read_lock/rcu_read_unlock, just in the wrong place, so the fix is easy. Reviewed-by: Alexey Kardashevskiy Signed-off-by: Paolo Bonzini --- exec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index 62ed49d..bffb959 100644 --- a/exec.c +++ b/exec.c @@ -3468,7 +3468,7 @@ void *address_space_map(AddressSpace *as, hwaddr l, xlat; MemoryRegion *mr; void *ptr; - FlatView *fv =3D address_space_to_flatview(as); + FlatView *fv; =20 if (len =3D=3D 0) { return NULL; @@ -3476,6 +3476,7 @@ void *address_space_map(AddressSpace *as, =20 l =3D len; rcu_read_lock(); + fv =3D address_space_to_flatview(as); mr =3D flatview_translate(fv, addr, &xlat, &l, is_write); =20 if (!memory_access_is_direct(mr, is_write)) { --=20 1.8.3.1