From nobody Sat Oct 25 09:08:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1520343229967441.75097944718595; Tue, 6 Mar 2018 05:33:49 -0800 (PST) Received: from localhost ([::1]:55765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCit-0001fU-T5 for importer@patchew.org; Tue, 06 Mar 2018 08:33:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etCVb-0005EP-Fg for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:20:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etCVZ-0006Pn-J4 for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:59 -0500 Received: from mail-wr0-x241.google.com ([2a00:1450:400c:c0c::241]:34909) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1etCVZ-0006P3-BX for qemu-devel@nongnu.org; Tue, 06 Mar 2018 08:19:57 -0500 Received: by mail-wr0-x241.google.com with SMTP id l43so20924986wrc.2 for ; Tue, 06 Mar 2018 05:19:57 -0800 (PST) Received: from 640k.lan (94-36-191-219.adsl-ull.clienti.tiscali.it. [94.36.191.219]) by smtp.gmail.com with ESMTPSA id l38sm25652538wrc.96.2018.03.06.05.19.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Mar 2018 05:19:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=BNa7P5RweYFos/JNDHg6ZtbhBGSRpHQEEfFugw886GY=; b=KdweSSKeL7oZvlFhD2nzeeytYFGXcV3nlDjALuV+wT6e0OLn7UX/AYf1qoCdd+HFSw YLxekECM6yBZElsSnLy0OcG5rM11AOGNI2VxlnFuayYRCark5UrFqCnpDTbFSHFRzIoK klBgcgIBeuFOlm1BYGGsUyEQUx9aDEmzGeyms4nUYt5KIQkvldFUw1eax4yvTeHaSmDs zH3R2BsI6dizVSYz1EUotihmjQQCVKKHXoc5rODtvBdnGiJWvSB3XGXrFC/zFqmQQQci yrtdA4oMWTHX/CajVlXkIm1CpGCKtPMFzvUNULksvGYL8Z9okr57EAnISWgRkMve5OkH STTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=BNa7P5RweYFos/JNDHg6ZtbhBGSRpHQEEfFugw886GY=; b=r6HvXHL64P4XylL0zHsiJXmPrSVuKOPz3qQ5KUdlC0P3dkfTbHOXGafLS+CTSmX6Zy qHhhB0en9dyHAfU+f58aE35B6fFWSLF6ZaCZtv2yCnHnG0I3CeUGUN5uasa5I8d8Za8g FAm9gPhqGHHqfy3Rajsb/2dkIZN+zuDWjEgWz2YR1Jmm7anVU2wQbFPEsPFVyHI7PURG vK9htYBlQzhWPVSgT2PXu2lQFTBOwueoAK8ELakf5s+zpFLE53WKZ9owD7Ej2L6Ly7Xp PuHOkyEtagdNh5dWfLgjGF3FyC+KkjvkE0vGcEcF57/coxwt2JBlM85hWCpWbBvci7s9 aAlA== X-Gm-Message-State: APf1xPDJqj4GXD/WrMjWJtRL5XqpNGz/m4GMkbMzMUlzhfZlOAqR1bzU UdmOqaTSlAIBHAXqbVNabxwlX8KP X-Google-Smtp-Source: AG47ELtY4iZh6upSEzC+7X9zLGaGFJpzWCo+o4jjaF8z1pPTDXE4vUJRh68xxPSNWcL/RIUr6TLiDg== X-Received: by 10.223.145.67 with SMTP id j61mr16623481wrj.152.1520342396162; Tue, 06 Mar 2018 05:19:56 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 6 Mar 2018 14:19:15 +0100 Message-Id: <1520342370-123606-20-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> References: <1520342370-123606-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::241 Subject: [Qemu-devel] [PULL 19/34] address_space_access_valid: address_space_to_flatview needs RCU lock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" address_space_access_valid is calling address_space_to_flatview but it can be called outside the RCU lock. To fix it, push the rcu_read_lock/unlock pair up from flatview_access_valid to address_space_access_valid. Reviewed-by: Alexey Kardashevskiy Signed-off-by: Paolo Bonzini --- exec.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index e4552ee..62ed49d 100644 --- a/exec.c +++ b/exec.c @@ -3395,7 +3395,6 @@ static bool flatview_access_valid(FlatView *fv, hwadd= r addr, int len, MemoryRegion *mr; hwaddr l, xlat; =20 - rcu_read_lock(); while (len > 0) { l =3D len; mr =3D flatview_translate(fv, addr, &xlat, &l, is_write); @@ -3410,15 +3409,20 @@ static bool flatview_access_valid(FlatView *fv, hwa= ddr addr, int len, len -=3D l; addr +=3D l; } - rcu_read_unlock(); return true; } =20 bool address_space_access_valid(AddressSpace *as, hwaddr addr, int len, bool is_write) { - return flatview_access_valid(address_space_to_flatview(as), - addr, len, is_write); + FlatView *fv; + bool result; + + rcu_read_lock(); + fv =3D address_space_to_flatview(as); + result =3D flatview_access_valid(fv, addr, len, is_write); + rcu_read_unlock(); + return result; } =20 static hwaddr --=20 1.8.3.1